From patchwork Mon Aug 7 21:30:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 711742 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F93C001DB for ; Mon, 7 Aug 2023 21:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbjHGVai (ORCPT ); Mon, 7 Aug 2023 17:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjHGVah (ORCPT ); Mon, 7 Aug 2023 17:30:37 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A80E7F for ; Mon, 7 Aug 2023 14:30:36 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686b9920362so3291340b3a.1 for ; Mon, 07 Aug 2023 14:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691443836; x=1692048636; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uAYkRIRYZIluKvtE9wyso7bz3NBA4R/7X/MIc1OEt6A=; b=IpjoIQlrO9zAPquMVpWPu3geNpkgzVwiHr6LsNgjEHGuVQLAbCcMqg/FAHW8o962Lw AO5N3CZTMMudZZWnazZz3Oao3VX+0/KlfPWU5pdMI+yZPaRa+HpNsFEDEbaSUb+pWkqq Hv1E0FQMKz1KPcUm0x1kpP+s1RbGFdrfWbSvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691443836; x=1692048636; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uAYkRIRYZIluKvtE9wyso7bz3NBA4R/7X/MIc1OEt6A=; b=Gk3taP8wZLO1UOgxYhMitYQRE5Qg/PyCkbbb+CcWVDTkpbixKA0t0fZUZKAMscHCD5 vpeq5r0xDuoeTFEfKdIGGWZ6nwDRDDbczMLM2AOWuqSdBsM4tGCDz1tDVwD2IQpHWmbW M0EFb3iCguym514OS55Fys4yVS2O/PNeM03+iidQxOwEfwA6hOToOCat+HE08y14GiVI qo6ZnzzVnL8Twyg5Hopwj3utmJyqu6HRgYE+L2SHxDr1jHcxDgXMnHgMVYsdOMqLpRel FWg+XLfR+qKoEURleq8d7jSdT9WvG6xJAjF8k9NqY6otZ30vHFadUwAnibb/+3aVPoKq vDiQ== X-Gm-Message-State: AOJu0Yz8u5Yso8GZhJI/jmdrzoU7xKnEsnWO2gugUOYr+AI3LnxVxpNW 1Py2nPtaFpceesvgGfHdhAN+Qw== X-Google-Smtp-Source: AGHT+IEoqUeOi1Lnwc6XDO9laauwqASSeutSQn6oLmeZyH7g2a+JK7+y6n7HMT2GMjO00VGcdR59fA== X-Received: by 2002:a05:6a20:72ac:b0:13b:a4fd:3017 with SMTP id o44-20020a056a2072ac00b0013ba4fd3017mr10732055pzk.46.1691443836380; Mon, 07 Aug 2023 14:30:36 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id fm13-20020a056a002f8d00b0064fd4a6b306sm6571822pfb.76.2023.08.07.14.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 14:30:35 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , Andy Shevchenko , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 2/2] pinctrl: nsp-gpio: Silence probe deferral messages Date: Mon, 7 Aug 2023 14:30:22 -0700 Message-Id: <20230807213022.1862903-3-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230807213022.1862903-1-florian.fainelli@broadcom.com> References: <20230807213022.1862903-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c index 5045a7e57f1d..e32901a92fcf 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -687,7 +687,7 @@ static int nsp_gpio_probe(struct platform_device *pdev) ret = devm_gpiochip_add_data(dev, gc, chip); if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err_probe(dev, ret, "unable to add GPIO chip\n"); return ret; }