[v3,03/24] gpio: remove unused logging helpers

Message ID	20240208095920.8035-4-brgl@bgdev.pl
State	New
Headers	show Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843AA6D1C4 for <linux-gpio@vger.kernel.org>; Thu, 8 Feb 2024 09:59:30 +0000 (UTC) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Linus Walleij <linus.walleij@linaro.org>, Kent Gibson <warthog618@gmail.com>, Alex Elder <elder@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, "Paul E . McKenney" <paulmck@kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Wolfram Sang <wsa@the-dreams.de> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH v3 03/24] gpio: remove unused logging helpers Date: Thu, 8 Feb 2024 10:58:59 +0100 Message-Id: <20240208095920.8035-4-brgl@bgdev.pl> In-Reply-To: <20240208095920.8035-1-brgl@bgdev.pl> References: <20240208095920.8035-1-brgl@bgdev.pl> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	gpio: rework locking and object life-time control \| expand [v3,00/24] gpio: rework locking and object life-time control [v3,01/24] gpio: protect the list of GPIO devices with SRCU [v3,02/24] gpio: of: assign and read the hog pointer atomically [v3,03/24] gpio: remove unused logging helpers [v3,04/24] gpio: provide and use gpiod_get_label() [v3,05/24] gpio: don't set label from irq helpers [v3,06/24] gpio: add SRCU infrastructure to struct gpio_desc [v3,07/24] gpio: protect the descriptor label with SRCU [v3,08/24] gpio: sysfs: use gpio_device_find() to iterate over existing devices [v3,09/24] gpio: remove gpio_lock [v3,10/24] gpio: reinforce desc->flags handling [v3,11/24] gpio: remove unneeded code from gpio_device_get_desc() [v3,12/24] gpio: sysfs: extend the critical section for unregistering sysfs devices [v3,13/24] gpio: sysfs: pass the GPIO device - not chip - to sysfs callbacks [v3,14/24] gpio: cdev: replace gpiochip_get_desc() with gpio_device_get_desc() [v3,15/24] gpio: cdev: don't access gdev->chip if it's not needed [v3,16/24] gpio: sysfs: don't access gdev->chip if it's not needed [v3,17/24] gpio: don't dereference gdev->chip in gpiochip_setup_dev() [v3,18/24] gpio: reduce the functionality of validate_desc() [v3,19/24] gpio: remove unnecessary checks from gpiod_to_chip() [v3,20/24] gpio: add the can_sleep flag to struct gpio_device [v3,21/24] gpio: add SRCU infrastructure to struct gpio_device [v3,22/24] gpio: protect the pointer to gpio_chip in gpio_device with SRCU [v3,23/24] gpio: remove the RW semaphore from the GPIO device [v3,24/24] gpio: mark unsafe gpio_chip manipulators as deprecated

Message ID

20240208095920.8035-4-brgl@bgdev.pl

State

New

Headers

From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Kent Gibson <warthog618@gmail.com>,
	Alex Elder <elder@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v3 03/24] gpio: remove unused logging helpers
Date: Thu,  8 Feb 2024 10:58:59 +0100
Message-Id: <20240208095920.8035-4-brgl@bgdev.pl>
In-Reply-To: <20240208095920.8035-1-brgl@bgdev.pl>
References: <20240208095920.8035-1-brgl@bgdev.pl>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

gpio: rework locking and object life-time control | expand

Commit Message

Bartosz Golaszewski Feb. 8, 2024, 9:58 a.m. UTC

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The general rule of the kernel is to not provide symbols that have no
users upstream. Let's remove logging helpers that are not used anywhere.

This will save us work later when we'll be modifying them to use the
upcoming SRCU infrastructure.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpiolib.h | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index a4a2520b5f31..c3ae5bfa3f2e 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -219,31 +219,18 @@  static inline int gpio_chip_hwgpio(const struct gpio_desc *desc)
 
 /* With descriptor prefix */
 
-#define gpiod_emerg(desc, fmt, ...)					       \
-	pr_emerg("gpio-%d (%s): " fmt, desc_to_gpio(desc), desc->label ? : "?",\
-		 ##__VA_ARGS__)
-#define gpiod_crit(desc, fmt, ...)					       \
-	pr_crit("gpio-%d (%s): " fmt, desc_to_gpio(desc), desc->label ? : "?", \
-		 ##__VA_ARGS__)
 #define gpiod_err(desc, fmt, ...)					       \
 	pr_err("gpio-%d (%s): " fmt, desc_to_gpio(desc), desc->label ? : "?",  \
 		 ##__VA_ARGS__)
 #define gpiod_warn(desc, fmt, ...)					       \
 	pr_warn("gpio-%d (%s): " fmt, desc_to_gpio(desc), desc->label ? : "?", \
 		 ##__VA_ARGS__)
-#define gpiod_info(desc, fmt, ...)					       \
-	pr_info("gpio-%d (%s): " fmt, desc_to_gpio(desc), desc->label ? : "?", \
-		 ##__VA_ARGS__)
 #define gpiod_dbg(desc, fmt, ...)					       \
 	pr_debug("gpio-%d (%s): " fmt, desc_to_gpio(desc), desc->label ? : "?",\
 		 ##__VA_ARGS__)
 
 /* With chip prefix */
 
-#define chip_emerg(gc, fmt, ...)					\
-	dev_emerg(&gc->gpiodev->dev, "(%s): " fmt, gc->label, ##__VA_ARGS__)
-#define chip_crit(gc, fmt, ...)					\
-	dev_crit(&gc->gpiodev->dev, "(%s): " fmt, gc->label, ##__VA_ARGS__)
 #define chip_err(gc, fmt, ...)					\
 	dev_err(&gc->gpiodev->dev, "(%s): " fmt, gc->label, ##__VA_ARGS__)
 #define chip_warn(gc, fmt, ...)					\

[v3,03/24] gpio: remove unused logging helpers

Commit Message

Patch