From patchwork Mon Apr 7 07:13:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879183 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC88A226183 for ; Mon, 7 Apr 2025 07:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; cv=none; b=j8a39D2qY2GHE/Zz9sgkZFT7ssdZpmbZMVh01gijiL91z8V7Wg5BZe7F4kb5Vbbpowf8kgBs7gHAk4biEfpQa9vxdhvEgHx5f+uYllTbm9Ca94QrgdoMPgE9HyZ2v2ddWgKFO/Bj8rZmEBV0HllLwodcJb+IrHtrYxF2RWTOzoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; c=relaxed/simple; bh=RkgKWhSsIhzUGPNoN0mdX6+aMhttLmif45hukjZbTak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JeKGUgEBdix3fSEvl4nFnkCfyfgAG0pMeeYmXVXJLwOMao1qU6YXS5d72vXszlU8zz36G0ZbTsIgtR+PRcEH9KmX0lxuTDDliUYDfxp2oKL0Q6BESYfD7cTeYhcCajcR59GLOSiT+R7WpT+mCiLbjBHx+wE0IU/lyBBY9DEnlro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Y0eV9Ely; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Y0eV9Ely" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so37129365e9.0 for ; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009999; x=1744614799; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5Wepzn0bSrTUctNYJZv2tNgjnTLDxfYJ7sTLL6ztZhk=; b=Y0eV9ElyEWsNC26ae+aWsk+VQJUCR6i86K83WsCONwlnsgv7DIsfam+//8fTcmI5xm kayKIr4Z448ikiJViaCUQ9OhJG9ckTJmXPvK6oymZfBtIrVVrJQETybdmQ8rkKk1P4o/ d9MEy4E4j3MBvjsOCmr4FNDASS+WdYfdZWEa+nW6oIRswgHARbfY1t+1b7SkHU9xO3Vk 9x2Q8Nr5XUqUOJoU5fYK9tkdfGV/K1gPeiG5hKCRZiV6e2A3bJ9vMs4USVjYu0gLVdz9 lbF9bu2/PheH747IeMkWmSeIiUocxDJ/itcn49n0jTHtIcwtucImmQViNdhJTV9LZQ72 cqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009999; x=1744614799; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Wepzn0bSrTUctNYJZv2tNgjnTLDxfYJ7sTLL6ztZhk=; b=Ys9gh2gWA1SPAa5uqAitjK4C6wT99IXSaikmjP1qsr1csp3c1qbHUdRWRyBXV0vEeR MKxziPDzOPXeFlF+bwd1gFrs0Dp2Kgp6IPJ3FBsCeisXSofujasn8WIgIwl/Hn1wPkjV tefIaPrz6dHVvdZHoJ2ox3TEvjRPbTKlBZwUW736QII70d7Dmpcpk5KOT03h8lv6Qpab nNz2/dYL24JeT3ppiqDS6G77aiduVD6+ograaV3JCbS4Xbxs/eKHDXOaWcwvuo4tAvBg ERomAG13JspC5g4HhHxGjQd2gBfveqYLSk6iTyaosf3j7lSAvy/guU4KsaPsWeci1Ysn SuzQ== X-Gm-Message-State: AOJu0YwtuJz4y8MZd+283T5yB51mdnZcNgm7mgJmt+0oE9tiopmI/r6S RvfW1CJ1Cscjzz6qPuUELHqaN8WzTwOZSXhdIhLkP4rpSRvhuBOAiCHqSQgQrN4= X-Gm-Gg: ASbGncunpWw9H78x28znWA5EShO2JaWnRSsVg2lvdnwc6jSfqWMsfiWfIi2oiLbXlrU gKkjXQFuXos0gNNgChwKQIdnoQomsYiycvi3/DNznLB2tiYCQ+/toeQDYaENJax+KGOARBXycSu PWCzI0iGB36iCY9wcVLRAzJpxa+5Hltk6hmIEwJfiHV3kmVfswM8ldGlrlpNbr36lo0Fzl9n/6H zDzSrJnATCr4zjMQzFlKndlDe2cEI7AAyMRz2RN3jyq45uYwQ9af4Ht7EmX66vXD3lG7fUm2DkU QbS2XODJmAQblwPlmDY94qtMz2Gy4g4IXBpmhA== X-Google-Smtp-Source: AGHT+IGyhcE/IuZZs8QulBbS6kDGMJgDPUGZRwi3YwBtd/IiuYNtNzwObPJBI62CcG4AJbpP58tp4w== X-Received: by 2002:a05:600c:45cc:b0:43d:fa59:be39 with SMTP id 5b1f17b1804b1-43ecfa19d6bmr74493645e9.33.1744009999121; Mon, 07 Apr 2025 00:13:19 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:18 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:13 +0200 Subject: [PATCH 04/12] gpio: exar: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-4-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2554; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=VBaLRwvXCHSMDlXyQDnnPc+JoISPQ5RIJj1Yyuoo2Rs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIsJh5mSBLL9JNqgm94zsMHoeoOktkEKaU7 V2KAnuiH7+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX cvaXD/4ub9soMp+EVeLGnbmKaoZNeP/e4NlLxD38WiXqNsu67ARWHZfjRxY2BrkgMXVjQc73eMA 0oie2U/HcF3/c12LooTmi5brOGQ+fCEyeJQ6VrhV1iPTeUIngkxnqEFSwhjaR3uOZXuBTagR9FE sWH2G2b2tA2dSDIRvZFAq8oagJNspszfKhWNs2a5Y0IUWweZ44MEWAr+vOs+Bglee4oSqzhF4gw L+dzjx1n0A9OV6yCTGJKkT+KE3pMTDPO5iA23NEtZJVkSt6Y8KFr+si/0Xef/BklhQactoHIOIl poLVGDC8YF/35IwvA8WO4TMKQYfIsf5a+yDotBKUHM+cNhf1CvFwFwW0RxBXnawszz/c2nGNTfW ObCZVfJqTLx3OqhlodGwV0RH7nMxqiQddS6k409LOqWQn0NvQ/n2tjISXlVffHCtiKNemayf6aQ aO0x7xQ4PKifW/1pqzo2Qz1c4IrjV0TeZfb6InVjbuDE/r8mJ1QA3F56CGcRkioDtuJwlWMm59K wrw7CeV2oxut2HnUIKiw7T1P8EBT/ZgvZOKNtvgZn1EBxdO4bhEmqY8O7kISkmlxTUET+x+nR66 Z5Erx5zbPnm6l0wBxcpkSjm635yxE+x8qQWpANIRNYqE6xIA0SSfJ+TdfOpqZqiCibCnpkcqXqD LGUtduA/iEYlDSw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-exar.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index d5909a4f0433..beb98286d13e 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -93,8 +93,8 @@ static int exar_get_value(struct gpio_chip *chip, unsigned int offset) return !!(regmap_test_bits(exar_gpio->regmap, addr, BIT(bit))); } -static void exar_set_value(struct gpio_chip *chip, unsigned int offset, - int value) +static int exar_set_value(struct gpio_chip *chip, unsigned int offset, + int value) { struct exar_gpio_chip *exar_gpio = gpiochip_get_data(chip); unsigned int addr = exar_offset_to_lvl_addr(exar_gpio, offset); @@ -105,7 +105,7 @@ static void exar_set_value(struct gpio_chip *chip, unsigned int offset, * regmap_write_bits() forces value to be written when an external * pull up/down might otherwise indicate value was already set. */ - regmap_write_bits(exar_gpio->regmap, addr, BIT(bit), bit_value); + return regmap_write_bits(exar_gpio->regmap, addr, BIT(bit), bit_value); } static int exar_direction_output(struct gpio_chip *chip, unsigned int offset, @@ -114,11 +114,13 @@ static int exar_direction_output(struct gpio_chip *chip, unsigned int offset, struct exar_gpio_chip *exar_gpio = gpiochip_get_data(chip); unsigned int addr = exar_offset_to_sel_addr(exar_gpio, offset); unsigned int bit = exar_offset_to_bit(exar_gpio, offset); + int ret; - exar_set_value(chip, offset, value); - regmap_clear_bits(exar_gpio->regmap, addr, BIT(bit)); + ret = exar_set_value(chip, offset, value); + if (ret) + return ret; - return 0; + return regmap_clear_bits(exar_gpio->regmap, addr, BIT(bit)); } static int exar_direction_input(struct gpio_chip *chip, unsigned int offset) @@ -209,7 +211,7 @@ static int gpio_exar_probe(struct platform_device *pdev) exar_gpio->gpio_chip.direction_input = exar_direction_input; exar_gpio->gpio_chip.get_direction = exar_get_direction; exar_gpio->gpio_chip.get = exar_get_value; - exar_gpio->gpio_chip.set = exar_set_value; + exar_gpio->gpio_chip.set_rv = exar_set_value; exar_gpio->gpio_chip.base = -1; exar_gpio->gpio_chip.ngpio = ngpios; exar_gpio->index = index;