From patchwork Thu Apr 10 09:34:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 880380 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3385266B5B for ; Thu, 10 Apr 2025 09:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277709; cv=none; b=SwLp9UehcqJdJaC21Gvmqa1cynxKmPkgktcpk1VWpYnmb5Emh1E9XziawFNgx3AQDw44SFN/nCMZ75rnXCLk7v9E9FrtC5pftLe/Hx0GErmIcKxNrbkk3Lmpnr2Dkhn0kf4pyIQHsjB0jzSjcHZwNWfNQNTR/zoBKBsJ7wz44Kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277709; c=relaxed/simple; bh=CBNSk3yrCFCOlbMgCfYWRT8QGkYmxOkTlZAWAhHftYU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Cfp2rYX4ZnHx3CqYlchrQenM1fanQaEqJBfOZzXa4yEF54L6QAatArusnbeD2xNom0rVmSkc8WePFLOjC/yqq0Gz2/L3oVtMU+56P2SoM86UKwc5cF1XM+/CJ5I0XV9hi22ET8czQnwJW1rUlND2r0tQeonFt7AheXAsmSIqnho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=0cs86pYG; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="0cs86pYG" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so3869785e9.1 for ; Thu, 10 Apr 2025 02:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277706; x=1744882506; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9gEo2m/viZuy0Hum07/62VQBUfloVHDkw2x/xR0+XyA=; b=0cs86pYGm70abco9fjhM56Qmym0LhpLkpUrxLBo0/CFg8TLRyz3qmKXaW0FjHK6XuX nIElyWL4LjpT8RKtNo9LEkamYipdLZTg/xNwSjOALmuNb6YOn92is+IhkdO3zomOeTOk lZkT6Tidf5NKh7NZFqz+QL1CtaBEsoD5kzcZvADFYEtD0Mk57dHw8UC50RObtE8CadsC jV83lIgOzaC1f2+zL723m1zwLv9QKs7RNfS8CUu0ME2ejzue5Zx22jK734ypgRyeYESf 91rgJardeEFqDH1qyauFKubcem07r3kpli/FPiSA54LX6YUnQwTAcviKkt8OHeG9vuRx uMGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277706; x=1744882506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gEo2m/viZuy0Hum07/62VQBUfloVHDkw2x/xR0+XyA=; b=bObyx8nFv9U4Ng9Ov0xkvwpPmmhDwtAWOYhQZFUX6A+nC+N+xnjQ3fymtASHZ+d1C/ expSVtufQlfJf9oRsc4wUY155342VA3eZESGtgDjc8HxEbe5Tzs6bTHUv3faPq+NoNa3 XrGT/sKPldLDOzBoIbGnyt/n0SwvlzEsQ0/hVW7VZiq7cuwlsk7P9liHLUv2qE5K+uSf Z1YpV/+Xx98hBEKHzckIQKQYwYKHyNqryGCDHNysbNbfQX086mCNoB7wOJ7UXwEChAdJ HcDIrv3k3e6HXiPxKK3FCOzdMoVEStK3mQY3pyYEhOMVHll5levG+IcH1t+/PW9JkSfc z0RQ== X-Forwarded-Encrypted: i=1; AJvYcCUFgKKrFHmM6NBdAYlF0d23GhNyJ6I7P1maIiiA0sDvWntUmcJ5DvNnmCatYCEykW1U/eTnI+XYYEIy@vger.kernel.org X-Gm-Message-State: AOJu0YxOH8pO3ARLuXEFIZpXlSc4er2BTVgEHFyAdoc7XriQIi7elIrI R3E1z+/iIgQgs5wO42JGnUAYEWr6TQBXSggWZBLI7Xh7ShXvA7Les01DyrZuZPk= X-Gm-Gg: ASbGncunq/mqYl405erbAbSjj2bpkaq4HkC/Ily/BBnLEBdXTmcJ/fSAkvFCsqT9vrg jUHp7M0LhsXxFDRYVTwzYGNuoke6P+rBB4UwQdZcOCUUnXzWI3LJFCMBIB5VN67/qfTcKvKZjoX RVKPKQ+3PrCETTJGvC0eh3afpSrwU+KgFrAbE5JT4zrVTYM1Ud/1Ggsrnf4Q3LZ75l4cNc3Gp7x HjRiND1qhBsQynIiL9AjTcUeRitvhRlhOy5DSPKF6H4aPUrGNoF49HK+WJtmxgJX0+8pleGM2+V uSiQLDPDG5u01b+U8pUFXCwpEXGgk3Dx5w== X-Google-Smtp-Source: AGHT+IGQMtxSsq5/DE95xt49hSnwg6XZGyLcP+OE0baBUHtuUXr/MHr9x/DHvH7LZH95Mxedo/aa/w== X-Received: by 2002:a05:600c:3c84:b0:439:91c7:895a with SMTP id 5b1f17b1804b1-43f2ea651bcmr18434155e9.7.1744277705965; Thu, 10 Apr 2025 02:35:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:05 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:47 +0200 Subject: [PATCH 5/6] pinctrl: qcom: ssbi-gpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-5-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1682; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xuF564c737gHGSAxOu3BnJZRQm091DpG8CWSw+xr7mk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DEb1OYPZ+ZieVXFnz0F0FKQSWFLy4/qEKp3 g9UkQaGDgeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQxAAKCRARpy6gFHHX cpUREADdsULQgfyLf1FD3y7lCUngOFoOXSIwIrnRGGnV6dhK2OgKaj39Tls94XN8rhXJmaB5sEN rzMQlgx6LPSQmtDp3ommBKAl6XXJmVpcoV+IbFwGUfl22YKcbbYMoPV6DscGqmrjKaW319adR5c oITO9oitlqJKv/8mcI1DYGLzU6BeDnerRTsXk/KeggzCt8PHTfe2u06NBU652qYoH9gl50FOehT bP1RiE6bSPO7cyTx7fuuvlLVkOuRF+Bbou+htvyVRuDsaLKpRXTBosXDte3QcUEFeR58J4NdaMV KhIPuDKTV8Al9aDT1BIlBPkn3G3xXKMJXsACgD7Mc0jROrFdGghF2TLUxBvuJEGnGCjwmBnWrDP mZxKw5fQTPfiq0EvVd+5O6IyGGhL+KZoqDXCZ+HxXL7jS4W3iWaGHRg6tljnKsAwm4IZ0xpFDOG vIP4jDPnhkKX9P1I9qtGFMruUE+CX9/A4Ksy7mfu7VoMhlcxFCXrJsgEQvEwwY6xJLc7A3tJnsw O3z42DNFTPwz7VizVvVx6HlZ5uf0m7yjLAOf9y1t+0tzsAUbx5q5Py7RTmNDdVnzS5EzPC8J8Z4 kyUOaRLi3fLnVWpy1pJYrBV4LfiR5e3PVrjgUTipIcVv4eDFpE4vgppvYdY/fM2Ovn9Vfv8Y8zY g1bUBeQJ08MT9sQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c index 82679417e25f..3a8014ebf064 100644 --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c @@ -507,7 +507,8 @@ static int pm8xxx_gpio_get(struct gpio_chip *chip, unsigned offset) return ret; } -static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int pm8xxx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct pm8xxx_gpio *pctrl = gpiochip_get_data(chip); struct pm8xxx_pin_data *pin = pctrl->desc.pins[offset].drv_data; @@ -519,7 +520,7 @@ static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value) val |= pin->open_drain << 1; val |= pin->output_value; - pm8xxx_write_bank(pctrl, pin, 1, val); + return pm8xxx_write_bank(pctrl, pin, 1, val); } static int pm8xxx_gpio_of_xlate(struct gpio_chip *chip, @@ -596,7 +597,7 @@ static const struct gpio_chip pm8xxx_gpio_template = { .direction_input = pm8xxx_gpio_direction_input, .direction_output = pm8xxx_gpio_direction_output, .get = pm8xxx_gpio_get, - .set = pm8xxx_gpio_set, + .set_rv = pm8xxx_gpio_set, .of_xlate = pm8xxx_gpio_of_xlate, .dbg_show = pm8xxx_gpio_dbg_show, .owner = THIS_MODULE,