From patchwork Mon Apr 28 02:09:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 885594 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB8351922DD; Mon, 28 Apr 2025 02:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745806246; cv=fail; b=pkGMGm18HU76o9xqix3skl502nC0BMAA/OmKBrYOeHDuSDSeQfiL06rQKMCU0A2KguarwkFvLR02en7fv5SQO1F80DFYVjeSlQqhJjjuMFiHvbA7gTsl2S+hEi3/Dp1HI8OY0lfgbRue+OUKBCTUpdkeGuKB+Q/MHlTFAm5bbEM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745806246; c=relaxed/simple; bh=6OJosQsgoZeVf+CAeFwBwJvt24FJz/Jjn4VZbw7iXjs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=EKW/7XfNCCBB/7K76r79cLkYqo4btVcYmNXrmRNDjbV2phDWFtqvMXNtFc69TPAjA/VW7pTErY5SMISTK+uj/YakVW3Q5V35Q+5BnJqelDC/ngTqe+U6Ehd3ei/R8ddXU0CMv3mUgSgecDYA7RNZLtNbGqW2whyaPyw3r8P/SxE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=PhhapwVp; arc=fail smtp.client-ip=40.107.22.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="PhhapwVp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=owE7vjySe89VyU1NXiI5qKp/+4eqkeaK/obNhnvi8phCto5jC16GYkZH6XBtQnJUoLBV6SINMpbDfUB5JvNIrO3/1i3pAQI2qbxZSItYqxwpowC1KOE4KDt7LufeH9lJuW0PfpXOvdPiWmIwm59Xki4TqxXSd5Ur2B/cLJ6tLm288WnhsRqjbyC3C14tJSl/0UnWMBJhnbYkGwy1wIn94wOZ0K14TpEtL7udtAKVJoiNRdQnTe9OcGGU6kkLr8k63L5zSfIcep4IVGW/95pwLZC0km1SxvOZTtxvUVhxuiw+aXcEq/6w14h+twdwl8J9zE8QVe61TwySmUYrbD+/Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cHnonqj6TqjEO+bdeR9PE2IVjJH1Z/oDWKT8HU7ATPQ=; b=PCPAwVBrvtZKwiI2E0FxA5nu7RXk1gtJ2URjSBAmZbVIOlbv/HiAoYY2CcorxE4mUmISvNEEhnnjXJxFbEsl9xKPUD6GGzBBvCQycaGpvtm8S5oefTmJonDFDv0HgmuMzKjIl8lQiDp4YjQz0WYIhkYy687kvV9k7i3KEOMj5/22bt8Ug+GSljiYQC01dvdiELjVlwCp+nrD4YtxctZhJ2e5EuB5wLVO7CsdByL46CEUI6fQdb6WFsJ+0niBPKJJpm9M6oKb060alZYo67TvFGBFhaiwum9J6yPb4DdNfS/O2Vvi1oxptLjKhVDxOIrXRSSjJpVJKwiWHV7oEOwssQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHnonqj6TqjEO+bdeR9PE2IVjJH1Z/oDWKT8HU7ATPQ=; b=PhhapwVpyo7wa4hKOdZYtnuOD7r+BM0BQ5jpPvVjP8Ucg8D1Oqvo4UMHanaVhLlHZpjL+xsl3b1MzHUup7MIzyA19fUj1eld8p4IZXFxgRVzmkwb/1XZmlmgKlLVXllBlRPyqjysiF9ekZL1reXhbAGc2YZf418CetBsfG7C8/GgLHuSSZQ14grFa1Oi8rU6AnTqSet2CaF40hjU1t8jtDLmO6aNN9TYYBsr9qmJ4CSiClPh6qcdtMl19wnhGN10zhE8BORRSNhb3xubRTxeD1tgZH8nQqTY/lLGMAPt9ZTb4/gHlRjgpYqDmJbXpxeqbgKD0cb6hnGuYGEL4Xv0Og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GVXPR04MB9901.eurprd04.prod.outlook.com (2603:10a6:150:113::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.28; Mon, 28 Apr 2025 02:10:39 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8678.028; Mon, 28 Apr 2025 02:10:39 +0000 From: "Peng Fan (OSS)" Date: Mon, 28 Apr 2025 10:09:04 +0800 Subject: [PATCH v2 3/9] ASoC: codec: cs42l56: Convert to GPIO descriptors Message-Id: <20250428-csl42x-v2-3-e8056313968f@nxp.com> References: <20250428-csl42x-v2-0-e8056313968f@nxp.com> In-Reply-To: <20250428-csl42x-v2-0-e8056313968f@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745806152; l=3502; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=y5bE1dUN9BJNDNAuO6eK1sD9+kDknDSsErweZYOv+qA=; b=s8V5A7KS7AvuDQk4wLX4F73eY3IGoxJLriXWYjhWEUVw2AkvCyWSMjMg8WlT5H7dFzqcYMpN5 JQPrQFjR1fHDMwohoovre6WW728CGddg0BjqDvBujXO5Dkve74ieqy5 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0027.apcprd01.prod.exchangelabs.com (2603:1096:4:192::7) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GVXPR04MB9901:EE_ X-MS-Office365-Filtering-Correlation-Id: fad24309-cac4-479b-c386-08dd85f9df53 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?r5T/Fgi9vfTlfz08QksQhh2jjYvmoAN?= =?utf-8?q?u8XqIKahH9Ejc2fTeV1q1/uuk51QJY5+MnwnjqqCq8137rCYrF7CvvOOGcgpCpnV3?= =?utf-8?q?5TEqfoL3xicfrfn28hgo46i6IjkVXwQOoJp2ZwfsT8xW59zJfzkPXefOrwZgKCiqK?= =?utf-8?q?15CVNquJVJwOwEGrMmnCke+euelk5KY51TedGDCWQ8YDPhl2SXU2GtIoJ/yGfW4ME?= =?utf-8?q?I6FSxv1YeAScbqWAxAngwBBwwW4KjdDz6mz95nabr+iX7xZ8g44/HjjhIysKU12mf?= =?utf-8?q?x5MyoqiO6eJqHSeKNaenhZ5WeNUGJb1A543sg1EF9xx8IddTBPKTzU7nF0kthF9X8?= =?utf-8?q?F8xQIhc/C7uivWLHwKnGfspxihANwgHjqe3iLBYeOVN9t+zOvF5mOoXMCOOY7IKet?= =?utf-8?q?3/Zv9X80k7vNzNJ+1fc6Bwx8suJGZkUcC9DTwN5Feu4gruVk4SguWOphRmcWCkMs/?= =?utf-8?q?IXdqY/hmBX0n8oe06JFbiqAZLd7FcNYfTLlQ4P0vCeZONYZyaTMBFq4/TFBGhKIMu?= =?utf-8?q?0kTgBAsEZx9a6XWXZMC58axHftu7UbvLTgJ2mjdIcSwHtSuM9RliZXdah7HzgDCiu?= =?utf-8?q?IvZnJqd26bblPctaGSL1XEU3KLwWOcK+0b3apKLgSxZWU0pcq5szzMaJNj/FU+R1k?= =?utf-8?q?HPaWmdkqXTRWOkLnlxgEJvO32PAKvHxegw6yep8wfqarmtfoct/w8t8Vk5e0QbiC0?= =?utf-8?q?edSZaPfcsTkxRQmDB9qzbwKqnfGvh2rlS5BLdyXuwN3tGExwGw8CAP6tJZukuPf4I?= =?utf-8?q?AeWCkfbIZaHcWxSF2d/l1Fj4Z9SLe0ZiQ9Wj1LvNNarUwlX189UZLNR3+CXwj7RjZ?= =?utf-8?q?Bh2QCla+DQS/S9PbhHBVuHa4F33xyN3RYDIZYt9vYE7PD+20wW/zYMkr4p6A1i9mF?= =?utf-8?q?TM9+dsjV05SqvK0nKC40aNK0BffSfPSnJxISywoiDfXgx1Ae4a0KAOzc1ZEHnPet5?= =?utf-8?q?7q8IzLHxzQPEaQyJ6YkRiJFi0HOeLHBAKG9fBkEH+e3OkvRtrMJSG9s+UsSXOzkIJ?= =?utf-8?q?CebmKDHdwN2h8GaFrLRt7CdtQ7KIgbK88uM9cicl/1aqY2SbcCobJhugJnNQBRAMB?= =?utf-8?q?n6M/FuVxMgxiIpd3BMXUajHMHk8hnTr+nWGrM8HR9Yfj35O7m/VuTn0oWncwPXEms?= =?utf-8?q?LIiqHLBCkQ/p58Pmf94ZqwpGnz2RS5+qEaiN+xE9UPsokwW2BtCmR6sDEBykGzcda?= =?utf-8?q?m7AMEcjC+9wSasSesTjtS3YC/wfK5yk80CPyfboY6+PsdTtOAo6IVj3SkFUKsksxV?= =?utf-8?q?IVFeY5lN0hKfdtuwgnLqqje40UC8jTzKgyWetr8IL6yFmkiDK/hR9brr+Saf4pirD?= =?utf-8?q?jhJl4Ezdm+SsllEVClPq+84lV7bgDXlYngpsr2VRHA0+VXN8defAVBMVumT3WSz3E?= =?utf-8?q?tnZdIkJVMOzjbThjT08BDP88zS+vtEg6g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3InmxR9B7U1i2hgBlynHIcmAL9wT?= =?utf-8?q?tgKchsj6VjrsqFcUy6X+BFT5q9+WxENdI+vxHvZLB7f05x3NrkRXnpq5r0ZZbUORa?= =?utf-8?q?eoBp7Sh2Z/iKqWwRs8NF7d54XYmjDRnoC2NavGSHm6VxFiTxW3MdEBZF4aqvwxzaW?= =?utf-8?q?ak2Hyk7bnX36vdnesdEKHLj8fOMlnfphrAdiWBMmK67Pd5S+kRjxpq0GDLOV2fN1U?= =?utf-8?q?qLthr66Jemc3PCoBfkUtVU6Uw8f7h1013INqZ5MSyjsIRV4xdr02QbTW9gJRb/ku0?= =?utf-8?q?e24B/Z4HlN4xfb4wt+wW9IOOJdzEG+9q/vkg4Fl0OC6dHQLnpZe4dmbhkMyN/XZ7N?= =?utf-8?q?VJHBguDqLB7J0WkXcC+XUmcUJWFxFP0b1xPm8E9I8Zaj4sg6Vuk591OBJLAop2QnG?= =?utf-8?q?bobPeeQ1i2d6EEsCwgzbOZ3myPIi40amJdW41WtDtDcmT5XE64ypElKsa4PzBXirp?= =?utf-8?q?npkwvfA+tKW3i2nXhCoK2dcMhgJ7QlLA+uvRnhRVi0S6Qgsqx8mpbH9zY0rubP+M2?= =?utf-8?q?PKlHMtpZnP4cwAxjTLFZ+oVR7RlsB4AgNxr7/b0sLNu8h6V1rXFf1IUVOAD5gZaXk?= =?utf-8?q?nZ8U5XBxdCQ6pLTFuqDe4foLeqSLZ2RIN0X0yRQA9uNRrR4FwlrkjsyN+O3LpktE0?= =?utf-8?q?TwBhsXmUBtwPEi4HAIrJw2xjGjVMJT7fbySrE750qcYFcyvwti+f7hjFiat4Krtmo?= =?utf-8?q?5Ei5rYtbEqHQHv6eTeMhyhCxeqSQt203KVDQajB8t3bsPnHzTopTQyYe5erQ8+aCY?= =?utf-8?q?gUwKeBgzYX8Btugoyi9WqdNo2yOHnWca+PeRUHBrFQErF6hfNOaxWvqvAwVSLDDjK?= =?utf-8?q?frtzOvOyyUs8oVwt4wgVxOXR+TCEgSEg1NrPmpHm48rhOitPwYBV2it0ER80pkTOl?= =?utf-8?q?RroHRdSVhBNXoHQwpJr+mGmtKITIhIKKsEtDUuKUYr9DoZ+Oj1laW6Z2gnMrqKE5d?= =?utf-8?q?vS14/eueUHxoKG92cwHtZ3Z6Sg6yydErLUg8zVo+YCD+/ZZsZpV7NKCJQEYIukEek?= =?utf-8?q?UWAPo12jrzrSUexUtQeFMjA7OTt09MRiFobi6M/qkUqC6EoOpPFykhnp0BK5SlscW?= =?utf-8?q?7PzyvhRIeAaP4pMThjxxFEMMYwLwBP4iuCeRoHFQ87lszDjRz1YA2gTED+kpifVTa?= =?utf-8?q?fI1l2OLakvyhZSFby/MhL6FAMK5a/hebfH3FmRjMWq6PRnkBF3+rS7dpktrRS1frx?= =?utf-8?q?pBhzpWnnXC7YnKQM+qA5I1efQiSPyhoKH0k2/O8GnOnRnlB0FcFC2p11tdHhypWCa?= =?utf-8?q?hLC73VfhCLoBuaYrGwVyzV9F/LsZyvU7mo3Ysof+UjCAtF5BOjs8/Mo0HaatoLrfh?= =?utf-8?q?BQigdec1W/nOx6sRZntIss6KBEDhvIoZRulrMR/4JYRDRWeC6byxd/1q3VahG2guz?= =?utf-8?q?D4ZVHrMU50P9zFXJXwjjKzYLDsHjaFAtJjS2yuD25+g0VmgNwDucGf+crOEBhEgbT?= =?utf-8?q?to29IAvrIesx8ZjSaCqdonFomADxBs6zId0CSKSM5a2hcNI6DBfMKg26eKerhkeBH?= =?utf-8?q?SXn8SxMUsgdi?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fad24309-cac4-479b-c386-08dd85f9df53 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 02:10:39.7815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ykst+NPs0OCXnis5laz0MEtvoR74g4YbNd8AhEYddOR7D3FNMO9beo6Ni3MgykwVfS4Ph0SNrAaLJMYCeIjk/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9901 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use devm_gpiod_get_optional to get GPIO descriptor with default polarity GPIOD_OUT_LOW, set consumer name. - Use gpiod_set_value_cansleep to configure output value. Checking the current driver using legacy GPIO API, the nreset value is first output HIGH, then LOW, then HIGH. Checking the datasheet, nreset is should be held low after power on, when nreset is high, it starts to work. Since the driver has been here for quite long time and no complain on the nreset flow, still follow original flow when using GPIOD descriptors. Commit 944004eb56dc ("gpiolib: of: add a quirk for reset line for Cirrus CS42L56 codec") added quirks, so the gpio request API will work as before. Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. There is no in-tree DTS has the device, so all should be fine. Signed-off-by: Peng Fan --- sound/soc/codecs/cs42l56.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 559476f767b0fb628bae6ec2728226af315b05fb..98fa812bc07b87fae717d601561d4ab3b9ee6bdd 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -8,6 +8,7 @@ */ #include +#include #include #include #include @@ -15,7 +16,6 @@ #include #include #include -#include #include #include #include @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include @@ -36,7 +35,7 @@ struct cs42l56_platform_data { /* GPIO for Reset */ - unsigned int gpio_nreset; + struct gpio_desc *gpio_nreset; /* MICBIAS Level. Check datasheet Pg48 */ unsigned int micbias_lvl; @@ -1194,7 +1193,13 @@ static int cs42l56_handle_of_data(struct i2c_client *i2c_client, if (of_property_read_u32(np, "cirrus,hpf-left-freq", &val32) >= 0) pdata->hpfb_freq = val32; - pdata->gpio_nreset = of_get_named_gpio(np, "cirrus,gpio-nreset", 0); + pdata->gpio_nreset = devm_gpiod_get_optional(&i2c_client->dev, "cirrus,gpio-nreset", + GPIOD_OUT_LOW); + + if (IS_ERR(pdata->gpio_nreset)) + return PTR_ERR(pdata->gpio_nreset); + + gpiod_set_consumer_name(pdata->gpio_nreset, "CS42L56 /RST"); return 0; } @@ -1226,19 +1231,10 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client) } if (cs42l56->pdata.gpio_nreset) { - ret = gpio_request_one(cs42l56->pdata.gpio_nreset, - GPIOF_OUT_INIT_HIGH, "CS42L56 /RST"); - if (ret < 0) { - dev_err(&i2c_client->dev, - "Failed to request /RST %d: %d\n", - cs42l56->pdata.gpio_nreset, ret); - return ret; - } - gpio_set_value_cansleep(cs42l56->pdata.gpio_nreset, 0); - gpio_set_value_cansleep(cs42l56->pdata.gpio_nreset, 1); + gpiod_set_value_cansleep(cs42l56->pdata.gpio_nreset, 1); + gpiod_set_value_cansleep(cs42l56->pdata.gpio_nreset, 0); } - i2c_set_clientdata(i2c_client, cs42l56); for (i = 0; i < ARRAY_SIZE(cs42l56->supplies); i++)