From patchwork Mon Apr 28 02:09:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 885591 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 136931CEEBE; Mon, 28 Apr 2025 02:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745806269; cv=fail; b=ZRp7nF+Q6HHig7WGbENeqgH+UMZaEpaC/MA5iPj3F2HHinH0P1Gnfaf1XeZLrVaCeqG2R4s5TG+3pM/KMeggG0SNYCu6HyJBImWaZ2WgVr70ttOJaWMV0c9FvfrOWn0IC8YSDO0TinmtF5V9LRf00ahSyYdEnZNGXtE0Ud3lomI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745806269; c=relaxed/simple; bh=5nyC0HpBCpJxerFRaGt2W8pQIN+4nUL6P3ojYdbc/2o=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=BigMyipxTAcV0VD/t5vhBwElDqJdlY8KvjAhURt+VwcwuY6OjYzIJUgIykB06YVWdyrjxSleWlN8GKsoDqv3yXXmxOxDSc5S6x9dZS1zNBAkeCLG9Gf56Op8KoiXgLLOMUhRQFYTnyBIHP55koeoATjx/kp0ky/lSHTDarA1tbc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=qlqPtyWz; arc=fail smtp.client-ip=40.107.20.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="qlqPtyWz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D34jkC3sGFsFvG0i/8VIxcLic7STo0i0OKEnT+cTzdjCeX0o6sZ7UyNEljElGes/UcrX/W4DZDhtUWmltMaOy0tN6cSkcHNj7QoJVsxqbleag2btSSZrOl9VCgOx73cUKpsrU+bU7Q0hvsHZm+F/UYC1Hx8dzL4FTRJL1EnQeUNsz3XiqEab41tvOBYuDwKTShC0a3EokcksduhTJ0zZPWE/Q7U2aJxpnV7/f2sDdQ523WWK6/Lmllke8I+01Ab5iECQwEiBAzYkVZOIAvUuDOqaURx6mKpyL+H1EsFlln472660M5KA/FtQEk4taylniAgSo6ZHxi6vy8PeO2A5KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CYdjuhwvsfxVUEvKeKODcrk1U2kmXEfmBE/qUmzTBBA=; b=o/A6jkvXCC491yW9ffSnSHhd0pNkvqmGJ/4UL+/jntX5CpLtD6MrgeeuWzE4QxQymh92UrI0v8IZHd3w8qGYRjnEyM39L/gqKGr61BU7/8/6c0MWi3Q4cd3v6P8BPIjpyuNPGBtSBvTqALoCJoeOF8Kb9XjE5eIDV09JDdPAvZt8cIyUeEYVNiB8yFSD6kt8rdLj+4cMVgtv2kYvzXIgxvz6w63Sbatkt9xQgsBzeCzuk12DcmMMXVoXcu5rjv0HOwYPM63cinN7f4EiDJtQVoF6LACTX7tfDu++656uMuYDyK3+ZBJQbVVwOSCaCHKccpWOgiVIuAp06RraDDMVGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYdjuhwvsfxVUEvKeKODcrk1U2kmXEfmBE/qUmzTBBA=; b=qlqPtyWzQfqdDQX3IZ6Cjhif/6ey9JUMpYFX/bbTf89LlEscuaRFK59k0yi0VLPG3/Ke1O6tHkyFSoMnA+bx0z5xQnH90Ad2r3+lme8hZqrw0Xgshp7YraqDubdy97JM7rh1ydvqp+MmI+Rb/0FlZC8ad3a7d+gm7i15jDA/y3Koc0KyHocP8NqsdQwEn4IXvFgj2ngmpRhvMcNTI1nfHUdCnLA56dQwxIqpDPFUSsgrUsnd3pvzaN1gh1U+bCFBSjWFJ5H47fDm1sNWgibtjgqB8zXOCI2KZIKcrGGhlPSouiC0N9iixmdEnsCDgjLKWpIYA7vaGLp6f0DyrdTx6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GVXPR04MB9901.eurprd04.prod.outlook.com (2603:10a6:150:113::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.28; Mon, 28 Apr 2025 02:11:04 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8678.028; Mon, 28 Apr 2025 02:11:04 +0000 From: "Peng Fan (OSS)" Date: Mon, 28 Apr 2025 10:09:10 +0800 Subject: [PATCH v2 9/9] ASoC: codec: cs42l52: Convert to GPIO descriptors Message-Id: <20250428-csl42x-v2-9-e8056313968f@nxp.com> References: <20250428-csl42x-v2-0-e8056313968f@nxp.com> In-Reply-To: <20250428-csl42x-v2-0-e8056313968f@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745806152; l=3098; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Meie2Ur8+olGUDMVKFIdjW59K4DPyviqRjxk8qxOcTQ=; b=47scwI1bM1W65FhPQ2o45D0pAVvVQqPLfO7mqYfUXeNxDEBiqMLfKz/nVpqdhqe5VN8glNq+m PvQhi324b64DIDtb9uWZVPXL/b81d+fkWknXkqIivs6L45RB1dA4YCq X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0027.apcprd01.prod.exchangelabs.com (2603:1096:4:192::7) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GVXPR04MB9901:EE_ X-MS-Office365-Filtering-Correlation-Id: f740b855-1779-43b1-ed3d-08dd85f9eda8 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?0OpJUoJQYhzq+TRIc+DIRp0amBZL1Ko?= =?utf-8?q?YacrF1uDqE77C1GEwxwPzW6NJNw0Zv4aBfZJrRnlss7focsYQHYHKgVx5eWpZpSFm?= =?utf-8?q?dMWD2Plk2ok9n1Wf51I1ZcgQ06kvf8vVxPpduLoceAcmXKaQ6OHs4ESYyNbdqY5r8?= =?utf-8?q?sD3KN3KWivjGOtd7fpwaIQb2mwZ8/HN42anxODl6+GoZ7hQW3QpZHd21MfbEW/ImM?= =?utf-8?q?JRE/QQm5UotDsARedwybLNWICKDR7I8MBzJ5t2SbILL7cIJIJnWAs0Lx2wGao9lCe?= =?utf-8?q?0JlNNCfeAH9QGkrnjr6U8PiZTtcLwmNPQoM8v9RQRYM6LNFbmaoKBNcPhpuVY0bf0?= =?utf-8?q?5ADK57l0R3QE8EM4gySviN1Ly3wtmPGfFnk8kgpNsBGeg/vazvUEcgzGK4bgXGVJi?= =?utf-8?q?DIg74nhgqvHHCa6hzpBYkDucwP43MO9Zq1KSWGBRL2WzyX11UghXJtL/+vOikLDdr?= =?utf-8?q?CzJAKQ9RDbvfxyFNUpm7AlTQrYRELR2cq91bePZ+xI5xxbq1AYPpP6IfvMKJ6jY+h?= =?utf-8?q?ia3v32YuzXGpKVTCF3CTL9YggVE3XNm50tiOGGj+F706mtrQ1+iSEatBee4AgB1H3?= =?utf-8?q?GS3mUuVxo4S3XHa3VH7pkencGubXgPVgWoBTmM+4tcP3SAKdZ+2xzzSjqT2BuIuMF?= =?utf-8?q?f7tdPTthlXPRNAp9MuFbeHeqVO2b8oqKTy5HktLMpgcB/6iPWZmVCj3knzGQyJXoS?= =?utf-8?q?Tc+6kl5W0llkRNSm6wCbfk0egNlvdIon7NWzgjCz6qPsOL/jJhjf3pZiWOejdMKkY?= =?utf-8?q?hjpjcKNyYdMmlnoK1937lL3A6RdChUXAOVlDfuxYnV3wZ5qUR9QgwuLriyMmEdLYG?= =?utf-8?q?f03/br7yTXBavUyTFsYVTe5dsgdZIyyWBjn9Wy05YiHasBTnfL37WPZq84pXZeDc6?= =?utf-8?q?DIv++WOquzXOoLeZQaoMV62UlKEdSXAzu8XhAvFm72i8wGr9hs2OuwuIvaJyn+ssq?= =?utf-8?q?CLa/+C1Zs1rTFnPlkDKqmhpnzzteBPdGysMyWKfnUwxPSG5kDh69aq7yShGEn3H46?= =?utf-8?q?eaYykl+vV/l54UkkU9Ffbsmk3BeouX4ugw82WXXwzQDn7tCT5Qn5+19UufXkvT1/+?= =?utf-8?q?wQqlRoYc0dV53wZw5mBL1ZRqRX6HgMxxOoXBaPHrzB+DVkWSNg6GhjZ2H09NckA2G?= =?utf-8?q?7h/+K2esUYBsLp4Eg7GtBCp9xRUSEatPsircIQASP4tSxL+a/Is2ovUya8qv3pWg/?= =?utf-8?q?Wz7rg4bw/tXhbjJCkhFtMNJxcTK6OGz132qR3SThZsii0pUWPBAxjCq9ayfetBOuh?= =?utf-8?q?QGricuXGZCkdLy/GGI5pDfA6069A3NoBR7Vz4jnH/WFej3inZ9TwUl2fXRrj8BRXS?= =?utf-8?q?085OYhj1vk03DWNkx8zphtn2tl5UdFVrAIrXxyiBFSz8c4zEdh2Y6gmsJG9Mr/WZ5?= =?utf-8?q?3usT6XHntHQDGfeMlAecfhsfmExL53arQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?GP4kTri/GZLN5VoTBKXd4aHp1G81?= =?utf-8?q?yxSigbeU9vc1bMRGJ8msYmIA4iMR+uWYSf88LvvC1kh5jO2C00w6vGHpnCnT6BOTJ?= =?utf-8?q?gNRzknrgkL8PdRbOgTwHKC59HR58jqTMaJSByTU+URJBZ/cmp93BNbGl0evdl/9jV?= =?utf-8?q?KJPuFFG7ZvYAxORqBI3UqEk0pOLnYkog1XJ81P5+A49Lqw36DVS1shZ9j2TME+L9b?= =?utf-8?q?skDE2F9+CEvd5sG/SbtiU9d2ENhc9L5aItwB7/mT5fKDd/zb8uuyMgtew3m8eKZUj?= =?utf-8?q?hNiSrn/YFZfpVgkjSxkwbUXJ+2te4Wd5xGrjzT1tmDzwct7eeqXNmBMqBwdHQcASP?= =?utf-8?q?FYOnVyaqE45wzrzdV87dJDC7hS20HB3qD8Q6HIHQ986LrNAG/Z6oGDbcq7IDzRfSL?= =?utf-8?q?MaB/0it61DWHDxMY3ymaKrjfZKLfPYGeGMiZL9ygbVrdcu0W7675FkMnKer7kcWt6?= =?utf-8?q?81UiJhUbMlvEUZUW9gYSi89BQUItdwqpDdWfyZcsnoOQgysR8HrsLuBFvWTLO0UQH?= =?utf-8?q?zN6XihmdJWiRgmHPcmEt77M7192tzbAM+UHjHcar2avW+sAfcReLJZFHh932xfcZw?= =?utf-8?q?9zbZ2AR9J89anLUGgzvHiEXvaKPy/Pe/OEI2GtlYbZQpkXfUMBMz/p9R6H7HIJTPw?= =?utf-8?q?2HjbyS/csKxhHCXA7oNGMcR23/8g5JGoWZ3Xv3azCcNYNmnCHOEx/5CWJv7qPkTk6?= =?utf-8?q?3DpsKDRGbwjLuTajHjTIID6TwZUCACVsqgtHCn4jqqoK/2Rdkjv05THfDU2DP13WM?= =?utf-8?q?Z76oO3ff005IMkbYtI7We+K0mFU2RYwmMnom+hJ3zuhCkvohbGDYUKzUa6Oj1P4ZM?= =?utf-8?q?UDoxMge+5BlichciNjl+/89+mbSiU5DDGKl/vcxl5rwop2P8SuCn0AF9zLDDEHDc9?= =?utf-8?q?QiL6Dz2i0dyXHelHpBoqm8bFZLOIRGjzNLZ+NkxP0bDnrHIjRZIbUt9yOE6vm9BXc?= =?utf-8?q?sICKxOBXLobVpw55kcAaBPmj4CUSDqkLOUZu68jm++TZjQcrqmyw5yZOcLj3tGVlG?= =?utf-8?q?iwuiicH8ZvSysKF2mkwAgCtUobFy33IwiBHdZpZi+ErWZ15jyH92JzomuHWAk53Wm?= =?utf-8?q?ciHEo3G2yMonwSnG3tDGfdenl2ulbSRewdyg+0lAb8IJSJofnFExgdRfwz3oaxHJX?= =?utf-8?q?HX/tfdKccX0jNHuGvfiDzOqUPRE/R8mYfTIne+9Nq4W3kqCnxhy6kTQbHHs5IWBba?= =?utf-8?q?vRDVe47bIcwV1gl0TJThgwubacdFchBcBMSyPWduvpmh+LZ26HqLgjLUvqjf7WxrN?= =?utf-8?q?cnTmpLVkQJ0esGd/6bTP6958B32/EgwJWRaAdq37SqFrUYcX8yMLIm4+6osmU33oY?= =?utf-8?q?CDH9cUpPlYGK3Zm/fHV0o+80Ag7VRn88yCqcT1u4z47T7p0e0BOH4GiJS1zoU2DsA?= =?utf-8?q?FR2wbieAZW+pxqO1Kty6piD9dYdOBONOC2rQT+cHGPxIxTgOntd3FzJY/pz+6Lbqe?= =?utf-8?q?b6apg9wh5X7QMm6fANUlg9p3/GeXgcwpmRfoSLasBEaSo0+9NQXXlvPXCGPqfzkpo?= =?utf-8?q?O1X6nhIim3GU?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f740b855-1779-43b1-ed3d-08dd85f9eda8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 02:11:03.9471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CEqlIodu5VdfXCMZsmVvkL/F20Thi9Om/bQy5HFvYW8SV6X5n0S9JngSrvcJNmZMqcSSDDQvPiwhmHs8FXuEWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9901 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use devm_gpiod_get_optional to get GPIO descriptor with default polarity GPIOD_OUT_LOW, set consumer name. - Use gpiod_set_value_cansleep to configure output value. Checking the current driver using legacy GPIO API, the reset value is first output HIGH, then LOW, then HIGH. Checking the datasheet, the device remains in Power-down state until RESET pin is brought high. Since the driver has been here for quite long time and no complain on the reset flow, still follow original flow when using GPIOD descriptors. Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. And the binding use reset-gpio as example, not same as driver using "cirrus,reset-gpio", and there is no in-tree DTS has the device, so all should be fine with this patch. Signed-off-by: Peng Fan --- sound/soc/codecs/cs42l52.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index aa8c001cce099e3c1dfc979678fe8000caed097f..a9ffba62aaf88c55a715d83609382d6fc5cfaa8d 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -9,13 +9,13 @@ */ #include +#include #include #include #include #include #include #include -#include #include #include #include @@ -50,7 +50,7 @@ struct cs42l52_platform_data { unsigned int chgfreq; /* Reset GPIO */ - unsigned int reset_gpio; + struct gpio_desc *reset_gpio; }; struct cs42l52_private { @@ -1146,25 +1146,21 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client) "cirrus,chgfreq-divisor", &val32) >= 0) pdata->chgfreq = val32; - pdata->reset_gpio = - of_get_named_gpio(i2c_client->dev.of_node, - "cirrus,reset-gpio", 0); + pdata->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, + "cirrus,reset", + GPIOD_OUT_LOW); + + if (IS_ERR(pdata->reset_gpio)) + return PTR_ERR(pdata->reset_gpio); + + gpiod_set_consumer_name(pdata->reset_gpio, "CS42L52 /RST"); } cs42l52->pdata = *pdata; if (cs42l52->pdata.reset_gpio) { - ret = devm_gpio_request_one(&i2c_client->dev, - cs42l52->pdata.reset_gpio, - GPIOF_OUT_INIT_HIGH, - "CS42L52 /RST"); - if (ret < 0) { - dev_err(&i2c_client->dev, "Failed to request /RST %d: %d\n", - cs42l52->pdata.reset_gpio, ret); - return ret; - } - gpio_set_value_cansleep(cs42l52->pdata.reset_gpio, 0); - gpio_set_value_cansleep(cs42l52->pdata.reset_gpio, 1); + gpiod_set_value_cansleep(cs42l52->pdata.reset_gpio, 1); + gpiod_set_value_cansleep(cs42l52->pdata.reset_gpio, 0); } i2c_set_clientdata(i2c_client, cs42l52);