From patchwork Wed May 28 10:41:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893030 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2282028136E for ; Wed, 28 May 2025 10:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748428928; cv=none; b=sPb7IdQ831TZaHZKQF8+DrdAEup2M44IW1T0mXYWgcxzbRzUlAKHP8xn5W4dAmUYsznlnmeBAwrEdntL2l5Fj+6x+ijXiYjC2S485jAJ2SDIkHswRezPQbz8C/H2aRMLNSs6EcIrNTXoFKwtFsx8lOuBvmjxQ6Sm4QqFVzFrVtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748428928; c=relaxed/simple; bh=AZcW1cQpsVdpMlMJDu5jWEgQJ6HALLwy007zMLKEIYo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=im20n1kVJFedUNJTlmAzshpwRiFSZei0XGKkS7ONt8B6RAsQtTv2fqA2ijupfvq8+QFbWyr0x3me8a1e/hcGTBeLUNKPavjb8paemFk4r/HUKgqcuVYX6mv0SNvHlifZuFbQ/yODz7UYbYgSyCqMx83WMqLirYCW3XfDaZhwCTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zJOlii+P; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zJOlii+P" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a4d1e8e02dso243819f8f.1 for ; Wed, 28 May 2025 03:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748428924; x=1749033724; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mUavy7B2LDMdwrM/5bMX/h9Rv/lKrrO3+mfX8hz6Iuk=; b=zJOlii+Pg5/CBnrMuTgvIJfsofHY7X71z48vCfN08dTSxGeJWHS74QMAlWbFYdNbxh iRQbuT8S+9QkgLjImjJ/5KYfOArqubZK2jrxV0Cbo9sNYNEeIL5GttRI5Tb8VPerOZES iZ16cTDpa1a8I8PzE9JPu+gVRIcaEqEgHUo/tVjVWDO/vZeUI/u4yf3Ms6ubpaV+Bo0B 40GiBH6A7qcTryBw0icelxe2g/W+zUAjCd2BcjMXu3Ky8fGAFi5wSRbzvWhOhNcwIFDK 1ASFU9gki6K9jw2desdJzKL1Yunc93CEQXXRsZCbm5MT2yKoL8KKLvJMn8TZUvHJ6gJL ZYlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748428924; x=1749033724; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mUavy7B2LDMdwrM/5bMX/h9Rv/lKrrO3+mfX8hz6Iuk=; b=A/+J8eMXNcsm+RCIElrr7MxqiL7/C/6hxJY4EIp6m42ctHhSl+kPW4LQz/cUZvANPG JAKDIqysRLvf94qw26rPAQqy+H3Ccym6WqiLni95SkoyzcRobH6KvgCNsIOczzDpwd/u rYcbc9bSnBnJOKtnWDMykl71NBkmavc0fqEbdWJZ+Juhc04K8q6BrjDMIw4Zs1oHC4en n1w9VOc5HQWELGKnBXM0t79D9ml7VDk0koPfCZSWaDOvivn8rnEuC9KBas7cbU/ev6w/ uyXd61DgYgp7yWf8H3uWm6dVt39KpXy7DdAfGFxKIFvyiNeA77BVDCm3RYbJ46+ooZya sHZA== X-Gm-Message-State: AOJu0YyO1Zw6rfK/Q5HO8R5dP0mg5uqPHIjMFhRSGjBKTDjd1x1B4wrh 6KRNVBUWMP7gROyJOkGnebIUWCzbIUhUY5SqMPlItMkKvsk9Uba5Nf6LUuILkAdEZJ0= X-Gm-Gg: ASbGncvZfp3bD4WBRwnoh0rydlDNFEibv7R0VQsWA8O3yP4WHGW6AweIYXCsq8IxY+u aOsJeZDMr/obwIXSMU9aoGVK46djiPH7FEFYOwvFdli/oYnbhtu5tmktTMWfc4PDiguC0Hbzbku JLDCvrxq1CuvvYKou4O2wQRXffoZMOt3IQysRSiPQMQAHd1czWOna9pGsFwmcgoOVFv8xIzIuJl pdNHk2lsV6Cu+YQiq0qRdW1Tw7hd2AYOOrNBs4FZpxpHCJ3VuwReH2Mosh1Tt9l5dZTg0b/NrYl nomidiHXeza2BsBnDZiBAySyBX4VSJttLnFpzviG22kqq3mQjG2IEW/l2Xv82CGQIaodB+vcAfO E3Y3c3w== X-Google-Smtp-Source: AGHT+IHLM1FIhtqqL05DozCCpKQWY7ameEkMInI+HoHz6qQ+L3KMHdThy3m2Nh51nEncLqfROzqPGg== X-Received: by 2002:a05:6000:2481:b0:3a4:d4a0:1315 with SMTP id ffacd0b85a97d-3a4d4a01404mr4061984f8f.6.1748428924388; Wed, 28 May 2025 03:42:04 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450064add8bsm17331595e9.17.2025.05.28.03.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 03:42:03 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 12:41:06 +0200 Subject: [PATCH 10/17] pinctrl: bcm: cygnus-nsp: Move fixed assignments to 'pinctrl_desc' definition Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-pinctrl-const-desc-v1-10-76fe97899945@linaro.org> References: <20250528-pinctrl-const-desc-v1-0-76fe97899945@linaro.org> In-Reply-To: <20250528-pinctrl-const-desc-v1-0-76fe97899945@linaro.org> To: Linus Walleij , Basavaraj Natikar , Shyam Sundar S K , Andrew Jeffery , Joel Stanley , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Ray Jui , Scott Branden , Geert Uytterhoeven , David Rhodes , Richard Fitzgerald , Charles Keepax , Lorenzo Bianconi , Sean Wang , Jesper Nilsson , Lars Persson , Manivannan Sadhasivam , Damien Le Moal , Vladimir Zapolskiy , Michal Simek , Emil Renner Berthing , Jianlong Huang , Hal Feng , Matthias Brugger , AngeloGioacchino Del Regno , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@axis.com, linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2020; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=AZcW1cQpsVdpMlMJDu5jWEgQJ6HALLwy007zMLKEIYo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNuhRNPIvcbeE3O4oOSmCsEkL1h48gBgln+KJb OsiC6vomEaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDboUQAKCRDBN2bmhouD 16dvD/4+GqEjL6kp16pjaPce/8s4v6Ut3thCgUQUhMlVSN3KQ5BciDx6aymKzKDe6Y385QtYh6/ TTbLcF7wMxIsiys8zs4Joov8pnnsJFMs89/RxAHCkv0jVyWz1R82g5U3UxeAzVHOSClfzkG1ssx rukU7ZnCn8leZIhYYtv1kPDJSN5TvvmrLMqPDoeXKp/lmIMXMAfV7gA+hzg2SonnOP8zFIU/Cgk Bsnu0o5djTismPPoU+dVEC8OOtOQs51mMYYsJ3bpo6w+8AXjqnqHArInHHG+DyKfsdfpU2p8NqJ CLciuXZuNgs3KdwBmhn+8j50u4rJxhfzbl96q5Ni+ucZpmPmB8YxYQLGCUBO4LZ8SJQopvZsb/M 1D8cTgPoL8lL1WXelX1KC3g47FDzSwwJt3+NZAP2BKjEwfdLYApjYJv1SJm1HhO2ce5DwkkZVsS /ROWyFqUhckAQmPUVie/ZniAhKPP5NTi+3jDxP4DWLXZqnPD/cogYNuFscfAWmwOnNkRuuWvYaP ji598GViXmlJqT0LLbAldcUL4DyM0ovnfcXI8abCONH0ZZVFzuPQ3PrnsyUe2LKxqoq9kV1uqCt wrnlxC3wix5d5II5R2Z1TpjlzSjyFuBlPhYTuEv/7Pl/umwQK+v7ZNFofeJ7Q4gFZDAw7FZIXgE CEW4yw0hnhFONeA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Assign 'struct pinctrl_desc' .npins member in definition to make clear that number of pins is fixed and have less code in the probe. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c index eb6298507c1d1873f9d5a90ec724b36af6d4da48..9b716c0d2b9456b9e64ca1094375effefdf4817c 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c @@ -525,6 +525,7 @@ static struct pinctrl_desc nsp_pinctrl_desc = { .name = "nsp-pinmux", .pctlops = &nsp_pinctrl_ops, .pmxops = &nsp_pinmux_ops, + .npins = ARRAY_SIZE(nsp_pins), }; static int nsp_mux_log_init(struct nsp_pinctrl *pinctrl) @@ -556,7 +557,6 @@ static int nsp_pinmux_probe(struct platform_device *pdev) struct resource *res; int i, ret; struct pinctrl_pin_desc *pins; - unsigned int num_pins = ARRAY_SIZE(nsp_pins); pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL); if (!pinctrl) @@ -589,11 +589,12 @@ static int nsp_pinmux_probe(struct platform_device *pdev) return ret; } - pins = devm_kcalloc(&pdev->dev, num_pins, sizeof(*pins), GFP_KERNEL); + pins = devm_kcalloc(&pdev->dev, ARRAY_SIZE(nsp_pins), sizeof(*pins), + GFP_KERNEL); if (!pins) return -ENOMEM; - for (i = 0; i < num_pins; i++) { + for (i = 0; i < ARRAY_SIZE(nsp_pins); i++) { pins[i].number = nsp_pins[i].pin; pins[i].name = nsp_pins[i].name; pins[i].drv_data = &nsp_pins[i].gpio_select; @@ -604,7 +605,6 @@ static int nsp_pinmux_probe(struct platform_device *pdev) pinctrl->functions = nsp_pin_functions; pinctrl->num_functions = ARRAY_SIZE(nsp_pin_functions); nsp_pinctrl_desc.pins = pins; - nsp_pinctrl_desc.npins = num_pins; pinctrl->pctl = devm_pinctrl_register(&pdev->dev, &nsp_pinctrl_desc, pinctrl);