From patchwork Fri Jun 6 15:03:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 894551 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A8C289E31 for ; Fri, 6 Jun 2025 15:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749222202; cv=none; b=F7DKgQPNXSVFBfxpUJnIUDzdHmpHXIXVoy2Kt4u8cfL2NYSzmLQoknT5NBdz7XSAZTOvYnh3Ac3To6JKQWPe0LAd98rc7fPSef+tNumuf/G+8lmmGqLIJR+5DNL0kUQkatmqrbs5zz4pdkeh6bedjyh5y0G6GAnaNrN7pQpYd7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749222202; c=relaxed/simple; bh=XW6upis7ywUBB7dA4Zx7cA15c1x+GH83X1v6QRh5Bzw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VsuknJ/LPHcit9YRsfgJaRYpi9r9z/rgNrGFXaSRF30cXrOjtdlmcM2k7bY9TQk3Bev8wELp93YeMeU3h9h1FeTb0OMZqA7f9SxST8EC8gw9BAXPiWt89Ru5Ahn83LgsT4pV3McP1ffJVCZIje3ZivPhfx5qgxhb84GQcbep754= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=voew/uOS; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="voew/uOS" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ad574992fcaso355565466b.1 for ; Fri, 06 Jun 2025 08:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749222197; x=1749826997; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZrVXOODskeO9o6lbylcxPdrCt1GmYzprp7c50qP9sE0=; b=voew/uOS/S86vPm+lRnM0Xy3aMJDz9+Ttpt/ILp1QlCCT5WgQAYUw2a9fc9jaPGmBS 6qY9C/hjTZY8GAWCXOYrSFL5cLNpFDJRTZzmkvAyMTKRPP8XAuvVzl/j1nzvfbQBeDfh Wa7p98fMk/ddvrnvrUXfDOi03pGFEIi1BtlTffYqfba1Pxl87Ez2se+5SEDGrIQVNr6A 6z51QIc2SLv6qnEzx+z4yfJ4EN1AFVvmlBKMMSCXdqG4OosdmwsqbfCK/HmdDWDc5OSD EKPMZHaeONeY4jj0DeyawjqaCKQTTFIz2ozRJ/P703Fr9jZnzukJ0u5JvUlOCYkgsAAa Af3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749222197; x=1749826997; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZrVXOODskeO9o6lbylcxPdrCt1GmYzprp7c50qP9sE0=; b=ZNcpazdfblOXpH1ckW+U1FM/vH8ByNsiHyUskvf1XlOiDjblPayf/J2dGD/d44ZMZS sK/FCgkM3pURetldjvheFgmDlKIdJYhdP6A1FXhom4VFv3F1p46OewY8DQCKZjwcpK4D uAr6xu3PivsinuEJ+VhHcRt0zonm4JN+jwchjqvqHnUhphYcO07GQdgiMT60DIK5jZy/ wywRqI2C8y4yh2qGIBdzA1b5hNZZYaOl90UpBag1eT+xCNNWLfGLeBjY8izPMj6WgmnL GqXzpnjQKXdxJ02SsdWmtLnVVAbyToq5nZmSimbqmHF5e2Q6JO8FrvNphBlc4QCcDzpl L61g== X-Forwarded-Encrypted: i=1; AJvYcCVK1cnbBYJOH3LA8IrdFKKXE367NpWOp6S0LMXQy0BC8lcGCgX6Q3488LuvaQ3Xcw0U0xlDnDb5fW1W@vger.kernel.org X-Gm-Message-State: AOJu0Ywhoq9OGgvhOIksP7Z1gZLIMjKXwqF8eXa/uNrLZUs54JvKOKQ+ 0z+1WEHJli1y8qLV/nfrOkjgW89szuSwrKm2a6cTbc/koMJcxX/Q9H9pH9k33CLEZDo= X-Gm-Gg: ASbGncseLGi0IwA5vlGnp1tlppp0UaJAICT7PXtukmEpW2V1ykP3ZwSIEBwln//IGoz nTS0n8Uj5L1gc49jFD1UV3rVYnTnNQDkHapnnMbIEdTqrdq3umv0wCmpWPFoY54+DU/kKuBZ3Jf L/O2SFGRWa7QA0I0UlOjf46ib1HhhJQk16y/rwjBbX2PnwUjSmZpOZY+0OMyORjHJYcFkCFwYyi ClRwMSjMAG+iddSE3aW7cavDp81eH4NM2RGugqyMJdKiDW//wVauhNopbghyKMPLcKo6LEDHAqn 8yIL/7ur0tYeut72nBcazMCKYFUkHemapjH3Ywhs5H139pA2049xTREAi7yccng7oxTZS1O7+60 /QV0v/yZLZ67frITG7qazcbXimvEes5iElNeCb0UFNVBcmw== X-Google-Smtp-Source: AGHT+IFPnRXvPeosibDEAxvwHPrDNR/Agw7oG0bKI7jl5+GdDejJiSgSnw2j3hTsx9Z3U15SN2WC4g== X-Received: by 2002:a17:906:ee87:b0:adb:23e0:9290 with SMTP id a640c23a62f3a-ade1a916fe3mr332115566b.4.1749222197197; Fri, 06 Jun 2025 08:03:17 -0700 (PDT) Received: from puffmais.c.googlers.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade1dc38cf2sm127735066b.121.2025.06.06.08.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 08:03:16 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 06 Jun 2025 16:03:06 +0100 Subject: [PATCH v2 10/17] regulator: s2mps11: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-s2mpg1x-regulators-v2-10-b03feffd2621@linaro.org> References: <20250606-s2mpg1x-regulators-v2-0-b03feffd2621@linaro.org> In-Reply-To: <20250606-s2mpg1x-regulators-v2-0-b03feffd2621@linaro.org> To: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, =?utf-8?q?Andr?= =?utf-8?q?=C3=A9_Draszik?= X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. While at it, harmonise some error messages to add regulator name and ID like in other messages in this driver, and update messages to be more similar to other child-drivers of this PMIC (e.g. RTC). Signed-off-by: AndrĂ© Draszik --- drivers/regulator/s2mps11.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 1f51fbc6c7b6e158f9707c04d9f030b9eee5e842..30586e9884bfb998ff07e3148813344b307506c0 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -1249,9 +1249,9 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) BUILD_BUG_ON(S2MPS_REGULATOR_MAX < ARRAY_SIZE(s2mpu05_regulators)); break; default: - dev_err(&pdev->dev, "Invalid device type: %u\n", - s2mps11->dev_type); - return -EINVAL; + return dev_err_probe(&pdev->dev, -ENODEV, + "Unsupported device type %d\n", + s2mps11->dev_type); } s2mps11->ext_control_gpiod = devm_kcalloc(&pdev->dev, rdev_num, @@ -1290,21 +1290,20 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) devm_gpiod_unhinge(&pdev->dev, config.ena_gpiod); regulator = devm_regulator_register(&pdev->dev, ®ulators[i], &config); - if (IS_ERR(regulator)) { - dev_err(&pdev->dev, "regulator init failed for %d\n", - i); - return PTR_ERR(regulator); - } + if (IS_ERR(regulator)) + return dev_err_probe(&pdev->dev, PTR_ERR(regulator), + "regulator init failed for %d/%s\n", + regulators[i].id, + regulators[i].name); if (config.ena_gpiod) { ret = s2mps14_pmic_enable_ext_control(s2mps11, - regulator); - if (ret < 0) { - dev_err(&pdev->dev, - "failed to enable GPIO control over %s: %d\n", - regulator->desc->name, ret); - return ret; - } + regulator); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "failed to enable GPIO control over %d/%s\n", + regulator->desc->id, + regulator->desc->name); } }