| Message ID | 20250606-s2mpg1x-regulators-v2-6-b03feffd2621@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Samsung S2MPG10 regulator and S2MPG11 PMIC drivers | expand |
Copying my comment below from v1 of this series to make sure it doesn't get lost. On Fri, 2025-06-06 at 16:03 +0100, André Draszik wrote: > In a typical system using the Samsung S2MPG10 PMIC, an S2MPG11 is used > as a sub-PMIC. > > The interface for both is the ACPM firmware protocol, so update the > example here to describe the connection for both. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > .../bindings/firmware/google,gs101-acpm-ipc.yaml | 40 ++++++++++++++++++++-- > 1 file changed, 37 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > index 62a3a7dac5bd250a7f216c72f3315cd9632d93e1..408cf84e426b80b6c06e69fda87d0f8bfc61498d 100644 > --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > @@ -36,6 +36,15 @@ properties: > compatible: > const: samsung,s2mpg10-pmic > > + pmic2: > + description: Child node describing the sub PMIC. > + type: object > + additionalProperties: true > + > + properties: > + compatible: > + const: samsung,s2mpg11-pmic > + Since we have two PMICs here, but can not use the 'reg' property (as the addressing is based on software, i.e. the ACPM firmware), I've opted for 'pmic' (existing) and 'pmic2' (new) as nodenames. Maybe 'pmic-main' and 'pmic-sub' would be more appropriate, but 'pmic' is a bit more standard I believe. I'm open for better suggestions :-) Cheers, Andre'
diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml index 62a3a7dac5bd250a7f216c72f3315cd9632d93e1..408cf84e426b80b6c06e69fda87d0f8bfc61498d 100644 --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml @@ -36,6 +36,15 @@ properties: compatible: const: samsung,s2mpg10-pmic + pmic2: + description: Child node describing the sub PMIC. + type: object + additionalProperties: true + + properties: + compatible: + const: samsung,s2mpg11-pmic + shmem: description: List of phandle pointing to the shared memory (SHM) area. The memory @@ -52,7 +61,9 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/regulator/samsung,s2mpg10-regulator.h> power-management { compatible = "google,gs101-acpm-ipc"; @@ -63,12 +74,20 @@ examples: compatible = "samsung,s2mpg10-pmic"; interrupts-extended = <&gpa0 6 IRQ_TYPE_LEVEL_LOW>; + vinl3m-supply = <&buck8m>; + regulators { ldo1m { regulator-name = "vdd_ldo1"; regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; - regulator-always-on; + }; + + ldo20m { + regulator-name = "vdd_ldo1"; + regulator-min-microvolt = <700000>; + regulator-max-microvolt = <1300000>; + samsung,ext-control = <S2MPG10_PCTRLSEL_LDO20M_EN>; }; // ... @@ -77,8 +96,23 @@ examples: regulator-name = "vdd_mif"; regulator-min-microvolt = <450000>; regulator-max-microvolt = <1300000>; - regulator-always-on; - regulator-boot-on; + regulator-ramp-delay = <6250>; + }; + }; + }; + + pmic2 { + compatible = "samsung,s2mpg11-pmic"; + interrupts-extended = <&gpa0 7 IRQ_TYPE_LEVEL_LOW>; + + vinl1s-supply = <&buck8m>; + vinl2s-supply = <&buck6s>; + + regulators { + buckd { + regulator-ramp-delay = <6250>; + samsung,ext-control = <S2MPG11_PCTRLSEL_UFS_EN>; + samsung,ext-control-gpios = <&gpp0 1 GPIO_ACTIVE_HIGH>; }; }; };
In a typical system using the Samsung S2MPG10 PMIC, an S2MPG11 is used as a sub-PMIC. The interface for both is the ACPM firmware protocol, so update the example here to describe the connection for both. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- .../bindings/firmware/google,gs101-acpm-ipc.yaml | 40 ++++++++++++++++++++-- 1 file changed, 37 insertions(+), 3 deletions(-)