From patchwork Wed Jun 11 06:13:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 896366 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE51D23237C for ; Wed, 11 Jun 2025 06:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749622482; cv=none; b=naj5sysNp4zVdX6OQGrwOaCGwhHgEF2TsfrMQmsdY/257O5tHjGQNJakmJJ/2IYjtPUi2aN9CaOgvsMoZbQcMy8fE/aPFSqXp94x7gcyiYZdUEM7P7QVVy+b8SC9Cz3opBlVIzBIb4qLVo0122yCgy44J6xxy6CuBghy00ZrMd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749622482; c=relaxed/simple; bh=qxDFEG/2cjWrKLnKXwD75upSffPn/RaY6zrSF/H6Qbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=okxcUoP9q2GPE5XbwOXUWtSJIakUHu2ct7+gD8Vx6yzOvnYCiJQWxHv3KIWzPWFsl/TpmmpPNxzpz44HZLxCOd+52aILPUhIZTN/sXvbI4rTlD236qiaH78ZVCcmvSAH14bQ+MF8pJC/LS642Vnuab34Xe2BczG6gV14txpdM2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N77/zh3K; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N77/zh3K" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a4e6a0c274so24829f8f.2 for ; Tue, 10 Jun 2025 23:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749622479; x=1750227279; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TE7gPFs8Np7Q/FF2lBSclyxd8XnUpnZDt9gHZQ7ecXc=; b=N77/zh3KZKjqkdOCtI2LLJn7KXQSXHFKEZH9XnFuBdhkYQDJFVjYtNVYywnXgwG5Kf 5VYCzPVoiwGDiUQUCQ5amXRx5f2US+dnXvyFGn4YjQAI9Jr+vtmLglZpLFzREuViJBPW kZruuYC/kQQ1HEz8ptw/8uryY/MwW2qk9EAhE+pCxI3UCPaCSLoRWXpUf7dtcGbZGAbk ew0govl9MoFExRCHhVKIZYrXx4hRz7lO5CUc2QGmp1ZO6O9Ia1tlSSEFImsCJH5RCgSs SYQz68v/6oyq+bw6yHLiExmQSIDmbEEaFcBZc11U+mH8qB4PhHAu9KRZhAXeGprwMfEw sxgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749622479; x=1750227279; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TE7gPFs8Np7Q/FF2lBSclyxd8XnUpnZDt9gHZQ7ecXc=; b=pX0c3fzMO15ZyfTUZkoqu2VyVB7DqccHhJHWR/4WGfwibNy58r1efNzlFcABFlLEGR 4u0eG8xlXykgswPMIFq0CzlQd4z95z4ovpu3OKjk5rjcnjV2XULlNx8a6dX8QJLgQoQ4 Pwt7fU28rCsl8tUbo97HSJYRmpnIeMAKADd91dRdedtnR1kuUjVnzL0zbw9uJBr8xN5d SeB3z0b7s3i7pCvbc7MCBkRyea8xkHWvHXgL7KwIYG6kFikR8uVPQIQlyUw3EAKDXg8o YsOZNI5v1uBictmUmkXbsDQ4MuO6AUPoOm/Z5F5OAolGfe2OAQKl5ECUesT/Bkw+0Rqh QahA== X-Gm-Message-State: AOJu0Yy3SPe6+1OYrf6qZMH6cMichCmrkw09Pps1yJuOgducXwYuTdlz y/n7pYCgFp3FX61prXUKMQjgfhZlcHfQv004axwey2jxAC62E3I174liFH4RWy+vQ+l7FRu6SbF f6VUV X-Gm-Gg: ASbGncuEYfDJGQqq+dXKOh+JmRGYS7as504RLNU59zWMP+u//XfdwppkqZ+GqDxTFhl bZz1VbjDMyb75XUYgivS6XpN0ouoKbnQnE6K+arXu05NioqgY/CZB8sHwPtL8gjX9Bv+5smP308 gVnabQQ1P4ydSaPih0TjsWt3ebYYf+TUwfF5maOKHS3PpRcOIETBq2NmuCc9Xtnv4FyvXSuVnCh MO2LLxDc9s83zYCDpaH3gE2j4Y1y/GrIbAwa/+08/FTdNi41rECf4oiq4/LZRThtpPYVnm70FOj m1jROUvPuvNpJSYT8X5yeuVR/VTLRdqfc2lXxiGG6k2F9JSPtU7jpqltoMBUDS7w1BP4GvX6YSm /ddzh8tc= X-Google-Smtp-Source: AGHT+IFn+w9wTXPGUJy/sPilC/NQmEX8xSLBnguhN63zZeVVN5Y9q/yoed/8bnPWbjxQrrKvoL0/ug== X-Received: by 2002:a05:6000:290f:b0:3a4:dbdf:7152 with SMTP id ffacd0b85a97d-3a558827131mr509857f8f.14.1749622478587; Tue, 10 Jun 2025 23:14:38 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244f516sm14142791f8f.74.2025.06.10.23.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 23:14:37 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 11 Jun 2025 08:13:40 +0200 Subject: [PATCH v2 08/17] pinctrl: bcm: cygnus-mux: Move fixed assignments to 'pinctrl_desc' definition Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250611-pinctrl-const-desc-v2-8-b11c1d650384@linaro.org> References: <20250611-pinctrl-const-desc-v2-0-b11c1d650384@linaro.org> In-Reply-To: <20250611-pinctrl-const-desc-v2-0-b11c1d650384@linaro.org> To: Linus Walleij , Basavaraj Natikar , Shyam Sundar S K , Andrew Jeffery , Joel Stanley , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Ray Jui , Scott Branden , Geert Uytterhoeven , David Rhodes , Richard Fitzgerald , Charles Keepax , Lorenzo Bianconi , Sean Wang , Jesper Nilsson , Lars Persson , Damien Le Moal , Vladimir Zapolskiy , Michal Simek , Emil Renner Berthing , Jianlong Huang , Hal Feng , Matthias Brugger , AngeloGioacchino Del Regno , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Manivannan Sadhasivam Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@axis.com, linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Florian Fainelli , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2161; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=qxDFEG/2cjWrKLnKXwD75upSffPn/RaY6zrSF/H6Qbo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoSR6lg4NYzThC3P0VBNILmPNpLI7cOGxxduFw2 79gOSp38i6JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaEkepQAKCRDBN2bmhouD 154dEACOMm3Rp/o7Yal3hsY5lrUILoLJv/3YbR1poy/Hntcal7lfWiRxrgpOmbhNAJ4gxXsCS2v pQvdOFDdKXryzGo5sBlbzlSZ+llGXe7xIMFD3ccyG7miWv3FoqR39Ss09HtlDLb/iY7lCYUklFO X4CE6AJdiC+cVyMjst1ORlZHYvtSmj84z8M8Xw7fjQpmfx3jwpMn8Xk98GAvBj32k1bffAnVrdc 0dQ73IYkIqj1S30dFyPVw8jVo1NWaH7C4LOHljvBFAS2RWUlzu6GViA0z3aLYJlleswzhWiXdqQ 2uggpYru6C02B3JBYWRsXiE9lcHMWwJdL8C3KWshReL5zYhV8hRSeuIcHkZjviIb6d7qLHswZoq BBsTpZzFdVstw34OgcD5V/WAGmnWxNMppVq42YTfT61ZSZo/M23EkrRVSOAtgXoy2FMcc5QNhv0 xSBOHIUMCmzDYd3Jdou3acpCxF89InjFKRURreHYhf6ZDMV6r+Jwq9UljYzaJZ4HR0QsZZRunEj bIE5rRF/VBlRukZG9fnFQwey+KBFAhAYMQij7w+xJpoqhxqpyvWoVmvYHH29AzUzEaag4F/cxdw HHEQfjUS0EaLxw4ayenSuMFm9PmgmKlxXXS++io2JONMtPpSTwwKvP3qPWz7NuuR8O+m9h0hb1i HbUKb6deG5dGoyA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Assign 'struct pinctrl_desc' .npins member in definition to make clear that number of pins is fixed and have less code in the probe. Reviewed-by: Florian Fainelli Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/bcm/pinctrl-cygnus-mux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c b/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c index bf9597800954affd954e45a4baa01da4d5dbf420..e9aa99f85e05944a2a0cb9a3e6245c707dbc9b3a 100644 --- a/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c @@ -903,6 +903,7 @@ static struct pinctrl_desc cygnus_pinctrl_desc = { .name = "cygnus-pinmux", .pctlops = &cygnus_pinctrl_ops, .pmxops = &cygnus_pinmux_ops, + .npins = ARRAY_SIZE(cygnus_pins), }; static int cygnus_mux_log_init(struct cygnus_pinctrl *pinctrl) @@ -935,7 +936,6 @@ static int cygnus_pinmux_probe(struct platform_device *pdev) struct cygnus_pinctrl *pinctrl; int i, ret; struct pinctrl_pin_desc *pins; - unsigned num_pins = ARRAY_SIZE(cygnus_pins); pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL); if (!pinctrl) @@ -963,11 +963,12 @@ static int cygnus_pinmux_probe(struct platform_device *pdev) return ret; } - pins = devm_kcalloc(&pdev->dev, num_pins, sizeof(*pins), GFP_KERNEL); + pins = devm_kcalloc(&pdev->dev, ARRAY_SIZE(cygnus_pins), sizeof(*pins), + GFP_KERNEL); if (!pins) return -ENOMEM; - for (i = 0; i < num_pins; i++) { + for (i = 0; i < ARRAY_SIZE(cygnus_pins); i++) { pins[i].number = cygnus_pins[i].pin; pins[i].name = cygnus_pins[i].name; pins[i].drv_data = &cygnus_pins[i].gpio_mux; @@ -978,7 +979,6 @@ static int cygnus_pinmux_probe(struct platform_device *pdev) pinctrl->functions = cygnus_pin_functions; pinctrl->num_functions = ARRAY_SIZE(cygnus_pin_functions); cygnus_pinctrl_desc.pins = pins; - cygnus_pinctrl_desc.npins = num_pins; pinctrl->pctl = devm_pinctrl_register(&pdev->dev, &cygnus_pinctrl_desc, pinctrl);