@@ -10,6 +10,7 @@
* TS-4600 SoM.
*/
+#include <linux/bitmap.h>
#include <linux/bitops.h>
#include <linux/gpio/consumer.h>
#include <linux/kernel.h>
@@ -105,9 +106,7 @@ static void ts_nbus_set_direction(struct ts_nbus *ts_nbus, int direction)
*/
static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus)
{
- DECLARE_BITMAP(values, 8);
-
- values[0] = 0;
+ DECLARE_BITMAP(values, 8) = { };
gpiod_multi_set_value_cansleep(ts_nbus->data, values);
gpiod_set_value_cansleep(ts_nbus->csn, 0);
@@ -149,9 +148,9 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val)
*/
static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte)
{
- DECLARE_BITMAP(values, 8);
+ DECLARE_BITMAP(values, 8) = { };
- values[0] = byte;
+ bitmap_set_value8(values, byte, 8);
gpiod_multi_set_value_cansleep(ts_nbus->data, values);
}
Use bitmap_set_value8() instead of accessing the bitmap directly. Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it. The bitmap has to be zero-initialized now to avoid a compiler warning since bitmap_set_value8() does read/modify/write rather than just the write that this is replacing. In ts_nbus_reset_bus(), this zero- initialization is enough and we don't need to replace the array access with bitmap_clear(). Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: David Lechner <dlechner@baylibre.com> --- v5 changes: - Fix undeclared variable in ts_nbus_reset_bus() v4 changes: - Fix typo s/get/set/ in commit message - Zero-initialize the bitmap to avoid compiler warning --- drivers/bus/ts-nbus.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)