From patchwork Mon Jun 16 07:18:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 897100 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFD81C1741 for ; Mon, 16 Jun 2025 07:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058345; cv=none; b=GeSO8s+xP//RV5gqeMIysSyHIT+tn229XWoFII6HP6XgDFuCUT8RVzwK8G6ovkp+TiTYHV5UUKs7pSaFsD2+Ji4GWyzhuggnFrYCR6qcUMD+cqV6ZJfSiCoHhxIIteX2+YuwqbbN4EG13t+85sxpLJwcL+4pkhVLKxnSJb2Cd/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058345; c=relaxed/simple; bh=i4HUX8ifaxrfpP6Wtp01EbUr03JCgVc5lw8n3/X/fHI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HW5ZeLLB83A06qKDada1ofhSUiok2wc7jS5l9H6SMgEqFsrKEvxI5XMqumzKvXomG/2fno7+wVWkDUQyZfNzTPZ3EyNHDjP73x2c/4W8rwiiCQ/lESttoeP70MbazrTLjt6x3AFZa7LTW1ulkbnIsLeXpIlpEqN3ugYmKGMLTxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lI6DAoFS; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lI6DAoFS" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a5257748e1so2923537f8f.2 for ; Mon, 16 Jun 2025 00:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058342; x=1750663142; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xq7xfBYrivDdeg+8ZFQsb9LtSkPdVzHMYNYxsllkpTQ=; b=lI6DAoFSCwEkV3XVYgkKECKIGHWbqLkSptW4rW7WSgY5qRikCyrL32UYn7ZKafAaD8 ZsjntKOX8U6+I7cw3B0Vivav29Qsrv0yIOkv2/jK2vj/c5Y2u7K2IbxibWmUcJlDnExt 3vfn9XA96g0QxZ3iXqeetoXISzcsRl1ugwiq26d7CZd43Nz4jK8xP4hvyyOqh0R2qZEV HOa7r7VlEzdAcLmn2cELHU3DU/ztCEg5GNhhiifoqfKpYEqR4XsvFYr3pazcQq3O4uCZ hVAJ2/T9GP3/ElPptWUFKp4g7IUk+5jDkCRRFFJH46q+YRbdY9AJse7Eyk+YhjeWKMie zP+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058342; x=1750663142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xq7xfBYrivDdeg+8ZFQsb9LtSkPdVzHMYNYxsllkpTQ=; b=JzRMQrKtIOpUJCtNGkfsYgjwC0uupDozXKqUUADgnhYjBKNujOtKPcG+Kc3iv/C6d9 RSwfDMSv/lBr4KhQ0J6AAFVUDVq9tG7FyqDJQfjSTz2QHNxAk0860bIHkMFyhqYyBqsB Y3Xriw90ab+cwFORTap8SRnjiuWtLgjsa5KoezEGYMhU8Bc3iJWK28kiA/NXu4RcBcBU LaE0jQOmqm4oF1kp5vJM9kyOw70p/MW+ctYeL+DoS9RP2DBDolLbb4qvXlT7sZCXeKvd xGvF1kzhTRc5/ljRqsRxinE3WDdWbvN4jIU9Qwtb85PBnMDjUYkShAXJu4wb2qtE4NpA Tybg== X-Forwarded-Encrypted: i=1; AJvYcCUHU4cukHecwB7oQhuc04D5RaFjkCkLZweC+cobEdZn0ys6RUAhvphF6y+wMov/aznX8gB6TaLA9E8t@vger.kernel.org X-Gm-Message-State: AOJu0YyIwpZbJO2oX81Jn+COD+DRbccxF3Zx9ys9nNffnRPcgbOz5Ldj dysDG4QDjCpTOI0VBxTunuSxfl69Rr61+BRbxhCqM8jTLNhjGwVuu6Tqvz+HD26GglQ= X-Gm-Gg: ASbGncuV7KmTmjrlG1kBgFNt3ttS0tqOjbgbJV2s2XZXTcyk00Ajm6HxUuIFZygM1HE LqDRBoMw0Brh4Rulab/Phzzwj5AZRZe5LDymCg8ndY6ZxJ32Y4xfkxlAxKnMfm5vCu63QXUZiN9 uVwmyvpk2xvs1tzANkqVH431d+QN8RGWx4tN8m3a+vqacuak2aYhfSaIzsutr4xNa6yp1gfqHW+ NL+UNrP+36HBq3GpyIcOdECCCimDBotaNSld61A67aNRm1p5L5EH2dWj29TeEVPmu10Q/sHGrVb AtfXSg2pPkQ3p3HR2yDSylTkRz73X6HhjLQ9RLMlnRLgEB0I6s1CtMdg X-Google-Smtp-Source: AGHT+IGqRQFtwLQB2XoRi5EOneCYIsZXe+77XlPZZC7TAn7DBrw2xMQ1XvuYegfIi9R1ySJiXAmKpg== X-Received: by 2002:a05:6000:290c:b0:3a4:f35b:d016 with SMTP id ffacd0b85a97d-3a572367993mr5930123f8f.11.1750058341928; Mon, 16 Jun 2025 00:19:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:01 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:52 +0200 Subject: [PATCH v2 3/7] media: solo6x10: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250616-gpiochip-set-rv-media-v2-3-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1584; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=x0xLHApMRQLh5h/Yrn6OODER6U8QbupzF1WTnrs22BE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VgnkyfY9zXwUwAbF3pDGBMJaaSofXadbbUu oURaRqaoYiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX cgNZEACfPdzwFh2olDjXYlCjJ4Sr3vGyHbfYbeSG5KnAngNEJzuwjX/R3eFGn2wmsj3A9G7fpTc k098NBx1cBk+qV95tArmvsGnNTVbZYI06Ug6fsC0u5JdDzMTCV9qMhkRnEHQ6HF/Njn4Tbyf7oc lYBbQh1zRPHrp7zwafBO/eYQsiNymFErIsYGlbZYgqFBOVqkroc8SrWR4EP97q1XDLZ82+28iMQ YTcM+AGVcqTDwaAItFQP4Li+A/2o80vhh5xGX9P9lG/iK+cIL9VvtLbSNkZ9b8+5jp3jhw4T+18 MULYURcxjfSAwZDgcyLeJKzG1b9BL98+6YtxkKMZjPLfwQMX9phMRMPANX6LF3VDP7M5GSWAnMv Trk568ROBMSljKU7XjzFrivOYLtn+oM5HqSc9jf8uHfbe5KTLl8odnVgQ6qniJlttsoTxk0f3Tq uS9jRORJBa4YyVhT5sopoTsrAxPlZafLCHtv9zD/O6GjIHk5AK9uq6ZRHKR8/qiJf9eYXdzHyp2 949IQEE71+rInMxcYWjjiZjDl2PnQ/v+KWOSms6Be890tRXeyV5bL9MFgqPYN6VsDkllD5LUouX lEhaWJ8HIuEeaUzC4REk124DK/wNRtA9YPmkExi5ohmfvqKV3i5gAifkzF1dTOb1M1ChpDVrBC1 U1VIpWct/4X0IKA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c index f51f865c69bd7b04fac7a1f951c734965d8fc993..b16a8453a62afd5a420b03bfb1967d18e1cb1167 100644 --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c @@ -127,8 +127,8 @@ static int solo_gpiochip_get(struct gpio_chip *chip, return 1 & (ret >> (offset + 8)); } -static void solo_gpiochip_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int solo_gpiochip_set(struct gpio_chip *chip, + unsigned int offset, int value) { struct solo_dev *solo_dev = gpiochip_get_data(chip); @@ -136,6 +136,8 @@ static void solo_gpiochip_set(struct gpio_chip *chip, solo_gpio_set(solo_dev, 1 << (offset + 8)); else solo_gpio_clear(solo_dev, 1 << (offset + 8)); + + return 0; } #endif @@ -156,7 +158,7 @@ int solo_gpio_init(struct solo_dev *solo_dev) solo_dev->gpio_dev.get_direction = solo_gpiochip_get_direction; solo_dev->gpio_dev.get = solo_gpiochip_get; - solo_dev->gpio_dev.set = solo_gpiochip_set; + solo_dev->gpio_dev.set_rv = solo_gpiochip_set; ret = gpiochip_add_data(&solo_dev->gpio_dev, solo_dev);