mbox series

[v3,0/9] i2c: stm32f7: enhancements and support for stm32mp25

Message ID 20231215170617.95868-1-alain.volmat@foss.st.com
Headers show
Series i2c: stm32f7: enhancements and support for stm32mp25 | expand

Message

Alain Volmat Dec. 15, 2023, 5:06 p.m. UTC
This series first perform enhancements in the way interrupt are handled
and cleanup in messages.
Then it adds support for the stm32mp25 which differs in that
it only has a single irq line for both event/error and has a
different handling of the FastModePlus.
Support is then enabled within the stm32mp25 related device-trees.

Changelog:
v3: - addition of 2 commits dealing with readl_relaxed(I2C_ISR) in
      isr handler and a second one to use dev_err_probe during probe
    - correction of SOB in commit

v2: - correct st,stm32-i2c.yaml.  Use if then else scheme to indicate
      number of interrupts / interrupt-names depending on the
      compatible while keeping the description within the common part

    - correct 2 maybe-uninitialized warnings
          * ret in stm32f7_i2c_write_fm_plus_bits
          * irq_error in stm32f7_i2c_probe, move the platform_get_irq
            within the same if block as devm_request_threaded_irq

Alain Volmat (9):
  i2c: stm32f7: use dev_err_probe upon calls of devm_request_irq
  i2c: stm32f7: perform most of irq job in threaded handler
  i2c: stm32f7: simplify status messages in case of errors
  dt-bindings: i2c: document st,stm32mp25-i2c compatible
  i2c: stm32f7: perform I2C_ISR read once at beginning of event isr
  i2c: stm32f7: add support for stm32mp25 soc
  arm64: dts: st: add all 8 i2c nodes on stm32mp251
  arm64: dts: st: add i2c2/i2c8 pins for stm32mp25
  arm64: dts: st: add i2c2 / i2c8 properties on stm32mp257f-ev1

 .../devicetree/bindings/i2c/st,stm32-i2c.yaml |  28 ++
 arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi |  36 ++
 arch/arm64/boot/dts/st/stm32mp251.dtsi        |  96 +++++
 arch/arm64/boot/dts/st/stm32mp257f-ev1.dts    |  20 +
 drivers/i2c/busses/i2c-stm32f7.c              | 342 +++++++++---------
 5 files changed, 358 insertions(+), 164 deletions(-)

Comments

Alexandre TORGUE April 25, 2024, 8 a.m. UTC | #1
Hi Alain

On 12/15/23 18:06, Alain Volmat wrote:
> This series first perform enhancements in the way interrupt are handled
> and cleanup in messages.
> Then it adds support for the stm32mp25 which differs in that
> it only has a single irq line for both event/error and has a
> different handling of the FastModePlus.
> Support is then enabled within the stm32mp25 related device-trees.
> 
> Changelog:
> v3: - addition of 2 commits dealing with readl_relaxed(I2C_ISR) in
>        isr handler and a second one to use dev_err_probe during probe
>      - correction of SOB in commit
> 
> v2: - correct st,stm32-i2c.yaml.  Use if then else scheme to indicate
>        number of interrupts / interrupt-names depending on the
>        compatible while keeping the description within the common part
> 
>      - correct 2 maybe-uninitialized warnings
>            * ret in stm32f7_i2c_write_fm_plus_bits
>            * irq_error in stm32f7_i2c_probe, move the platform_get_irq
>              within the same if block as devm_request_threaded_irq
> 
> Alain Volmat (9):
>    i2c: stm32f7: use dev_err_probe upon calls of devm_request_irq
>    i2c: stm32f7: perform most of irq job in threaded handler
>    i2c: stm32f7: simplify status messages in case of errors
>    dt-bindings: i2c: document st,stm32mp25-i2c compatible
>    i2c: stm32f7: perform I2C_ISR read once at beginning of event isr
>    i2c: stm32f7: add support for stm32mp25 soc
>    arm64: dts: st: add all 8 i2c nodes on stm32mp251
>    arm64: dts: st: add i2c2/i2c8 pins for stm32mp25
>    arm64: dts: st: add i2c2 / i2c8 properties on stm32mp257f-ev1
> 
>   .../devicetree/bindings/i2c/st,stm32-i2c.yaml |  28 ++
>   arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi |  36 ++
>   arch/arm64/boot/dts/st/stm32mp251.dtsi        |  96 +++++
>   arch/arm64/boot/dts/st/stm32mp257f-ev1.dts    |  20 +
>   drivers/i2c/busses/i2c-stm32f7.c              | 342 +++++++++---------
>   5 files changed, 358 insertions(+), 164 deletions(-)
> 

DT patches applied on stm32-next. Not that I added acces-controller 
bindings for all I2C nodes.

Thanks!
Alex