| Message ID | 20240920101820.44850-1-kfting@nuvoton.com |
|---|---|
| Headers | show |
| Series | i2c: npcm: read/write operation, checkpatch | expand |
On Fri, Sep 20, 2024 at 06:18:15PM +0800, warp5tw@gmail.com wrote: > From: Tyrone Ting <kfting@nuvoton.com> > > From: Tyrone Ting <kfting@nuvoton.com> Something wrong with your email setup. This patch may not be applied in this form. But before (re-)sending, wait for others to comment (up to 1 week).
Hi Andy: Thank you for your feedback. Andy Shevchenko <andriy.shevchenko@linux.intel.com> 於 2024年9月20日 週五 下午10:30寫道： > > On Fri, Sep 20, 2024 at 06:18:15PM +0800, warp5tw@gmail.com wrote: > > From: Tyrone Ting <kfting@nuvoton.com> > > > > From: Tyrone Ting <kfting@nuvoton.com> > > Something wrong with your email setup. This patch may not be applied in this form. > > But before (re-)sending, wait for others to comment (up to 1 week). > I'll remove the "--from" parameter to git send-email command in next patch set. > -- > With Best Regards, > Andy Shevchenko > > Thank you. Regards, Tyrone
From: Tyrone Ting <kfting@nuvoton.com> This patchset includes the following fixes: - Enable the target functionality in the interrupt handling routine when the i2c transfer is about to finish. - Correct the read/write operation procedure. - Introduce a software flag to handle the bus error (BER) condition which is not caused by the i2c transfer. - Modify timeout calculation. - Assign the client address earlier logically. - Use an i2c frequency table for the frequency parameters assignment. - Coding style fix. The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards. Addressed comments from: - Andy Shevchenko : https://lore.kernel.org/linux-i2c/ZuQUfCK7d7DuR9eH @smile.fi.intel.com/ - Andy Shevchenko : https://lore.kernel.org/linux-i2c/ZuQU2iIZwW4mAumo @smile.fi.intel.com/ - Andy Shevchenko : https://lore.kernel.org/linux-i2c/ZuQWYabomv_xyYyj @smile.fi.intel.com/ Changes since version 3: - Remove "Bug fixes" in the cover letter title. - Modify the term "function" to "func()" in the commit message and code comments. - Correct the coding style. Changes since version 2: - Add more explanations in the commit message and code modification. - Use lower character names for declarations. - Remove Fixes tags in commits which are not to fix bugs. Changes since version 1: - Restore the npcm_i2caddr array length to fix the smatch warning. - Remove unused variables. - Handle the condition where scl_table_cnt reaches to the maximum value. - Fix the checkpatch warning. Charles Boyer (1): i2c: npcm: Enable slave in eob interrupt Tyrone Ting (5): i2c: npcm: correct the read/write operation procedure i2c: npcm: use a software flag to indicate a BER condition i2c: npcm: Modify timeout evaluation mechanism i2c: npcm: Modify the client address assignment i2c: npcm: use i2c frequency table drivers/i2c/busses/i2c-npcm7xx.c | 425 +++++++++++++++++++++++-------- 1 file changed, 323 insertions(+), 102 deletions(-) base-commit: f56f4ba2fc1dbefd3242946f2fad35338a60e3bc