mbox series

[v2,00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs

Message ID cover.1605823502.git.cristian.ciocaltea@gmail.com
Headers show
Series Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs | expand

Message

Cristian Ciocaltea Nov. 19, 2020, 11:55 p.m. UTC
Hi,

This patchset brings a series of improvements for the Actions Semi S500
SoCs family, by adding support for Clock & Reset Management Units, DMA,
MMC, I2C & SIRQ controllers.

Please note the patches consist mostly of DTS and bindings/compatibles
changes, since all the work they depend on has been already merged,
i.e. clock fixes/additions, pinctrl driver, sirq driver.

For the moment, I have only enabled the features I could test on
RoseapplePi SBC.

Thanks,
Cristi

Changes in v2:
- Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
- Added support for the SIRQ controller
- Added new entries in MAINTAINERS
- Updated naming of some patches in v1

Cristian Ciocaltea (18):
  arm: dts: owl-s500: Add Clock Management Unit
  arm: dts: owl-s500: Set CMU clocks for UARTs
  arm: dts: owl-s500: Add Reset controller
  dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
  dmaengine: owl: Add compatible for the Actions Semi S500 DMA
    controller
  arm: dts: owl-s500: Add DMA controller
  arm: dts: owl-s500: Add pinctrl & GPIO support
  dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
  arm: dts: owl-s500: Add MMC support
  dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
  MAINTAINERS: Update entry for Actions Semi Owl I2C binding
  i2c: owl: Add compatible for the Actions Semi S500 I2C controller
  arm: dts: owl-s500: Add I2C support
  arm: dts: owl-s500: Add SIRQ controller
  arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
  arm: dts: owl-s500-roseapplepi: Add uSD support
  arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
  MAINTAINERS: Add linux-actions ML for Actions Semi Arch

 .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
 .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
 .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
 .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
 MAINTAINERS                                   |   3 +-
 arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
 arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
 drivers/dma/owl-dma.c                         |   1 +
 drivers/i2c/busses/i2c-owl.c                  |   1 +
 9 files changed, 304 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml

Comments

Manivannan Sadhasivam Nov. 28, 2020, 7:35 a.m. UTC | #1
On Fri, Nov 20, 2020 at 01:56:07AM +0200, Cristian Ciocaltea wrote:
> Add I2C controller nodes for Actions Semi S500 SoC.

> 

> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>


Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Thanks,
Mani

> ---

>  arch/arm/boot/dts/owl-s500.dtsi | 40 +++++++++++++++++++++++++++++++++

>  1 file changed, 40 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi

> index 7af7c9e1119d..55f8b8c2e149 100644

> --- a/arch/arm/boot/dts/owl-s500.dtsi

> +++ b/arch/arm/boot/dts/owl-s500.dtsi

> @@ -193,6 +193,46 @@ cmu: clock-controller@b0160000 {

>  			#reset-cells = <1>;

>  		};

>  

> +		i2c0: i2c@b0170000 {

> +			compatible = "actions,s500-i2c";

> +			reg = <0xb0170000 0x4000>;

> +			clocks = <&cmu CLK_I2C0>;

> +			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;

> +			#address-cells = <1>;

> +			#size-cells = <0>;

> +			status = "disabled";

> +		};

> +

> +		i2c1: i2c@b0174000 {

> +			compatible = "actions,s500-i2c";

> +			reg = <0xb0174000 0x4000>;

> +			clocks = <&cmu CLK_I2C1>;

> +			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;

> +			#address-cells = <1>;

> +			#size-cells = <0>;

> +			status = "disabled";

> +		};

> +

> +		i2c2: i2c@b0178000 {

> +			compatible = "actions,s500-i2c";

> +			reg = <0xb0178000 0x4000>;

> +			clocks = <&cmu CLK_I2C2>;

> +			interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;

> +			#address-cells = <1>;

> +			#size-cells = <0>;

> +			status = "disabled";

> +		};

> +

> +		i2c3: i2c@b017c000 {

> +			compatible = "actions,s500-i2c";

> +			reg = <0xb017c000 0x4000>;

> +			clocks = <&cmu CLK_I2C3>;

> +			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;

> +			#address-cells = <1>;

> +			#size-cells = <0>;

> +			status = "disabled";

> +		};

> +

>  		timer: timer@b0168000 {

>  			compatible = "actions,s500-timer";

>  			reg = <0xb0168000 0x8000>;

> -- 

> 2.29.2

>
Rob Herring (Arm) Dec. 7, 2020, 10:12 p.m. UTC | #2
On Fri, 20 Nov 2020 01:56:04 +0200, Cristian Ciocaltea wrote:
> Convert the Actions Semi Owl I2C DT binding to a YAML schema for
> enabling DT validation.
> 
> Additionally, add a new compatible string corresponding to the I2C
> controller found in the S500 variant of the Actions Semi Owl SoCs
> family.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> ---
>  .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
>  .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
>  2 files changed, 62 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Cristian Ciocaltea Dec. 7, 2020, 10:58 p.m. UTC | #3
On Mon, Dec 07, 2020 at 04:12:14PM -0600, Rob Herring wrote:
> On Fri, 20 Nov 2020 01:56:04 +0200, Cristian Ciocaltea wrote:
> > Convert the Actions Semi Owl I2C DT binding to a YAML schema for
> > enabling DT validation.
> > 
> > Additionally, add a new compatible string corresponding to the I2C
> > controller found in the S500 variant of the Actions Semi Owl SoCs
> > family.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > ---
> >  .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
> >  .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
> >  2 files changed, 62 insertions(+), 29 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
> >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for reviewing,
Cristi
Wolfram Sang Dec. 9, 2020, 8:22 p.m. UTC | #4
On Fri, Nov 20, 2020 at 01:56:04AM +0200, Cristian Ciocaltea wrote:
> Convert the Actions Semi Owl I2C DT binding to a YAML schema for
> enabling DT validation.
> 
> Additionally, add a new compatible string corresponding to the I2C
> controller found in the S500 variant of the Actions Semi Owl SoCs
> family.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Applied to for-next, thanks!
Wolfram Sang Dec. 9, 2020, 8:25 p.m. UTC | #5
On Sat, Nov 28, 2020 at 01:05:16PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 20, 2020 at 01:56:07AM +0200, Cristian Ciocaltea wrote:
> > Add I2C controller nodes for Actions Semi S500 SoC.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

DTS changes usually go in via arm-soc, so I am not picking this unless
there is a reason to do so.
Manivannan Sadhasivam Dec. 10, 2020, 3:33 a.m. UTC | #6
On Wed, Dec 09, 2020 at 09:25:06PM +0100, Wolfram Sang wrote:
> On Sat, Nov 28, 2020 at 01:05:16PM +0530, Manivannan Sadhasivam wrote:

> > On Fri, Nov 20, 2020 at 01:56:07AM +0200, Cristian Ciocaltea wrote:

> > > Add I2C controller nodes for Actions Semi S500 SoC.

> > > 

> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

> > 

> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> 

> DTS changes usually go in via arm-soc, so I am not picking this unless

> there is a reason to do so.

> 


No you should not. This patch will go through actions sub tree which me or
Andreas will pick it.

Thanks,
Mani