From patchwork Mon Jun 9 13:11:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 31562 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f69.google.com (mail-pb0-f69.google.com [209.85.160.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id BA70020675 for ; Mon, 9 Jun 2014 13:11:25 +0000 (UTC) Received: by mail-pb0-f69.google.com with SMTP id uo5sf7908718pbc.0 for ; Mon, 09 Jun 2014 06:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=Ski7X5NtagFchRDLervZ9UZGWO1hMS+zfnho3UHtS6Q=; b=CoWOim+a0E9TRLR0PYg5ikPcU+DjM4AzjuJoctAAgUUtFzKCvJ68NVgMaK2thb8q9V wUAdNQ+kDBcisfnzIelLQXfIiJ2Z90QhJaiRF+SCqJVrRoT3tyaOXEaG9ApN2ruMfK1D DjW/EGGBu+Zf3deYWb4YpEFblBJiXV1SE4wsU4vGmrNu3KJ1QxcSwChhYX34eVzAr1H+ +9mbDxWl+npE6RhENGkvhS0iMRsKVW0r6+6BejgFIkoV5AF3TluLW0m3XG0cdXlo6AaT 5ALN4+Sgdo7dAn17PLFXhuNoN03X6kZN8IfI1UI0E6Pl4k+HqxwRNKrzPpms7eqNVAjE TJKw== X-Gm-Message-State: ALoCoQmHV3q8H5sZ2l4abYKE+foOm7N02QhUSAaxcHVkxPXS+GOw3DlU6esbsOC5ezZ9CcC7q9Jy X-Received: by 10.68.197.73 with SMTP id is9mr7223909pbc.0.1402319485074; Mon, 09 Jun 2014 06:11:25 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.104.49 with SMTP id z46ls1584576qge.50.gmail; Mon, 09 Jun 2014 06:11:24 -0700 (PDT) X-Received: by 10.220.94.8 with SMTP id x8mr603699vcm.67.1402319484839; Mon, 09 Jun 2014 06:11:24 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id ve5si10582329vcb.76.2014.06.09.06.11.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Jun 2014 06:11:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id jz11so2298981veb.31 for ; Mon, 09 Jun 2014 06:11:24 -0700 (PDT) X-Received: by 10.58.220.230 with SMTP id pz6mr5718092vec.9.1402319484743; Mon, 09 Jun 2014 06:11:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp144866vcb; Mon, 9 Jun 2014 06:11:24 -0700 (PDT) X-Received: by 10.68.186.130 with SMTP id fk2mr4476956pbc.60.1402319483936; Mon, 09 Jun 2014 06:11:23 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ta1si2303193pac.50.2014.06.09.06.11.23; Mon, 09 Jun 2014 06:11:23 -0700 (PDT) Received-SPF: none (google.com: linux-i2c-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbaFINLX (ORCPT + 2 others); Mon, 9 Jun 2014 09:11:23 -0400 Received: from mail-we0-f180.google.com ([74.125.82.180]:39702 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932277AbaFINLW (ORCPT ); Mon, 9 Jun 2014 09:11:22 -0400 Received: by mail-we0-f180.google.com with SMTP id x48so3037816wes.39 for ; Mon, 09 Jun 2014 06:11:21 -0700 (PDT) X-Received: by 10.180.182.115 with SMTP id ed19mr20072551wic.29.1402319481203; Mon, 09 Jun 2014 06:11:21 -0700 (PDT) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id l2sm14688642wix.13.2014.06.09.06.11.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jun 2014 06:11:20 -0700 (PDT) From: Linus Walleij To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Linus Walleij Subject: [PATCH] i2c: mux: pca954x: fix dependencies Date: Mon, 9 Jun 2014 15:11:13 +0200 Message-Id: <1402319473-14993-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 Sender: linux-i2c-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-i2c@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This driver causes the following randconfig build error: drivers/i2c/muxes/i2c-mux-pca954x.c: In function ‘pca954x_probe’: drivers/i2c/muxes/i2c-mux-pca954x.c:204:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration] gpio = devm_gpiod_get(&client->dev, "reset"); ^ drivers/i2c/muxes/i2c-mux-pca954x.c:204:7: warning: assignment makes pointer from integer without a cast [enabled by default] gpio = devm_gpiod_get(&client->dev, "reset"); ^ drivers/i2c/muxes/i2c-mux-pca954x.c:206:3: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration] gpiod_direction_output(gpio, 0); ^ cc1: some warnings being treated as errors make[3]: *** [drivers/i2c/muxes/i2c-mux-pca954x.o] Error 1 This is because it is getting compiled without gpiolib, so introduce an explicit dependency. Reported-by: Jim Davis Signed-off-by: Linus Walleij --- drivers/i2c/muxes/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index f7f9865b8b89..f6d313e528de 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -40,6 +40,7 @@ config I2C_MUX_PCA9541 config I2C_MUX_PCA954x tristate "Philips PCA954x I2C Mux/switches" + depends on GPIOLIB help If you say yes here you get support for the Philips PCA954x I2C mux/switch devices.