| Message ID | 1642080623-15980-3-git-send-email-akhilrajeev@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Thu, Jan 13, 2022 at 07:00:19PM +0530, Akhil R wrote: > Add documentation for Tegra234 I2C compatible. > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > --- > Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > index 424a4fc..c58e256 100644 > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > @@ -80,6 +80,11 @@ properties: > support for 64 KiB transactions whereas earlier chips supported no > more than 4 KiB per transactions. > const: nvidia,tegra194-i2c > + - description: | > + Tegra234 has 8 generic I2C controllers, two of which are in the AON > + (always-on) partition of the SoC. All of these controllers are > + similar to those found on Tegra194. > + const: nvidia,tegra234-i2c Sounds like this needs a fallback to nvidia,tegra194-i2c if it works, but without optimal timing. Rob
> On Thu, Jan 13, 2022 at 07:00:19PM +0530, Akhil R wrote: > > Add documentation for Tegra234 I2C compatible. > > > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > > --- > > Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 5 > > +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > > b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > > index 424a4fc..c58e256 100644 > > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > > @@ -80,6 +80,11 @@ properties: > > support for 64 KiB transactions whereas earlier chips supported no > > more than 4 KiB per transactions. > > const: nvidia,tegra194-i2c > > + - description: | > > + Tegra234 has 8 generic I2C controllers, two of which are in the AON > > + (always-on) partition of the SoC. All of these controllers are > > + similar to those found on Tegra194. > > + const: nvidia,tegra234-i2c > > Sounds like this needs a fallback to nvidia,tegra194-i2c if it works, but without > optimal timing. Yes. The timing for tegra194 works for tegra234 as well. So, this change is reverted. I had sent the patch updated. Latest is here - https://lkml.org/lkml/2022/1/24/335 Only the device tree nodes are required to be added now. Thanks, Akhil
diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml index 424a4fc..c58e256 100644 --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml @@ -80,6 +80,11 @@ properties: support for 64 KiB transactions whereas earlier chips supported no more than 4 KiB per transactions. const: nvidia,tegra194-i2c + - description: | + Tegra234 has 8 generic I2C controllers, two of which are in the AON + (always-on) partition of the SoC. All of these controllers are + similar to those found on Tegra194. + const: nvidia,tegra234-i2c reg: maxItems: 1
Add documentation for Tegra234 I2C compatible. Signed-off-by: Akhil R <akhilrajeev@nvidia.com> --- Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 5 +++++ 1 file changed, 5 insertions(+)