diff mbox series

[4/8] i2c: octeon: check correct size of maximum RECV_LEN packet

Message ID 20210109124314.27466-5-wsa+renesas@sang-engineering.com
State Accepted
Commit 1b2cfa2d1dbdcc3b6dba1ecb7026a537a1d7277f
Headers show
Series None | expand

Commit Message

Wolfram Sang Jan. 9, 2021, 12:43 p.m. UTC 
I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the
SMBus 2.0 specs. No reason to add one to it.

Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-octeon-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Robert Richter Jan. 11, 2021, 9:26 a.m. UTC | #1 
On 09.01.21 13:43:08, Wolfram Sang wrote:
> I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the

> SMBus 2.0 specs. No reason to add one to it.

> 

> Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN")

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Reviewed-by: Robert Richter <rric@kernel.org>
Wolfram Sang Jan. 17, 2021, 11:27 a.m. UTC | #2 
On Sat, Jan 09, 2021 at 01:43:08PM +0100, Wolfram Sang wrote:
> I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the

> SMBus 2.0 specs. No reason to add one to it.

> 

> Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN")

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Applied to for-current, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
index d9607905dc2f..845eda70b8ca 100644
--- a/drivers/i2c/busses/i2c-octeon-core.c
+++ b/drivers/i2c/busses/i2c-octeon-core.c
@@ -347,7 +347,7 @@  static int octeon_i2c_read(struct octeon_i2c *i2c, int target,
 		if (result)
 			return result;
 		if (recv_len && i == 0) {
-			if (data[i] > I2C_SMBUS_BLOCK_MAX + 1)
+			if (data[i] > I2C_SMBUS_BLOCK_MAX)
 				return -EPROTO;
 			length += data[i];
 		}