[0/7] Input: goodix - Add support for controllers without flash

Hi All,

A while ago I bought a Glavey TM800A550L tablet. This is a Bay Trail (x86)
tablet which comes with Android from the factory.

It is mostly just another Bay Trail tablet, but the way the Goodix
touchscreen on it works is interesting. The controller needs to have
firmware uploaded to it before it will work. After that it pretty much
works 100% the same as any other Goodix touchscreen controller.

I've described this patch-set in the Subject as "Add support for
controllers without flash", but I suspect that the Goodix controllers
used on Bay Trail devices which ship with Windows pre-installed may also
lack flash; and that the Windows version of the BIOS-es on these devices
does the upload for us. Anyways just something which I'm wondering about,
these patches are necessary to make things work regardless.

These patches should also be useful for supporting the Goodix controllers
on some ARM based devices, as some of those need the OS to upload the
firmware too AFAIK.

Note patch 7/7 is included to get an overview of the entire set.
I'll merge that one myself through the pdx86 tree. Patches 1-6 are
intended for merging through the input tree.

Regards,

Hans


Hans de Goede (7):
  Input: goodix - Change goodix_i2c_write() len parameter type to int
  Input: goodix - Add a goodix.h header file
  Input: goodix - Refactor reset handling
  Input: goodix - Push error logging up into i2c_read and i2c_write
    helpers
  Input: goodix - Allow specifying the config filename through a
    "goodix,config-name" device-property
  Input: goodix - Add support for controllers without flash
  platform/x86: touchscreen_dmi: Add info for the Goodix GT912 panel of
    TM800A550L tablets

 MAINTAINERS                                 |   3 +-
 drivers/input/touchscreen/Makefile          |   3 +-
 drivers/input/touchscreen/goodix.c          | 239 +++++------
 drivers/input/touchscreen/goodix.h          | 118 ++++++
 drivers/input/touchscreen/goodix_fwupload.c | 437 ++++++++++++++++++++
 drivers/platform/x86/touchscreen_dmi.c      |  21 +
 6 files changed, 684 insertions(+), 137 deletions(-)
 create mode 100644 drivers/input/touchscreen/goodix.h
 create mode 100644 drivers/input/touchscreen/goodix_fwupload.c

Hi,

On 4/28/21 1:46 PM, Hans de Goede wrote:
> Hi All,

> 

> A while ago I bought a Glavey TM800A550L tablet. This is a Bay Trail (x86)

> tablet which comes with Android from the factory.

> 

> It is mostly just another Bay Trail tablet, but the way the Goodix

> touchscreen on it works is interesting. The controller needs to have

> firmware uploaded to it before it will work. After that it pretty much

> works 100% the same as any other Goodix touchscreen controller.

> 

> I've described this patch-set in the Subject as "Add support for

> controllers without flash", but I suspect that the Goodix controllers

> used on Bay Trail devices which ship with Windows pre-installed may also

> lack flash; and that the Windows version of the BIOS-es on these devices

> does the upload for us. Anyways just something which I'm wondering about,

> these patches are necessary to make things work regardless.

> 

> These patches should also be useful for supporting the Goodix controllers

> on some ARM based devices, as some of those need the OS to upload the

> firmware too AFAIK.

> 

> Note patch 7/7 is included to get an overview of the entire set.

> I'll merge that one myself through the pdx86 tree. Patches 1-6 are

> intended for merging through the input tree.


Self NACK for this series I just found out that the controller on
a Chuwi Hi13 gets mis-indentified as needing fw upload even though
that is not the case.  I'll send out a fixed v2 rebased on top of
5.14-rc1 once 5.14-rc1 is out.

Regards,

Hans



> Hans de Goede (7):

>   Input: goodix - Change goodix_i2c_write() len parameter type to int

>   Input: goodix - Add a goodix.h header file

>   Input: goodix - Refactor reset handling

>   Input: goodix - Push error logging up into i2c_read and i2c_write

>     helpers

>   Input: goodix - Allow specifying the config filename through a

>     "goodix,config-name" device-property

>   Input: goodix - Add support for controllers without flash

>   platform/x86: touchscreen_dmi: Add info for the Goodix GT912 panel of

>     TM800A550L tablets

> 

>  MAINTAINERS                                 |   3 +-

>  drivers/input/touchscreen/Makefile          |   3 +-

>  drivers/input/touchscreen/goodix.c          | 239 +++++------

>  drivers/input/touchscreen/goodix.h          | 118 ++++++

>  drivers/input/touchscreen/goodix_fwupload.c | 437 ++++++++++++++++++++

>  drivers/platform/x86/touchscreen_dmi.c      |  21 +

>  6 files changed, 684 insertions(+), 137 deletions(-)

>  create mode 100644 drivers/input/touchscreen/goodix.h

>  create mode 100644 drivers/input/touchscreen/goodix_fwupload.c

>