| Message ID | 20241031123113.18843-1-charles.goodix@gmail.com |
|---|---|
| Headers | show |
| Series | HID: hid-goodix: Improve handling of HID feature reports | expand |
On Thu, 31 Oct 2024, Charles Wang wrote: > The patchset introduces the following two changes: > > 1) Align with the i2c-hid driver by returning 0 instead of -EINVAL when > an empty response is received, ensuring that userspace programs utilizing > the hidraw node receive consistent return values. > > 2) Implement the hid get/set feature report function using a separate > address, rather than sharing an address with coordinate reporting, to > prevent feature events from being overwritten by coordinate events. > > Signed-off-by: Charles Wang <charles.goodix@gmail.com> > --- > Changes in v2: > - Split the commit into two patches. Now queued in hid.git#for-6.13/goodix. Thanks,
The patchset introduces the following two changes: 1) Align with the i2c-hid driver by returning 0 instead of -EINVAL when an empty response is received, ensuring that userspace programs utilizing the hidraw node receive consistent return values. 2) Implement the hid get/set feature report function using a separate address, rather than sharing an address with coordinate reporting, to prevent feature events from being overwritten by coordinate events. Signed-off-by: Charles Wang <charles.goodix@gmail.com> --- Changes in v2: - Split the commit into two patches. --- Charles Wang (2): HID: hid-goodix: Return 0 when receiving an empty HID feature package HID: hid-goodix: Fix HID get/set feature operation overwritten problem drivers/hid/hid-goodix-spi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)