mbox series

[0/9] Remove pcf50633

Message ID 20250309193612.251929-1-linux@treblig.org
Headers show
Series Remove pcf50633 | expand

Message

Dr. David Alan Gilbert March 9, 2025, 7:36 p.m. UTC
From: "Dr. David Alan Gilbert" <linux@treblig.org>

The pcf50633 was used as part of the OpenMoko devices but
the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gallifrey/

Remove it.

I've split this up based on the subcomponents to make the size
of each patch sensible.

Dave

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>


Dr. David Alan Gilbert (9):
  mfd: pcf50633-adc:  Remove
  backlight: pcf50633-backlight: Remove
  rtc: pcf50633: Remove
  mfd: pcF50633-gpio: Remove
  Input: pcf50633-input - Remove
  regulator: pcf50633-regulator: Remove
  power: supply: pcf50633: Remove charger
  mfd: pcf50633: Remove irq code
  mfd: pcf50633: Remove remains

 arch/mips/configs/ip27_defconfig             |   3 -
 drivers/input/misc/Kconfig                   |   7 -
 drivers/input/misc/Makefile                  |   1 -
 drivers/input/misc/pcf50633-input.c          | 113 -----
 drivers/mfd/Kconfig                          |  24 -
 drivers/mfd/Makefile                         |   4 -
 drivers/mfd/pcf50633-adc.c                   | 255 ----------
 drivers/mfd/pcf50633-core.c                  | 304 ------------
 drivers/mfd/pcf50633-gpio.c                  |  92 ----
 drivers/mfd/pcf50633-irq.c                   | 312 -------------
 drivers/power/supply/Kconfig                 |   6 -
 drivers/power/supply/Makefile                |   1 -
 drivers/power/supply/pcf50633-charger.c      | 466 -------------------
 drivers/regulator/Kconfig                    |   7 -
 drivers/regulator/Makefile                   |   1 -
 drivers/regulator/pcf50633-regulator.c       | 124 -----
 drivers/rtc/Kconfig                          |   7 -
 drivers/rtc/Makefile                         |   1 -
 drivers/rtc/rtc-pcf50633.c                   | 284 -----------
 drivers/video/backlight/Kconfig              |   7 -
 drivers/video/backlight/Makefile             |   1 -
 drivers/video/backlight/pcf50633-backlight.c | 154 ------
 include/linux/mfd/pcf50633/adc.h             |  69 ---
 include/linux/mfd/pcf50633/backlight.h       |  42 --
 include/linux/mfd/pcf50633/core.h            | 232 ---------
 include/linux/mfd/pcf50633/gpio.h            |  48 --
 include/linux/mfd/pcf50633/mbc.h             | 130 ------
 include/linux/mfd/pcf50633/pmic.h            |  68 ---
 28 files changed, 2763 deletions(-)
 delete mode 100644 drivers/input/misc/pcf50633-input.c
 delete mode 100644 drivers/mfd/pcf50633-adc.c
 delete mode 100644 drivers/mfd/pcf50633-core.c
 delete mode 100644 drivers/mfd/pcf50633-gpio.c
 delete mode 100644 drivers/mfd/pcf50633-irq.c
 delete mode 100644 drivers/power/supply/pcf50633-charger.c
 delete mode 100644 drivers/regulator/pcf50633-regulator.c
 delete mode 100644 drivers/rtc/rtc-pcf50633.c
 delete mode 100644 drivers/video/backlight/pcf50633-backlight.c
 delete mode 100644 include/linux/mfd/pcf50633/adc.h
 delete mode 100644 include/linux/mfd/pcf50633/backlight.h
 delete mode 100644 include/linux/mfd/pcf50633/core.h
 delete mode 100644 include/linux/mfd/pcf50633/gpio.h
 delete mode 100644 include/linux/mfd/pcf50633/mbc.h
 delete mode 100644 include/linux/mfd/pcf50633/pmic.h

Comments

Arnd Bergmann March 10, 2025, 7:22 a.m. UTC | #1
On Sun, Mar 9, 2025, at 20:36, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The pcf50633 was used as part of the OpenMoko devices but
> the support for its main chip was recently removed in:
> commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")
>
> See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gallifrey/
>
> Remove it.
>
> I've split this up based on the subcomponents to make the size
> of each patch sensible.
>
> Dave
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Looks all good to me. Whole series

Acked-by: Arnd Bergmann <arnd@arndb.de>
Dr. David Alan Gilbert March 10, 2025, 7:03 p.m. UTC | #2
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> The pcf50633 was used as part of the OpenMoko devices but
> the support for its main chip was recently removed in:
> commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")
> 
> See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gallifrey/
> 
> Remove it.
> 
> I've split this up based on the subcomponents to make the size
> of each patch sensible.
> 

Both Alexandre and Mark would prefer the mfd changes to be
more separate from the subsystem changes, so I'll cook a v2
shortly.

Dave

> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> 
> Dr. David Alan Gilbert (9):
>   mfd: pcf50633-adc:  Remove
>   backlight: pcf50633-backlight: Remove
>   rtc: pcf50633: Remove
>   mfd: pcF50633-gpio: Remove
>   Input: pcf50633-input - Remove
>   regulator: pcf50633-regulator: Remove
>   power: supply: pcf50633: Remove charger
>   mfd: pcf50633: Remove irq code
>   mfd: pcf50633: Remove remains
> 
>  arch/mips/configs/ip27_defconfig             |   3 -
>  drivers/input/misc/Kconfig                   |   7 -
>  drivers/input/misc/Makefile                  |   1 -
>  drivers/input/misc/pcf50633-input.c          | 113 -----
>  drivers/mfd/Kconfig                          |  24 -
>  drivers/mfd/Makefile                         |   4 -
>  drivers/mfd/pcf50633-adc.c                   | 255 ----------
>  drivers/mfd/pcf50633-core.c                  | 304 ------------
>  drivers/mfd/pcf50633-gpio.c                  |  92 ----
>  drivers/mfd/pcf50633-irq.c                   | 312 -------------
>  drivers/power/supply/Kconfig                 |   6 -
>  drivers/power/supply/Makefile                |   1 -
>  drivers/power/supply/pcf50633-charger.c      | 466 -------------------
>  drivers/regulator/Kconfig                    |   7 -
>  drivers/regulator/Makefile                   |   1 -
>  drivers/regulator/pcf50633-regulator.c       | 124 -----
>  drivers/rtc/Kconfig                          |   7 -
>  drivers/rtc/Makefile                         |   1 -
>  drivers/rtc/rtc-pcf50633.c                   | 284 -----------
>  drivers/video/backlight/Kconfig              |   7 -
>  drivers/video/backlight/Makefile             |   1 -
>  drivers/video/backlight/pcf50633-backlight.c | 154 ------
>  include/linux/mfd/pcf50633/adc.h             |  69 ---
>  include/linux/mfd/pcf50633/backlight.h       |  42 --
>  include/linux/mfd/pcf50633/core.h            | 232 ---------
>  include/linux/mfd/pcf50633/gpio.h            |  48 --
>  include/linux/mfd/pcf50633/mbc.h             | 130 ------
>  include/linux/mfd/pcf50633/pmic.h            |  68 ---
>  28 files changed, 2763 deletions(-)
>  delete mode 100644 drivers/input/misc/pcf50633-input.c
>  delete mode 100644 drivers/mfd/pcf50633-adc.c
>  delete mode 100644 drivers/mfd/pcf50633-core.c
>  delete mode 100644 drivers/mfd/pcf50633-gpio.c
>  delete mode 100644 drivers/mfd/pcf50633-irq.c
>  delete mode 100644 drivers/power/supply/pcf50633-charger.c
>  delete mode 100644 drivers/regulator/pcf50633-regulator.c
>  delete mode 100644 drivers/rtc/rtc-pcf50633.c
>  delete mode 100644 drivers/video/backlight/pcf50633-backlight.c
>  delete mode 100644 include/linux/mfd/pcf50633/adc.h
>  delete mode 100644 include/linux/mfd/pcf50633/backlight.h
>  delete mode 100644 include/linux/mfd/pcf50633/core.h
>  delete mode 100644 include/linux/mfd/pcf50633/gpio.h
>  delete mode 100644 include/linux/mfd/pcf50633/mbc.h
>  delete mode 100644 include/linux/mfd/pcf50633/pmic.h
> 
> -- 
> 2.48.1
>
Dr. David Alan Gilbert March 11, 2025, 1:51 a.m. UTC | #3
* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> * linux@treblig.org (linux@treblig.org) wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > The pcf50633 was used as part of the OpenMoko devices but
> > the support for its main chip was recently removed in:
> > commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")
> > 
> > See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gallifrey/
> > 
> > Remove it.
> > 
> > I've split this up based on the subcomponents to make the size
> > of each patch sensible.
> > 
> 
> Both Alexandre and Mark would prefer the mfd changes to be
> more separate from the subsystem changes, so I'll cook a v2
> shortly.

v2 thread starting with message
  20250311014959.743322-1-linux@treblig.org
just posted.

Thanks!

Dave

> Dave
> 
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > 
> > Dr. David Alan Gilbert (9):
> >   mfd: pcf50633-adc:  Remove
> >   backlight: pcf50633-backlight: Remove
> >   rtc: pcf50633: Remove
> >   mfd: pcF50633-gpio: Remove
> >   Input: pcf50633-input - Remove
> >   regulator: pcf50633-regulator: Remove
> >   power: supply: pcf50633: Remove charger
> >   mfd: pcf50633: Remove irq code
> >   mfd: pcf50633: Remove remains
> > 
> >  arch/mips/configs/ip27_defconfig             |   3 -
> >  drivers/input/misc/Kconfig                   |   7 -
> >  drivers/input/misc/Makefile                  |   1 -
> >  drivers/input/misc/pcf50633-input.c          | 113 -----
> >  drivers/mfd/Kconfig                          |  24 -
> >  drivers/mfd/Makefile                         |   4 -
> >  drivers/mfd/pcf50633-adc.c                   | 255 ----------
> >  drivers/mfd/pcf50633-core.c                  | 304 ------------
> >  drivers/mfd/pcf50633-gpio.c                  |  92 ----
> >  drivers/mfd/pcf50633-irq.c                   | 312 -------------
> >  drivers/power/supply/Kconfig                 |   6 -
> >  drivers/power/supply/Makefile                |   1 -
> >  drivers/power/supply/pcf50633-charger.c      | 466 -------------------
> >  drivers/regulator/Kconfig                    |   7 -
> >  drivers/regulator/Makefile                   |   1 -
> >  drivers/regulator/pcf50633-regulator.c       | 124 -----
> >  drivers/rtc/Kconfig                          |   7 -
> >  drivers/rtc/Makefile                         |   1 -
> >  drivers/rtc/rtc-pcf50633.c                   | 284 -----------
> >  drivers/video/backlight/Kconfig              |   7 -
> >  drivers/video/backlight/Makefile             |   1 -
> >  drivers/video/backlight/pcf50633-backlight.c | 154 ------
> >  include/linux/mfd/pcf50633/adc.h             |  69 ---
> >  include/linux/mfd/pcf50633/backlight.h       |  42 --
> >  include/linux/mfd/pcf50633/core.h            | 232 ---------
> >  include/linux/mfd/pcf50633/gpio.h            |  48 --
> >  include/linux/mfd/pcf50633/mbc.h             | 130 ------
> >  include/linux/mfd/pcf50633/pmic.h            |  68 ---
> >  28 files changed, 2763 deletions(-)
> >  delete mode 100644 drivers/input/misc/pcf50633-input.c
> >  delete mode 100644 drivers/mfd/pcf50633-adc.c
> >  delete mode 100644 drivers/mfd/pcf50633-core.c
> >  delete mode 100644 drivers/mfd/pcf50633-gpio.c
> >  delete mode 100644 drivers/mfd/pcf50633-irq.c
> >  delete mode 100644 drivers/power/supply/pcf50633-charger.c
> >  delete mode 100644 drivers/regulator/pcf50633-regulator.c
> >  delete mode 100644 drivers/rtc/rtc-pcf50633.c
> >  delete mode 100644 drivers/video/backlight/pcf50633-backlight.c
> >  delete mode 100644 include/linux/mfd/pcf50633/adc.h
> >  delete mode 100644 include/linux/mfd/pcf50633/backlight.h
> >  delete mode 100644 include/linux/mfd/pcf50633/core.h
> >  delete mode 100644 include/linux/mfd/pcf50633/gpio.h
> >  delete mode 100644 include/linux/mfd/pcf50633/mbc.h
> >  delete mode 100644 include/linux/mfd/pcf50633/pmic.h
> > 
> > -- 
> > 2.48.1
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
>
Mark Brown March 11, 2025, 9:15 p.m. UTC | #4
On Tue, Mar 11, 2025 at 09:05:57PM +0000, Dr. David Alan Gilbert wrote:
> * Mark Brown (broonie@kernel.org) wrote:

> > [6/9] regulator: pcf50633-regulator: Remove
> >       commit: 248bc01138b11ff3af38c3b4a39cb8db7aae6eb6

> Thanks!
> Although....I'd only tested this as part of the series and assumed
> someone (Lee?) would pick the lot up in one go.

I test things as I apply them, it really shouldn't make a difference
either way for leaf drivers.  From my PoV this way it cuts down on
resends.