From patchwork Sat Mar 11 08:01:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dick Marinus X-Patchwork-Id: 662870 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673D3C61DA4 for ; Sat, 11 Mar 2023 08:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjCKIBe (ORCPT ); Sat, 11 Mar 2023 03:01:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbjCKIBc (ORCPT ); Sat, 11 Mar 2023 03:01:32 -0500 Received: from smtpq4.tb.mail.iss.as9143.net (smtpq4.tb.mail.iss.as9143.net [212.54.42.167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAB6125DAF for ; Sat, 11 Mar 2023 00:01:30 -0800 (PST) Received: from [212.54.42.105] (helo=smtp1.tb.mail.iss.as9143.net) by smtpq4.tb.mail.iss.as9143.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pauAT-0001Va-6K for linux-input@vger.kernel.org; Sat, 11 Mar 2023 09:01:29 +0100 Received: from routi.mrns.nl ([213.93.239.227]) by smtp1.tb.mail.iss.as9143.net with ESMTPA id auARpf1q1Ivg1auARpkw8e; Sat, 11 Mar 2023 09:01:29 +0100 X-Env-Mailfrom: dick@mrns.nl X-Env-Rcptto: linux-input@vger.kernel.org X-SourceIP: 213.93.239.227 X-CNFS-Analysis: v=2.4 cv=OIXhnwWB c=1 sm=1 tr=0 ts=640c3559 cx=a_exe a=JHrq6bmmrihZf+Bww3MhDg==:117 a=JHrq6bmmrihZf+Bww3MhDg==:17 a=k__wU0fu6RkA:10 a=oxU5Xt4QAAAA:8 a=H1w7Dpf3J3Y2f7KK384A:9 a=jKdzr7yA372qb7_9lzlF:22 X-Authenticated-Sender: boeierlaan60@ziggo.nl Received: by routi.mrns.nl (sSMTP sendmail emulation); Sat, 11 Mar 2023 09:01:27 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mrns.nl; i=@mrns.nl; q=dns/txt; s=mail; t=1678521687; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=JyOxZNLMgepTG2sF3FpoZIep+bHAsj6d3amLul+RV4Y=; b=kYVjUkaZhjf01FfEThxQ6OI45hZrVwy4eCpyXvKie9NjWhZmPZc3Ck9MnB7e/Y8ym8eYE /2P0XxAPBZeYwP9Z511uVTAvW3zuOB2KUZeCPJMGzQcOZtq/mez/8LWkRyZAoMujM6lT968 nU+TTvJZgJQyM68f6HrzoztmWvDRzQY= From: Dick Marinus To: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: Dick Marinus Subject: [PATCH] Use HID descriptor for razer devices Date: Sat, 11 Mar 2023 09:01:18 +0100 Message-Id: <20230311080118.2810709-1-dick@mrns.nl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CMAE-Envelope: MS4xfP9zjk9qNPfWT9Y53JZlmwL4/2eMa5Ml+0r/tpXrvqueN4+TtPL/k9Ex2YJZCjMSEXoj6QlAnrV6S30C/gwZ0RjshFopxP+f7uj1lXWmbbAFvOrXtnW4 kRnjeFENO0oh+Ax0l8n5aEW2kotyfHINfFRAMzjueUKNrikwuSsGcIp6upQKGhBcI3yCyn/Ucq0MSgP5qdgUdUgOGPuXibEwsr6+BbZAlhYG7vOtJrHSgnMZ LwnpIheoJTp6IWKv5/ooxmy0HcCYwX0CfbltnRZ2YWltafknvIbjBeaAsUxSl71yGp5eXHTXym3bXk6oyU56t3uOWtp9szBotsaVAF44hac= Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org hid-razer currently makes some guesses which device should be used to send control messages and the size of it. This patch derives this information from the HID descriptors, the Windows Drivers from Razer also do this. The crc in the blackwidow_init packet is now calculated (copied from openrazer GPL code). Signed-off-by: Dick Marinus --- drivers/hid/hid-razer.c | 141 ++++++++++++++++++++++++++++++---------- drivers/hid/hid-razer.h | 7 ++ 2 files changed, 115 insertions(+), 33 deletions(-) create mode 100644 drivers/hid/hid-razer.h diff --git a/drivers/hid/hid-razer.c b/drivers/hid/hid-razer.c index 740df148b0..0c83269d66 100644 --- a/drivers/hid/hid-razer.c +++ b/drivers/hid/hid-razer.c @@ -15,31 +15,15 @@ #include #include "hid-ids.h" +#include "hid-razer.h" #define map_key_clear(c) hid_map_usage_clear(hi, usage, bit, max, EV_KEY, (c)) -#define RAZER_BLACKWIDOW_TRANSFER_BUF_SIZE 91 - static bool macro_key_remapping = 1; module_param(macro_key_remapping, bool, 0644); MODULE_PARM_DESC(macro_key_remapping, " on (Y) off (N)"); - -static unsigned char blackwidow_init[RAZER_BLACKWIDOW_TRANSFER_BUF_SIZE] = { - 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x04, - 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x04, 0x00 -}; +static unsigned char set_device_mode[] = {0x00, 0x04, 0x02, 0x00}; static int razer_input_mapping(struct hid_device *hdev, struct hid_input *hi, struct hid_field *field, @@ -73,35 +57,125 @@ static int razer_input_mapping(struct hid_device *hdev, return 0; } +static bool razer_check_control_interface(struct hid_device *hdev) +{ + int i; + unsigned int hid; + struct hid_report *report; + struct hid_razer *hid_razer_drvdata; + + hid_razer_drvdata = hid_get_drvdata(hdev); + + list_for_each_entry(report, &hdev->report_enum[HID_FEATURE_REPORT].report_list, list) { + for (i = 0; i < report->maxfield; i++) { + hid = report->field[i]->usage->hid; + + if ((hid & HID_USAGE_PAGE) == HID_UP_MSVENDOR && (hid & HID_USAGE) == 0x2) { + hid_razer_drvdata->report_count = report->field[i]->report_count; + return true; + } + } + } + + return false; +} + +static int razer_control_message(struct hid_device *hdev, unsigned char data_len, + unsigned char *data) +{ + struct hid_razer *hid_razer_drvdata; + unsigned char *full_control_message; + unsigned char crc = 0; + unsigned int i; + unsigned int report_count; + int ret; + + if (data_len < 2) { + ret = -EINVAL; + goto cleanup_and_exit; + } + + hid_razer_drvdata = hid_get_drvdata(hdev); + + report_count = hid_razer_drvdata->report_count; + + if (report_count < 2) { + ret = -EINVAL; + goto cleanup_and_exit; + } + + full_control_message = kzalloc(report_count + 1, GFP_KERNEL); + + if (full_control_message == NULL) { + ret = -ENOMEM; + goto cleanup_and_exit; + } + + full_control_message[6] = data_len - 2; + memcpy(full_control_message + 7, data, data_len); + + for (i = 2; i < report_count - 2; i++) + crc ^= full_control_message[i]; + + full_control_message[report_count - 1] = crc; + + ret = hid_hw_raw_request( + hdev, + 0, + full_control_message, + report_count + 1, + HID_FEATURE_REPORT, + HID_REQ_SET_REPORT + ); + + if (ret != report_count + 1) { + ret = -EIO; + goto cleanup_and_exit; + } + +cleanup_and_exit: + kfree(full_control_message); + + return 0; +} + + static int razer_probe(struct hid_device *hdev, const struct hid_device_id *id) { - char *buf; int ret = 0; + struct hid_razer *hid_razer_drvdata; + + hid_razer_drvdata = kzalloc(sizeof(struct hid_razer), GFP_KERNEL); + if (hid_razer_drvdata == NULL) + return -ENOMEM; + + hid_set_drvdata(hdev, hid_razer_drvdata); ret = hid_parse(hdev); + if (ret) return ret; - /* - * Only send the enable macro keys command for the third device - * identified as mouse input. - */ - if (hdev->type == HID_TYPE_USBMOUSE) { - buf = kmemdup(blackwidow_init, RAZER_BLACKWIDOW_TRANSFER_BUF_SIZE, GFP_KERNEL); - if (buf == NULL) - return -ENOMEM; - - ret = hid_hw_raw_request(hdev, 0, buf, RAZER_BLACKWIDOW_TRANSFER_BUF_SIZE, - HID_FEATURE_REPORT, HID_REQ_SET_REPORT); - if (ret != RAZER_BLACKWIDOW_TRANSFER_BUF_SIZE) + if (razer_check_control_interface(hdev)) { + ret = razer_control_message(hdev, sizeof(set_device_mode), set_device_mode); + if (ret) { hid_err(hdev, "failed to enable macro keys: %d\n", ret); - - kfree(buf); + return ret; + } } return hid_hw_start(hdev, HID_CONNECT_DEFAULT); } +static void razer_remove(struct hid_device *hdev) +{ + struct hid_razer *hid_razer_drvdata; + + hid_razer_drvdata = hid_get_drvdata(hdev); + + kfree(hid_razer_drvdata); +} + static const struct hid_device_id razer_devices[] = { { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLACKWIDOW) }, @@ -118,6 +192,7 @@ static struct hid_driver razer_driver = { .id_table = razer_devices, .input_mapping = razer_input_mapping, .probe = razer_probe, + .remove = razer_remove, }; module_hid_driver(razer_driver); diff --git a/drivers/hid/hid-razer.h b/drivers/hid/hid-razer.h new file mode 100644 index 0000000000..d8214ca54b --- /dev/null +++ b/drivers/hid/hid-razer.h @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __HID_RAZER_H +#define __HID_RAZER_H +struct hid_razer { + unsigned int report_count; +}; +#endif