| Message ID | 20240703213756.3375978-2-dmitry.torokhov@gmail.com |
|---|---|
| State | Accepted |
| Commit | b3d65108ac8abd79e0367d77598d539b117044a3 |
| Headers | show |
| Series | Simplify event handling logic in input core | expand |
Hi Dmitry, On Wed, Jul 03, 2024 at 02:37:48PM -0700, Dmitry Torokhov wrote: > Input core favors ->events() (batch) method over ->event() method > if the former is defined, so there is no point in defining evdev_event() > as it is never called. Remove it. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Jeff LaBundy <jeff@labundy.com> > --- > drivers/input/evdev.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c > index 51e0c4954600..05abcd45b5d4 100644 > --- a/drivers/input/evdev.c > +++ b/drivers/input/evdev.c > @@ -308,17 +308,6 @@ static void evdev_events(struct input_handle *handle, > rcu_read_unlock(); > } > > -/* > - * Pass incoming event to all connected clients. > - */ > -static void evdev_event(struct input_handle *handle, > - unsigned int type, unsigned int code, int value) > -{ > - struct input_value vals[] = { { type, code, value } }; > - > - evdev_events(handle, vals, 1); > -} > - > static int evdev_fasync(int fd, struct file *file, int on) > { > struct evdev_client *client = file->private_data; > @@ -1418,7 +1407,6 @@ static const struct input_device_id evdev_ids[] = { > MODULE_DEVICE_TABLE(input, evdev_ids); > > static struct input_handler evdev_handler = { > - .event = evdev_event, > .events = evdev_events, > .connect = evdev_connect, > .disconnect = evdev_disconnect, > -- > 2.45.2.803.g4e1b14247a-goog > Kind regards, Jeff LaBundy
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 51e0c4954600..05abcd45b5d4 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c @@ -308,17 +308,6 @@ static void evdev_events(struct input_handle *handle, rcu_read_unlock(); } -/* - * Pass incoming event to all connected clients. - */ -static void evdev_event(struct input_handle *handle, - unsigned int type, unsigned int code, int value) -{ - struct input_value vals[] = { { type, code, value } }; - - evdev_events(handle, vals, 1); -} - static int evdev_fasync(int fd, struct file *file, int on) { struct evdev_client *client = file->private_data; @@ -1418,7 +1407,6 @@ static const struct input_device_id evdev_ids[] = { MODULE_DEVICE_TABLE(input, evdev_ids); static struct input_handler evdev_handler = { - .event = evdev_event, .events = evdev_events, .connect = evdev_connect, .disconnect = evdev_disconnect,
Input core favors ->events() (batch) method over ->event() method if the former is defined, so there is no point in defining evdev_event() as it is never called. Remove it. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/evdev.c | 12 ------------ 1 file changed, 12 deletions(-)