diff mbox series

[RFC,1/4] dt-bindings: input: melfas-mip4: document linux,keycodes property

Message ID 20250503-mip4-touchkey-v1-1-b483cda29a5b@disroot.org
State New
Headers show
Series Support for MELFAS MIP4 touchkey devices | expand

Commit Message

Kaustabh Chakraborty May 3, 2025, 9:08 a.m. UTC
Document the linux,keycodes property. The property values are key codes
which are used in input key events generated by the touchkey device.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring May 9, 2025, 10:06 p.m. UTC | #1
On Sat, May 03, 2025 at 02:38:27PM +0530, Kaustabh Chakraborty wrote:
> Document the linux,keycodes property. The property values are key codes
> which are used in input key events generated by the touchkey device.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt | 2 ++
>  1 file changed, 2 insertions(+)

Convert to DT schema if you want to add to this.

Rob
Kaustabh Chakraborty May 14, 2025, 6:13 p.m. UTC | #2
On 2025-05-09 22:06, Rob Herring wrote:
> On Sat, May 03, 2025 at 02:38:27PM +0530, Kaustabh Chakraborty wrote:
>> Document the linux,keycodes property. The property values are key codes
>> which are used in input key events generated by the touchkey device.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Convert to DT schema if you want to add to this.

Sure will. Who would be the maintainer of this driver though?
MAINTAINERS says that the driver is 'Supported' but Sangwon's
e-mail is bouncing.

> 
> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt b/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt
index b2ab5498e51900e887fab4d9b5239cccccec2ea9..16d1031ee017604ac56109dfbebfce6a05491c60 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt
@@ -7,6 +7,7 @@  Required properties:
 
 Optional properties:
 - ce-gpios: GPIO connected to the CE (chip enable) pin of the chip
+- linux,keycodes: array of keycodes to be reported by touchkeys
 
 Example:
 	i2c@00000000 {
@@ -16,5 +17,6 @@  Example:
 			interrupt-parent = <&gpio>;
 			interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
 			ce-gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
+			linux,keycodes = <KEY_MENU>, <KEY_BACK>;
 		};
 	};