diff mbox series

[v2,1/9] dt-bindings: power: supply: add pf1550

Message ID 21b1bc2ba4d266b0d69e447e60927d5985c8ae74.1747409892.git.samuel.kayode@savoirfairelinux.com
State New
Headers show
Series add support for pf1550 PMIC MFD-based drivers | expand

Commit Message

Samuel Kayode May 16, 2025, 6:47 p.m. UTC
Add the DT binding document for the battery charger module of pf1550.

Signed-off-by: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
---
 .../bindings/power/supply/pf1550_charger.yaml | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml

Comments

Krzysztof Kozlowski May 17, 2025, 11:12 a.m. UTC | #1
On 16/05/2025 20:47, Samuel Kayode wrote:
> Add the DT binding document for the battery charger module of pf1550.
> 
> Signed-off-by: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
> ---
>  .../bindings/power/supply/pf1550_charger.yaml | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml

Filename matching compatible.

> 
> diff --git a/Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml b/Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml
> new file mode 100644
> index 000000000000..10fc0b35917c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/pf1550_charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Battery charger driver for PF1550 PMIC from NXP.
Describe hardware, not driver.

Also drop full stop.


<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml b/Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml
new file mode 100644
index 000000000000..10fc0b35917c
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/pf1550_charger.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/pf1550_charger.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Battery charger driver for PF1550 PMIC from NXP.
+
+maintainers:
+  - Samuel Kayode <samuel.kayode@savoirfairelinux.com>
+
+description: |
+  This module is part of the PF1550 MFD device. For more details
+  see Documentation/devicetree/bindings/mfd/pf1550.yaml.
+
+  The charger is represented as a sub-node of the PMIC node on the device tree.
+
+properties:
+  compatible:
+    const: fsl,pf1550-charger
+
+  fsl,constant-microvolt:
+    description:
+      Constant charge voltage (in microvolts).
+    minimum: 3500000
+    maximum: 4400000
+
+  fsl,min-system-microvolt:
+    description:
+      Minimum charge voltage (in microvolts).
+    enum: [ 3500000, 3700000, 4300000 ]
+
+  fsl,thermal-regulation:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Temperature (in degrees Celsius) threshold past which the charging
+      current is reduced.
+    enum: [ 60, 75, 90, 105 ]
+
+required:
+  - compatible
+additionalProperties: false
+
+...