mbox series

[v1,0/4] kselftest/arm64: Miscelaneous MTE test updates

Message ID 20220310144335.2097457-1-broonie@kernel.org
Headers show
Series kselftest/arm64: Miscelaneous MTE test updates | expand

Message

Mark Brown March 10, 2022, 2:43 p.m. UTC 
This series is just a set of minor tweaks and improvements for the MTE
tests that I did while working on the asymmetric mode support for
userspace which seemed like they might be worth keeping even though the
prctl() for asymmetric mode got removed.

Mark Brown (4):
  kselftest/arm64: Handle more kselftest result codes in MTE helpers
  kselftest/arm64: Log unexpected asynchronous MTE faults
  kselftest/arm64: Refactor parameter checking in mte_switch_mode()
  kselftest/arm64: Add simple test for MTE prctl

 tools/testing/selftests/arm64/mte/.gitignore  |   1 +
 .../testing/selftests/arm64/mte/check_prctl.c | 123 ++++++++++++++++++
 .../selftests/arm64/mte/mte_common_util.c     |  17 ++-
 .../selftests/arm64/mte/mte_common_util.h     |  15 ++-
 4 files changed, 151 insertions(+), 5 deletions(-)
 create mode 100644 tools/testing/selftests/arm64/mte/check_prctl.c


base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566

Comments

Mark Brown March 10, 2022, 3:37 p.m. UTC | #1 
On Thu, Mar 10, 2022 at 03:33:06PM +0000, Joey Gouly wrote:
> On Thu, Mar 10, 2022 at 02:43:35PM +0000, Mark Brown wrote:

> > +static bool system_has_mte;

> This looks unused (apart from being set in main()).

It is, it was used in the asymmetric bits of the test.
Shuah Khan March 10, 2022, 8:07 p.m. UTC | #2 
On 3/10/22 7:43 AM, Mark Brown wrote:
> The current tests use the prctls for various things but there's no
> coverage of the edges of the interface so add some basics. This isn't
> hugely useful as it is (it originally had some coverage for the
> combinations with asymmetric mode but we removed the prctl() for that)
> but it might be a helpful starting point for future work, for example
> covering error handling.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>   tools/testing/selftests/arm64/mte/.gitignore  |   1 +
>   .../testing/selftests/arm64/mte/check_prctl.c | 123 ++++++++++++++++++
>   2 files changed, 124 insertions(+)
>   create mode 100644 tools/testing/selftests/arm64/mte/check_prctl.c
> 

Looks good to me.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah