From patchwork Mon Apr 25 19:00:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yosry Ahmed X-Patchwork-Id: 565932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFC9C433EF for ; Mon, 25 Apr 2022 19:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244773AbiDYTEE (ORCPT ); Mon, 25 Apr 2022 15:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244785AbiDYTEC (ORCPT ); Mon, 25 Apr 2022 15:04:02 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8194B1A9B for ; Mon, 25 Apr 2022 12:00:50 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id s68-20020a637747000000b003aaff19b95bso3808943pgc.1 for ; Mon, 25 Apr 2022 12:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=u7aSCooaSdm5AbeQgc4mEIZKOx9WN8oAB22VArgUr9o=; b=SuyUCmC+8fnn1/O7RvexP4Bun5cSxBx1sd6O/1H7oKjQcRlUzBc7Bt5knel7INSyCT TE/6ByM9b+hsj1G0tr2mL+zLSAwDzapaydUgTsEV402eJbk6MFsRXuR2Zs7wSIl1kB3L kM1IJRVsDfkrGPtIyCOk2w0Dcm2Ui7PibJAyNe5F2X4o2o3XViG/Mb3Gb5qUL3O65dss oa10bPUcqXV571PY4lkn6ZsjfPx4Gr5+vTIcS9Ja1j6OtRizQTClkmTwHXynPTok2zix xUXMgzdz/Su53W1QXZRAn/l8NCJFbP5egoirBvhNqKzR/LvG2ktSdhYieYmOtOJnaE5h N+Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=u7aSCooaSdm5AbeQgc4mEIZKOx9WN8oAB22VArgUr9o=; b=jjg7tcJMbNxTo60qepqRdQQ8e+zKD1+SHsjojBcHvl17qeT8NEtgYHmENyU+Q2kiMg siPN3nrjN4AXtGneg1OCGLYEL8zjprZdpe5GAMg+Nv4Wr8mQVjWlCMbLVead6Ve1aUHx /4YQpSNNOkscCJwdEkLy6XHwrAKP9CjE1H0vnCP3AgCiNU3pf+Dv6kK8tX834mPdmJay s0uvlFdJwWx1pFqLeahAlhW0FA/2urvmJObBCgkkveJUW06y/xfvJgrqpWAOGXJ/3qec rRsSPUI9n3lLMs+oaEJlT+6hgRpmsqKtIfRugCBOL/U/J3vezNYKnWSQBnUQ5ne7b1Fd yXrw== X-Gm-Message-State: AOAM531AK8yf3cBGTKl89Kran5LYirBMuG8j+odjry5xC+6/QF0UmFUA 3Hd5YnB4gkhJM04QHrHvaYG923vaLrv9BGR5 X-Google-Smtp-Source: ABdhPJyC6Btrh9g9zSX3rXPfqbFSX9w9P0umwQPU2xZn6+TTPWH6+X7xS5z3iAFd4B9xmvUavECuvuXybuhg3bvR X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2327]) (user=yosryahmed job=sendgmr) by 2002:a17:90a:bb8f:b0:1d9:650e:10f5 with SMTP id v15-20020a17090abb8f00b001d9650e10f5mr8800254pjr.148.1650913250098; Mon, 25 Apr 2022 12:00:50 -0700 (PDT) Date: Mon, 25 Apr 2022 19:00:36 +0000 Message-Id: <20220425190040.2475377-1-yosryahmed@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog Subject: [PATCH v5 0/4] memcg: introduce per-memcg proactive reclaim From: Yosry Ahmed To: Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , Roman Gushchin Cc: David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , " =?utf-8?q?Michal_Koutn=C3=BD?= " , Tim Chen , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Yosry Ahmed Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org This patch series adds a memory.reclaim proactive reclaim interface. The rationale behind the interface and how it works are in the first patch. Acked-by: David Rientjes Acked-by: Roman Gushchin --- Changes in V5: - Fixed comment formating and added Co-developed-by in patch 1. - Modified selftest to work if swap is enabled or not, and retry multiple times to wait for background allocation before failing with a clear message. Changes in V4: mm/memcontrol.c: - Return -EINTR on signal_pending(). - On the final retry, drain percpu lru caches hoping that it might introduce some evictable pages for reclaim. - Simplified the retry loop as suggested by Dan Schatzberg. selftests: - Always return -errno on failure from cg_write() (whether open() or write() fail), also update cg_read() and read_text() to return -errno as well for consistency. Also make sure to correctly check that the whole buffer was written in cg_write(). - Added a maximum number of retries for the reclaim selftest. Changes in V3: - Fix cg_write() (in patch 2) to properly return -1 if open() fails and not fail if len == errno. - Remove debug printf() in patch 3. Changes in V2: - Add the interface to root as well. - Added a selftest. - Documented the interface as a nested-keyed interface, which makes adding optional arguments in the future easier (see doc updates in the first patch). - Modified the commit message to reflect changes and added a timeout argument as a suggested possible extension - Return -EAGAIN if the kernel fails to reclaim the full requested amount. --- Shakeel Butt (1): memcg: introduce per-memcg reclaim interface Yosry Ahmed (3): selftests: cgroup: return -errno from cg_read()/cg_write() on failure selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory selftests: cgroup: add a selftest for memory.reclaim Documentation/admin-guide/cgroup-v2.rst | 21 ++++ mm/memcontrol.c | 45 +++++++ tools/testing/selftests/cgroup/cgroup_util.c | 44 +++---- .../selftests/cgroup/test_memcontrol.c | 114 +++++++++++++++++- 4 files changed, 197 insertions(+), 27 deletions(-)