[12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE.

Message ID	20240214235307.10494-3-zfigura@codeweavers.com
State	New
Headers	show Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB26C1468FD; Wed, 14 Feb 2024 23:53:31 +0000 (UTC) From: Elizabeth Figura <zfigura@codeweavers.com> To: Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, wine-devel@winehq.org, =?utf-8?q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>, Wolfram Sang <wsa@kernel.org>, Arkadiusz Hiler <ahiler@codeweavers.com>, Peter Zijlstra <peterz@infradead.org>, Andy Lutomirski <luto@kernel.org>, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Elizabeth Figura <zfigura@codeweavers.com> Subject: [PATCH 12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE. Date: Wed, 14 Feb 2024 17:52:47 -0600 Message-ID: <20240214235307.10494-3-zfigura@codeweavers.com> In-Reply-To: <20240214235307.10494-1-zfigura@codeweavers.com> References: <20240214233645.9273-1-zfigura@codeweavers.com> <20240214235307.10494-1-zfigura@codeweavers.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	NT synchronization primitive driver \| expand [00/31] NT synchronization primitive driver [01/31] ntsync: Introduce the ntsync driver and character device. [02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM. [03/31] ntsync: Introduce NTSYNC_IOC_SEM_POST. [04/31] ntsync: Introduce NTSYNC_IOC_WAIT_ANY. [05/31] ntsync: Introduce NTSYNC_IOC_WAIT_ALL. [06/31] ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX. [07/31] ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK. [08/31] ntsync: Introduce NTSYNC_IOC_MUTEX_KILL. [09/31] ntsync: Introduce NTSYNC_IOC_CREATE_EVENT. [10/31] ntsync: Introduce NTSYNC_IOC_EVENT_SET. [11/31] ntsync: Introduce NTSYNC_IOC_EVENT_RESET. [12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE. [13/31] ntsync: Introduce NTSYNC_IOC_SEM_READ. [14/31] ntsync: Introduce NTSYNC_IOC_MUTEX_READ. [15/31] ntsync: Introduce NTSYNC_IOC_EVENT_READ. [16/31] ntsync: Introduce alertable waits. [17/31] ntsync: Allow waits to use the REALTIME clock. [18/31] selftests: ntsync: Add some tests for semaphore state. [19/31] selftests: ntsync: Add some tests for mutex state. [20/31] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY. [21/31] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL. [22/31] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY. [23/31] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL. [24/31] selftests: ntsync: Add some tests for manual-reset event state. [25/31] selftests: ntsync: Add some tests for auto-reset event state. [26/31] selftests: ntsync: Add some tests for wakeup signaling with events. [27/31] selftests: ntsync: Add tests for alertable waits. [28/31] selftests: ntsync: Add some tests for wakeup signaling via alerts. [29/31] selftests: ntsync: Add a stress test for contended waits. [30/31] maintainers: Add an entry for ntsync. [31/31] docs: ntsync: Add documentation for the ntsync uAPI.

Message ID

20240214235307.10494-3-zfigura@codeweavers.com

State

New

Headers

From: Elizabeth Figura <zfigura@codeweavers.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
 wine-devel@winehq.org,
 =?utf-8?q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>,
 Wolfram Sang <wsa@kernel.org>, Arkadiusz Hiler <ahiler@codeweavers.com>,
 Peter Zijlstra <peterz@infradead.org>, Andy Lutomirski <luto@kernel.org>,
 linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
 Elizabeth Figura <zfigura@codeweavers.com>
Subject: [PATCH 12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE.
Date: Wed, 14 Feb 2024 17:52:47 -0600
Message-ID: <20240214235307.10494-3-zfigura@codeweavers.com>
In-Reply-To: <20240214235307.10494-1-zfigura@codeweavers.com>
References: <20240214233645.9273-1-zfigura@codeweavers.com>
 <20240214235307.10494-1-zfigura@codeweavers.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

NT synchronization primitive driver | expand

Commit Message

Elizabeth Figura Feb. 14, 2024, 11:52 p.m. UTC

This corresponds to the NT syscall NtPulseEvent().

This wakes up any waiters as if the event had been set, but does not set the
event, instead resetting it if it had been signalled. Thus, for a manual-reset
event, all waiters are woken, whereas for an auto-reset event, at most one
waiter is woken.

Signed-off-by: Elizabeth Figura <zfigura@codeweavers.com>
---
 drivers/misc/ntsync.c       | 10 ++++++++--
 include/uapi/linux/ntsync.h |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
index 57d78b086241..e8e58274e4e8 100644
--- a/drivers/misc/ntsync.c
+++ b/drivers/misc/ntsync.c
@@ -456,7 +456,7 @@  static int ntsync_mutex_kill(struct ntsync_obj *mutex, void __user *argp)
 	return ret;
 }
 
-static int ntsync_event_set(struct ntsync_obj *event, void __user *argp)
+static int ntsync_event_set(struct ntsync_obj *event, void __user *argp, bool pulse)
 {
 	struct ntsync_device *dev = event->dev;
 	__u32 prev_state;
@@ -472,6 +472,8 @@  static int ntsync_event_set(struct ntsync_obj *event, void __user *argp)
 		event->u.event.signaled = true;
 		try_wake_all_obj(dev, event);
 		try_wake_any_event(event);
+		if (pulse)
+			event->u.event.signaled = false;
 
 		spin_unlock(&event->lock);
 		spin_unlock(&dev->wait_all_lock);
@@ -481,6 +483,8 @@  static int ntsync_event_set(struct ntsync_obj *event, void __user *argp)
 		prev_state = event->u.event.signaled;
 		event->u.event.signaled = true;
 		try_wake_any_event(event);
+		if (pulse)
+			event->u.event.signaled = false;
 
 		spin_unlock(&event->lock);
 	}
@@ -535,9 +539,11 @@  static long ntsync_obj_ioctl(struct file *file, unsigned int cmd,
 	case NTSYNC_IOC_MUTEX_KILL:
 		return ntsync_mutex_kill(obj, argp);
 	case NTSYNC_IOC_EVENT_SET:
-		return ntsync_event_set(obj, argp);
+		return ntsync_event_set(obj, argp, false);
 	case NTSYNC_IOC_EVENT_RESET:
 		return ntsync_event_reset(obj, argp);
+	case NTSYNC_IOC_EVENT_PULSE:
+		return ntsync_event_set(obj, argp, true);
 	default:
 		return -ENOIOCTLCMD;
 	}
diff --git a/include/uapi/linux/ntsync.h b/include/uapi/linux/ntsync.h
index f2d7507d8438..598f894f868d 100644
--- a/include/uapi/linux/ntsync.h
+++ b/include/uapi/linux/ntsync.h
@@ -50,5 +50,6 @@  struct ntsync_wait_args {
 #define NTSYNC_IOC_MUTEX_KILL		_IOW ('N', 0x86, __u32)
 #define NTSYNC_IOC_EVENT_SET		_IOR ('N', 0x88, __u32)
 #define NTSYNC_IOC_EVENT_RESET		_IOR ('N', 0x89, __u32)
+#define NTSYNC_IOC_EVENT_PULSE		_IOR ('N', 0x8a, __u32)
 
 #endif

[12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE.

Commit Message

Patch