From patchwork Thu Feb 13 11:19:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 864974 Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8088721D3C0; Thu, 13 Feb 2025 11:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739445569; cv=none; b=d+kcjshSYSZ9b/gBLEHpgOlcrjrnrhhQYYfm4kqX56BgodGtVZFouxPbbKs9BLrbj/1zP1p272BRJyOnC5BPHoiG1+cUkTzkLRQ7P4gHMiinoGYKRXkn16hSCBffdgrAuAg6Iqr/1xvh54+XFq8yTpwz2wConbXvEx9NLPz+/uI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739445569; c=relaxed/simple; bh=JdIo+E+SDO2PpXqGE31iS5BduX/7fzUOoJLxV9EOoIs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PCBhRROZDEnTirPpgKCT8Eft/Mz+I/2SeLSn7pS3IOgjJqM85+SyEUIHJ9V2JUadBG0FayEo9LaNIXVVJ42Vgbtl6sGZJgvb/LwyfCf2JM+utKo0rmcKpPmxfwWh07vO84JIOMeYzJ0044Kg67CiWlZhUU8gNOg7+du+gXn4TQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=D7rFTfN/; arc=none smtp.client-ip=212.227.15.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="D7rFTfN/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1739445565; x=1740050365; i=ps.report@gmx.net; bh=JdIo+E+SDO2PpXqGE31iS5BduX/7fzUOoJLxV9EOoIs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=D7rFTfN/YKkRmt9Fj/2eYQEEJUzBb0H7a2/8prAvepjJo6sX/77qQj4Yza5E6Uu6 zglQvGQPi8+UNbKT7TDA96Zt5OixAtVR3ZCUTI0OQY91Ab8ZMEgt2HoQzfH74i2SK WJqLUZvLVreTf6hG5BWe4C6xtxUsQdApKVjJgq+DnQy+aq22nA5oSS1TX7k4bO607 6u2R9BZ4Yj12YQzy0LOocT4gGmmnmziw7JCpi+2UNALUF1YVqXNouvHRWSfFTs6y8 Vb7vsw0tfcs4MWQOpQurl83VqcPggB+bqgz4fWolWE28zPHGptESsQ5gGENrbY/Qu cHcx9u/er/XVyz92ug== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.197]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQvCv-1u3cV82hRn-00IDQ4; Thu, 13 Feb 2025 12:19:25 +0100 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Peter Seiderer , Thomas Gleixner , Artem Chernyshev , Nam Cao , Frederic Weisbecker Subject: [PATCH net-next v5 2/8] net: pktgen: remove extra tmp variable (re-use len instead) Date: Thu, 13 Feb 2025 12:19:14 +0100 Message-ID: <20250213111920.1439021-3-ps.report@gmx.net> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250213111920.1439021-1-ps.report@gmx.net> References: <20250213111920.1439021-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:H/PhhsIqx8cvF9Ak2WsVYrmclqrSpkz9+min1pgZUT1xDT4qsQH 7xMtbPuTOVWzdAQ3TWmIIJb6XkD7zBQ6+0DSYwTB5OBZ5FlmFyEquGy5fGwn5zbnMa9YASr oNC/Y2RLuxBhKDdlVxZnYr5Zd0yALIBnJGoEhm5llBBdUacpZhdtHVevY28af2ESxip12ay KF/dflynkBTKpH2iQ/7Lw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HjEOTSD51mo=;X8dO7O9PvvITsu6aujW8bHs2GWS 65Q+Zux3IQizWR0aRLcld2+IXXhzFgLmdOasekr9AhfBXd56FWPIjXoyV+9OnDc/rZ610qJ50 ljK8iF2xfVwwJ02saDABPkOnnYMlnLzlfUWt5QUZg/CzGhXBt0JX0ESO3t6uMyXij8W2R+Wt8 Naj36fEdGivrzF7wyKsQ/QU0atgTHcFuZEeVNvvyUwxosVi6pCQNzVjQwji1vcnCcOLpTe60c MC6fVibx70xtY/3fnVCXnB452Sq1m2FS5kpkwH9lTFIH5qw3T4CeTXObPCR52ZUhQiTa3bWEJ X5Ui/i4lghrEfIhGJUHUCsZQSd5/u7diwMl60E69yx156CvhcsXxCwEJMINNdU1wyquoGjtRp f/wZkkofAsYVwQy9IDMeADyHPEbtqq0zFGeBmdFORqWFAMOP8VClO1VEBlT9HgMxavZJpFeD4 6X9A2Hh1E9bYAzXku/JBtBPgjPcLtx3fuWH/fJg7bCW3RpB4Go4h0p3BavfkWUMsRNVq/GbYb d+VoN44TlIAGwvEhpLLtlhm44KCee/ORkFV1kRBCRwUGbQgfcdHeqjm8DKVjVqTFuFtjltGPc RDTKleOIAXD/uWFkZ+VTcWpWAOmo5kUQfds2dLcU2fBceRyeas8UPOJqexNrnOCGBNAU3DBsW r4fGpZqnxgUDlgkR+T+a2fjZWsoQL+jMRRaeKr/XJfywk5F6pjmClZPaO7z66UhN86FmuwNMg 2UuE+B8e5RCZaemH+R/eed18ihG38tYkPU0UbqTe7HjglmP/zzY81jG09W3voHQkgPMfGC3M6 nEfAcDAIogiJvm2+oeOlrU/np4GUEhB34jhdWNrtrKURzfa/1lXpf9XmUkLL68mhFRN1dl9o4 q9IfKWpv/Am1yhcKjKDMoQ/v5Y7E9PuCNKqY0vnGxsYrrjHWPFZ4mBLvyalJrhI4lXmsrlomG ++cmIerPapHQPQGHaNf0CvrRKSo7oVYrmvjghsAnQsEsSinq2YJy9h775TaNhhuK0ne7dYRQh 9RwN7CaeF9wCYlN8640XNrFZTfc8FwjrqRYW7FchJZBCXKq5gdvBsclIX4o6Iza/IVjfKiHAh gYvqT3pwxtU8KSZ1uPz7fq4TdtZa0k0foF1fmZx2G23w5WdZeF3BPh38sbxcQy0CndCIUZI3Z GwkVQpoOKbXp3XCfq3e0IYogS4HdSxGT/BOPZxpqACNCTbMLtOF0rbK0vzwT9YcvMhhXld5u2 G0gN3mGrDVFpgPJJ+MaQR/rjOstS/hCIb+X3IvEGj0bsjqbg/qyn5UDHbmyUpYr6iq7RITY08 7sxzdG5LUb9VTLk8ooULdX1mKhWFyXQbKjin5YgftbHqInSsIAm6mPDXNBGFHcfvdcF+98tap G0FXZqc+dv8uLbJCQACQ/PrELA54GO3m/dvT19gzDsvMdI3dYUtxlLI/mz Remove extra tmp variable in pktgen_if_write (re-use len instead). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v4 -> v5 - split up patchset into part i/ii (suggested by Simon Horman) - add rev-by Simon Horman Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()') --- net/core/pktgen.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 36ee0422c6cc..b9d8e33abe1e 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -970,7 +970,6 @@ static ssize_t pktgen_if_write(struct file *file, char name[16], valstr[32]; unsigned long value = 0; char *pg_result = NULL; - int tmp = 0; char buf[128]; pg_result = &(pkt_dev->result[0]); @@ -981,12 +980,12 @@ static ssize_t pktgen_if_write(struct file *file, } max = count; - tmp = count_trail_chars(user_buffer, max); - if (tmp < 0) { + len = count_trail_chars(user_buffer, max); + if (len < 0) { pr_warn("illegal format\n"); - return tmp; + return len; } - i = tmp; + i = len; /* Read variable name */