| Message ID | 20250429113242.998312-23-vschneid@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | context_tracking,x86: Defer some IPIs until a user->kernel transition | expand |
On 4/29/25 13:32, Valentin Schneider wrote: > The text_size bit referred to by the comment has been removed as of commit > > ac3b43283923 ("module: replace module_layout with module_memory") > > and is thus no longer relevant. Remove it and comment about the contents of > the masks array instead. > > Signed-off-by: Valentin Schneider <vschneid@redhat.com> This comment cleanup is independent of the rest of the series. I've picked it separately on modules-next.
diff --git a/kernel/module/main.c b/kernel/module/main.c index a2859dc3eea66..b9f010daaa4c7 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -1562,12 +1562,11 @@ static void __layout_sections(struct module *mod, struct load_info *info, bool i { unsigned int m, i; + /* + * { Mask of required section header flags, + * Mask of excluded section header flags } + */ static const unsigned long masks[][2] = { - /* - * NOTE: all executable code must be the first section - * in this array; otherwise modify the text_size - * finder in the two loops below - */ { SHF_EXECINSTR | SHF_ALLOC, ARCH_SHF_SMALL }, { SHF_ALLOC, SHF_WRITE | ARCH_SHF_SMALL }, { SHF_RO_AFTER_INIT | SHF_ALLOC, ARCH_SHF_SMALL },
The text_size bit referred to by the comment has been removed as of commit ac3b43283923 ("module: replace module_layout with module_memory") and is thus no longer relevant. Remove it and comment about the contents of the masks array instead. Signed-off-by: Valentin Schneider <vschneid@redhat.com> --- kernel/module/main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)