From patchwork Fri May 30 04:50:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akihiko Odaki X-Patchwork-Id: 893956 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91367221F24 for ; Fri, 30 May 2025 04:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748580667; cv=none; b=qYEcV0Eq7/I8j3nnIhvxzvslt0Y3UokJdpEjVPsmL8VS4J26u8MaJsQooHlF/OOaQiH1WjetTzU5zCLFqjK40z1vTOxeX6IN8R0ObL1C4zbJor34aWqQOdfJh18rxPX2llMkM3wir/6fcmkJ6usTFX5inr1OAAe8eooA4tuf2Ow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748580667; c=relaxed/simple; bh=8QZ3Y17huIwvFuKYxGqjjNV9gzRi3SV/EMTE+e4j/s4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To; b=bNRmxMWKZQeszhalMLSMIRBuv6NUILVKcaCR8dP4MGgZI0qYRo3fwwVa+Kx8p8E+VNaor3lXfZ7YVeTWrZU3gKbrK6AQXs+S7j5RAz17dgsI0pFMLT2kM7MzWowcz3jA85xszmzww0/eATBu/cKdKAmBS9vnRtRmXY/Nal+YHNs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=qxK5LkC2; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="qxK5LkC2" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-742c73f82dfso1252169b3a.2 for ; Thu, 29 May 2025 21:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1748580665; x=1749185465; darn=vger.kernel.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6kg49tLaS0z1IHYonGafIguL3mgiSEk4xR/nFylD2io=; b=qxK5LkC2DVB0dYvE/5pN+icN9wP4bhzrrBuDTB69R2C0vaEqqECOq08QDZZdixunwy ravpjfFDJsy0E9EXEezXCMzeISk1PXqmD78evKIkZgildwI6t7XrYoXG1KGGM6FUBQcR 2Td1OlJGf+YKouksaSeFP/kYW4rUFoWKy+AKRxU/+7U7/c6nVp1/ZKCcF0fiUJQfBNmj +UWyOXN1/oVXIn11kiEmFie8JOUFJ1p+x/+kYhJLtRPnFKtLOddyRQ/5m1489PvhzeCj c6PemcxaIzKBn4Hla9hhHmS7AfLmmNSDWiHc8NCTcOA3H8MPx1/fIkFdZgz4SB6rQain tyCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748580665; x=1749185465; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6kg49tLaS0z1IHYonGafIguL3mgiSEk4xR/nFylD2io=; b=uPaTuD9SwgOaxi7eFXM0bq2Z4faWHFsebwHb+4bBJW3u40DDiIbPZLLky2kvgYNOw2 HqASK6iOc3rCCI6dzRvyHGsyRvAEIfeExX3FIajFZCKFgEIi3UGs2nNG6FCwU+WDcIHr O0D0yNPLXuc+7i9JSezc9pxQctXkUo8RSdTEdcGeC7Tqwoi0GIWkT/2Mk0KFM1zprVXX 2ubALGIKpKVmzaBp2QOjRMyYxtwzivYhn81VbivgOh5KFKRsy0pm69UHjPEe/yPeolFc N0T8qyKzTenC9v/3KSCW6cVgEEvSpa5Qq46Bdmx8hgmaL+1bjmMLl49WcHjivTb1zYVj d+Lg== X-Forwarded-Encrypted: i=1; AJvYcCUxdoLRmW9hCPY/kmzlGyXUZY3MMf0d37IJLqPDWDzPr1Mxcf5iFHOWPzIgGoIxFrXHe+tfix7/t0SGae8VgM4=@vger.kernel.org X-Gm-Message-State: AOJu0YwHduO2c63HhXf6rGhZKTiTsuW+3A9a65LFVJmsACiuGejs32d+ Gn5cHznQSXoKj/belANdiiB5FqNEoY6MQYn2/qSMsBBCnI0UtCuIkNdmOxG+ymfdcLc= X-Gm-Gg: ASbGncvJWCzV5thjSZLwThf/33X1Vs4uiqByM02/1SuHRYFgZGTW5bwe7CsxVRecqND rgM1gpz1mq3tW5zxNKf7WeN7gEmRtQvlLc6UhE4cGUPEwUefcQe41rwXAY1tH7aX0HFzdV4Etet BsDPl1h2uI+h5fgpSdqJ7/8P8aAFYQCAyNy6/FZqpcc/DsiMTLBLNN6GHvUwxpCIPnzw94oUEmI NRX22zBFuV7rn0ApnkmIMmVSoKG5ZdBMDHwP4uOsFsuLzl0ODQv7dxmEQ+zhkCVBmcm2MzvDpOi BhffdC84YhcOr75K9W4uqEVkpzavWfGUb1qV1I8UXctCwkVj15p93QCDvoCcG1g= X-Google-Smtp-Source: AGHT+IH9+BHJNIoXbgVGyUoI7SrCOCtJTbLtcbCTAW+31fagg/7EMzO3Z6Fm63/CoKEr+0ydoICMHQ== X-Received: by 2002:a05:6a00:2389:b0:740:9abe:4d94 with SMTP id d2e1a72fcca58-747bda192e1mr2706018b3a.21.1748580664899; Thu, 29 May 2025 21:51:04 -0700 (PDT) Received: from localhost ([157.82.128.1]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-747afff71eesm2159761b3a.159.2025.05.29.21.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 May 2025 21:51:04 -0700 (PDT) From: Akihiko Odaki Date: Fri, 30 May 2025 13:50:13 +0900 Subject: [PATCH net-next v12 09/10] selftest: tap: Add tests for virtio-net ioctls Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250530-rss-v12-9-95d8b348de91@daynix.com> References: <20250530-rss-v12-0-95d8b348de91@daynix.com> In-Reply-To: <20250530-rss-v12-0-95d8b348de91@daynix.com> To: Jonathan Corbet , Willem de Bruijn , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , Xuan Zhuo , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, Yuri Benditovich , Andrew Melnychenko , Stephen Hemminger , gur.stavi@huawei.com, Lei Yang , Simon Horman , Akihiko Odaki X-Mailer: b4 0.15-dev-edae6 They only test the ioctls are wired up to the implementation common with tun as it is already tested for tun. Signed-off-by: Akihiko Odaki --- tools/testing/selftests/net/config | 1 + tools/testing/selftests/net/tap.c | 131 ++++++++++++++++++++++++++++++++++++- 2 files changed, 129 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index 61e5116987f3..00cb1e65b392 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -99,6 +99,7 @@ CONFIG_IPV6_IOAM6_LWTUNNEL=y CONFIG_CRYPTO_SM4_GENERIC=y CONFIG_AMT=m CONFIG_TUN=y +CONFIG_TUN_VNET_CROSS_LE=y CONFIG_VXLAN=m CONFIG_IP_SCTP=m CONFIG_NETFILTER_XT_MATCH_POLICY=m diff --git a/tools/testing/selftests/net/tap.c b/tools/testing/selftests/net/tap.c index 247c3b3ac1c9..0decbc338965 100644 --- a/tools/testing/selftests/net/tap.c +++ b/tools/testing/selftests/net/tap.c @@ -387,9 +387,6 @@ FIXTURE_TEARDOWN(tap) if (self->fd != -1) close(self->fd); - ret = dev_delete(param_dev_tap_name); - EXPECT_EQ(ret, 0); - ret = dev_delete(param_dev_dummy_name); EXPECT_EQ(ret, 0); } @@ -431,4 +428,132 @@ TEST_F(tap, test_packet_crash_tap_invalid_eth_proto) ASSERT_EQ(errno, EINVAL); } +TEST_F(tap, test_vnethdrsz) +{ + int sz = sizeof(struct virtio_net_hdr_v1_hash); + + ASSERT_FALSE(dev_delete(param_dev_tap_name)); + + ASSERT_FALSE(ioctl(self->fd, TUNSETVNETHDRSZ, &sz)); + sz = 0; + ASSERT_FALSE(ioctl(self->fd, TUNGETVNETHDRSZ, &sz)); + EXPECT_EQ(sizeof(struct virtio_net_hdr_v1_hash), sz); +} + +TEST_F(tap, test_vnetle) +{ + int le = 1; + + ASSERT_FALSE(dev_delete(param_dev_tap_name)); + + ASSERT_FALSE(ioctl(self->fd, TUNSETVNETLE, &le)); + le = 0; + ASSERT_FALSE(ioctl(self->fd, TUNGETVNETLE, &le)); + EXPECT_EQ(1, le); +} + +TEST_F(tap, test_vnetbe) +{ + int be = 1; + int ret; + + ASSERT_FALSE(dev_delete(param_dev_tap_name)); + + ret = ioctl(self->fd, TUNSETVNETBE, &be); + if (ret == -1 && errno == EINVAL) + SKIP(return, "TUNSETVNETBE not supported"); + + ASSERT_FALSE(ret); + be = 0; + ASSERT_FALSE(ioctl(self->fd, TUNGETVNETBE, &be)); + EXPECT_EQ(1, be); +} + +TEST_F(tap, test_getvnethashtypes) +{ + uint32_t hash_types; + int ret; + + ASSERT_FALSE(dev_delete(param_dev_tap_name)); + + ret = ioctl(self->fd, TUNGETVNETHASHTYPES, &hash_types); + if (ret == -1 && errno == EINVAL) + SKIP(return, "TUNGETVNETHASHTYPES not supported"); + + EXPECT_FALSE(ret); +} + +FIXTURE(tap_setvnethash) +{ + int fd; +}; + +FIXTURE_VARIANT(tap_setvnethash) +{ + unsigned int cmd; +}; + +FIXTURE_VARIANT_ADD(tap_setvnethash, reportingautomq) +{ + .cmd = TUNSETVNETREPORTINGAUTOMQ +}; + +FIXTURE_VARIANT_ADD(tap_setvnethash, reportingrss) +{ + .cmd = TUNSETVNETREPORTINGRSS +}; + +FIXTURE_VARIANT_ADD(tap_setvnethash, rss) +{ + .cmd = TUNSETVNETRSS +}; + +FIXTURE_SETUP(tap_setvnethash) +{ + int ret; + + ret = dev_create(param_dev_dummy_name, "dummy", NULL, NULL); + ASSERT_FALSE(ret); + + ret = dev_create(param_dev_tap_name, "macvtap", macvtap_fill_rtattr, + NULL); + ASSERT_FALSE(ret) + EXPECT_FALSE(dev_delete(param_dev_dummy_name)); + + self->fd = opentap(param_dev_tap_name); + ASSERT_LT(0, self->fd) + EXPECT_FALSE(dev_delete(param_dev_dummy_name)); +} + +FIXTURE_TEARDOWN(tap_setvnethash) +{ + EXPECT_FALSE(close(self->fd)); + EXPECT_FALSE(dev_delete(param_dev_dummy_name)); +} + +TEST_F(tap_setvnethash, test_alive) +{ + struct tun_vnet_rss rss = { .hash_types = 0 }; + int ret; + + ret = ioctl(self->fd, variant->cmd, &rss); + + if (ret == -1 && errno == EINVAL) + SKIP(return, "not supported"); + + EXPECT_FALSE(ret); +} + +TEST_F(tap_setvnethash, test_deleted) +{ + ASSERT_FALSE(dev_delete(param_dev_tap_name)); + + ASSERT_EQ(-1, ioctl(self->fd, variant->cmd)); + + if (errno == EINVAL) + SKIP(return, "not supported"); + + EXPECT_EQ(EBADFD, errno); +} + TEST_HARNESS_MAIN