| Message ID | 20201015044443.1828-1-thunder.leizhen@huawei.com |
|---|---|
| Headers | show |
| Series | fix all errors except one reported by dt_binding_check | expand |
Hi Zhen, Thanks for your patch! On Thu, Oct 15, 2020 at 6:52 AM Zhen Lei <thunder.leizhen@huawei.com> wrote: > The definition "gpio_suffixes[] = { "gpios", "gpio" }" shows that both > property names "cmd-gpios" and "cmd-gpio" are supported. But currently > only "cmd-gpios" is allowed in this yaml, and the name used in > mmp2-olpc-xo-1-75.dts is cmd-gpio. As a result, the following errors is > reported. > > slave: 'cmd-gpios' is a required property > slave: 'cmd-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > index b3c45c046ba5e37..dd549380a085709 100644 > --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > @@ -24,15 +24,21 @@ properties: > compatible: > const: olpc,xo1.75-ec > > - cmd-gpios: > + spi-cpha: true > + > +patternProperties: > + "^cmd-gpio[s]?$": > description: GPIO uspecifier of the CMD pin > maxItems: 1 In general, the *-gpio form is deprecated. So why complicate the DT bindings by adding support for deprecated properties? 1. Explicitly allowing deprecated properties means new users may be added, 2. Once all in-tree DTS files are converted, the warnings will be gone anyway, 3. Out-of-tree DTB will still work, as it's very unlikely support for the "gpio" suffix can/will be dropped anytime soon, 4. If anyone runs the validator on out-of-tree DTS files, the most probable intention is to fix any detected issues anyway, and the files can be updated, too, 5. If any out-of-tree code or tooling relies on the *-gpio form, it may already be broken. > - spi-cpha: true > - > required: > - compatible > - - cmd-gpios > + > +oneOf: > + - required: > + - cmd-gpio > + - required: > + - cmd-gpios > > additionalProperties: false Gr{oetje,eeting}s, Geert
On 2020/10/15 15:01, Geert Uytterhoeven wrote: > Hi Zhen, > > Thanks for your patch! > > On Thu, Oct 15, 2020 at 6:52 AM Zhen Lei <thunder.leizhen@huawei.com> wrote: >> The definition "gpio_suffixes[] = { "gpios", "gpio" }" shows that both >> property names "cmd-gpios" and "cmd-gpio" are supported. But currently >> only "cmd-gpios" is allowed in this yaml, and the name used in >> mmp2-olpc-xo-1-75.dts is cmd-gpio. As a result, the following errors is >> reported. >> >> slave: 'cmd-gpios' is a required property >> slave: 'cmd-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> --- >> Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml >> index b3c45c046ba5e37..dd549380a085709 100644 >> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml >> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml >> @@ -24,15 +24,21 @@ properties: >> compatible: >> const: olpc,xo1.75-ec >> >> - cmd-gpios: >> + spi-cpha: true >> + >> +patternProperties: >> + "^cmd-gpio[s]?$": >> description: GPIO uspecifier of the CMD pin >> maxItems: 1 > > In general, the *-gpio form is deprecated. So why complicate the DT > bindings by adding support for deprecated properties? I just don't know this information. So this patch can be ignored. > > 1. Explicitly allowing deprecated properties means new users may be > added, > 2. Once all in-tree DTS files are converted, the warnings will be gone > anyway, > 3. Out-of-tree DTB will still work, as it's very unlikely support for > the "gpio" suffix can/will be dropped anytime soon, > 4. If anyone runs the validator on out-of-tree DTS files, the most > probable intention is to fix any detected issues anyway, and the > files can be updated, too, > 5. If any out-of-tree code or tooling relies on the *-gpio form, it > may already be broken. > >> - spi-cpha: true >> - >> required: >> - compatible >> - - cmd-gpios >> + >> +oneOf: >> + - required: >> + - cmd-gpio >> + - required: >> + - cmd-gpios >> >> additionalProperties: false > > Gr{oetje,eeting}s, > > Geert >
v1 --> v2: 1. I'm sorry. I'm not familiar with the GPIO driver, which leads to a low-level mistake. Now, I rewrite the patch 6/6 in v1. For more detail, please refer: https://lore.kernel.org/linux-arm-kernel/49b680f8-d7d7-8ea3-894c-73cbfacc5ba4@huawei.com/T/#u v1: When people add multiple or common YAML files, they usually perform a full dt_binding_check. Unfortunately, some YAML files cannot pass the self-check. The errors or warning are listed below. It is necessary to eliminate them, so that people's time and energy are not wasted every time when execute comprehensive dt_binding_check. This error is fixed by Patch 1: /root/leizhen/linux-next/Documentation/devicetree/bindings/leds/leds-lp55xx.example.dt.yaml: led-controller@33: multi-led@2:color:0:0: 9 is greater than the maximum of 8 From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml These errors are fixed by Patch 2: /root/leizhen/linux-next/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.example.dt.yaml: ec@0: 'typec' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml /root/leizhen/linux-next/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.example.dt.yaml: cros-ec@0: 'extcon0', 'extcon1' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml /root/leizhen/linux-next/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.example.dt.yaml: cros-ec@0: 'ec-pwm' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml /root/leizhen/linux-next/Documentation/devicetree/bindings/regulator/google,cros-ec-regulator.example.dt.yaml: ec@0: '#address-cells', '#size-cells', 'regulator@0' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml /root/leizhen/linux-next/Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dt.yaml: cros-ec@0: '#address-cells', '#size-cells', 'ec-codec@10500000' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml These errors are fixed by Patch 3 and 4: Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.example.dts:21.13-30.11: Warning (spi_bus_bridge): /example-0/spi: incorrect #address-cells for SPI bus Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.example.dts:21.13-30.11: Warning (spi_bus_bridge): /example-0/spi: incorrect #size-cells for SPI bus Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' Patch 5 and 6 fix the dtbs_check errors detected by Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' /root/leizhen/linux-next/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: slave: 'cmd-gpios' is a required property From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml /root/leizhen/linux-next/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: slave: 'cmd-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /root/leizhen/linux-next/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml I have no good idea for this one, so leave it. Documentation/devicetree/bindings/pci/xilinx-versal-cpm.example.dts:43.62-47.30: Warning (pci_device_reg): /example-0/versal/pcie@fca10000/interrupt-controller: missing PCI reg property Zhen Lei (1): dt-bindings: misc: add support for both property names cmd-gpios and cmd-gpio Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)