| Message ID | 20230427001541.18704-1-ansuelsmth@gmail.com |
|---|---|
| Headers | show |
| Series | leds: introduce new LED hw control APIs | expand |
Hi Christian, On Thu, Apr 27, 2023 at 02:15:30AM +0200, Christian Marangi wrote: > This is a continue of [1]. It was decided to take a more gradual > approach to implement LEDs support for switch and phy starting with > basic support and then implementing the hw control part when we have all > the prereq done. I tried to apply this series to give it a try. To what tree should this series be applied upon? > [1] https://lore.kernel.org/lkml/20230216013230.22978-1-ansuelsmth@gmail.com/ > > Changes from previous v8 series: > - Rewrite Documentation from scratch and move to separate commit > - Strip additional trigger modes (to propose in a different series) > - Strip from qca8k driver additional modes (to implement in the different > series) > - Split the netdev chages to smaller piece to permit easier review The changelog reads as if it should be applied instead of v8, but this series doesn't apply on a vanilla kernel. For example, TRIGGER_NETDEV_TX is moved around in this series, but not present in vanilla Linux. Sascha
On Mon, May 08, 2023 at 02:25:14PM +0200, Sascha Hauer wrote: > Hi Christian, > > On Thu, Apr 27, 2023 at 02:15:30AM +0200, Christian Marangi wrote: > > This is a continue of [1]. It was decided to take a more gradual > > approach to implement LEDs support for switch and phy starting with > > basic support and then implementing the hw control part when we have all > > the prereq done. > > I tried to apply this series to give it a try. To what tree should this > series be applied upon? > Hi, since this feature affect multiple branch, the prereq of this branch are still not in linux-next. (the prereq series got accepted but still has to be merged) Lee created a branch. We are waiting for RC stage to request a stable branch so we can reference ti to correctly test this. Anyway you should be able to apply this series on top of this branch [1] Consider that a v2 is almost ready with some crucial changes that should improve the implementation. (so if you are planning on adding support for other device I advice to check also v2, just an additional ops to implement) [1] https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/log/?h=for-leds-next-next [2] https://github.com/Ansuel/linux/commits/leds-offload-support-reduced > > [1] https://lore.kernel.org/lkml/20230216013230.22978-1-ansuelsmth@gmail.com/ > > > > Changes from previous v8 series: > > - Rewrite Documentation from scratch and move to separate commit > > - Strip additional trigger modes (to propose in a different series) > > - Strip from qca8k driver additional modes (to implement in the different > > series) > > - Split the netdev chages to smaller piece to permit easier review > > The changelog reads as if it should be applied instead of v8, but this > series doesn't apply on a vanilla kernel. For example, TRIGGER_NETDEV_TX > is moved around in this series, but not present in vanilla Linux. > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On Mon, May 08, 2023 at 02:33:25PM +0200, Christian Marangi wrote: > On Mon, May 08, 2023 at 02:25:14PM +0200, Sascha Hauer wrote: > > Hi Christian, > > > > On Thu, Apr 27, 2023 at 02:15:30AM +0200, Christian Marangi wrote: > > > This is a continue of [1]. It was decided to take a more gradual > > > approach to implement LEDs support for switch and phy starting with > > > basic support and then implementing the hw control part when we have all > > > the prereq done. > > > > I tried to apply this series to give it a try. To what tree should this > > series be applied upon? > > > > Hi, > since this feature affect multiple branch, the prereq of this branch are > still not in linux-next. (the prereq series got accepted but still has > to be merged) > > Lee created a branch. Ok, this explains it, thanks. > > We are waiting for RC stage to request a stable branch so we can > reference ti to correctly test this. > > Anyway you should be able to apply this series on top of this branch [1] > > Consider that a v2 is almost ready with some crucial changes that should > improve the implementation. (so if you are planning on adding support > for other device I advice to check also v2, just an additional ops to > implement) I'll wait for v2 then. My ultimate goal is to implement LED trigger support for the DP83867 phy. It would be great if you could Cc me on v2 so I get a trigger once it's out. Thanks for working on this topic. It pops up here every once in a while and it would be good to get it solved. Sascha
> I'll wait for v2 then. My ultimate goal is to implement LED trigger support > for the DP83867 phy. It would be great if you could Cc me on v2 so I get > a trigger once it's out. Hi Sascha Full hardware offload is going to take a few patch sets. The v2 to be posted soon gives basic support. It is will be missing linking the PHY LED to the netdev. We have patches for that. And then there is a DT binding, which again we have patches for. It could also be my Marvell PHY patches are a separate series. You might want those to get an example for your DP83867 work. I'm hoping we can move faster than last cycles, there is less LED and more networking, so we might be closer to 3 day review cycles than 2 weeks. Andrew
This is a continue of [1]. It was decided to take a more gradual approach to implement LEDs support for switch and phy starting with basic support and then implementing the hw control part when we have all the prereq done. This is the main part of the series, the one that actually implement the hw control API. Some history about this feature and why ======================================= This proposal is highly requested by the entire net community but the API is not strictly designed for net usage but for a more generic usage. Initial version were very flexible and designed to try to support every aspect of the LED driver with many complex function that served multiple purpose. There was an idea to have sw only and hw only LEDs and sw only and hw only LEDs. With some heads up from Andrew from the net mailing list, it was suggested to implement a more basic yet easy to implement system. These API strictly work with a designated trigger to offload their function. This may be confused with hw blink offload but LED may have an even more advanced configuration where the entire aspect of the trigger is offloaded and completely handled by the hardware. An example of this usage are PHY or switch port LEDs. Almost every of these kind of device have multiple LED attached and provide info of the current port state. Currently we lack any support of them but these device always provide a way to configure them, from basic feature like turning the LED off or no (implemented in previous series related to this feature) or even entirely driven by the hw and power on/off/blink based on some events, like tx/rx traffic, ethernet cable attached, link speed of 10mbps, 100mbps, 1000mbps or more. They can also support multiple logic like blink with traffic only if a particular link speed is attached. (an example of this is when a LED is designated to be turned on only with 100mbps link speed and configured to blink on traffic and a secondary LED of a different color is present to serve the same function but only when the link speed is 1000mbps) These case are very common for a PHY or a switch but they were never standardized so OEM support all kind of variant and configuration. Again with Andrew we compared some feature and we reached a common set of modes that are for sure present in every kind of devices. And this concludes history and why. What is present in this series ============================== This patch contain the required API to support this feature, I decided on the name of hw control to quickly describe this feature. I documented each require API in the related Documentation for leds-class so I think it might me redundant to expose them here. Feel free to tell me how to improve it if anything is not clear. On an abstract idea, this feature require this: - The trigger needs to make use of it, this is currently implemented for the netdev trigger but other trigger can be expanded if the device expose these function. An idea might be a anything that handle a storage disk and have the LED configurable to blink when there is any activity to the disk. - The LED driver needs to expose and implement these new API. Currently a LED driver supports only a trigger. The trigger should use the related helper to check if the LED can be driven hy hardware. The different modes a trigger support are exposed in the kernel include leds.h header and are used by the LED driver to understand what to do. The LED driver expose a mask of the different modes supported and trigger use this to validate the modes and decide what to enable.