From patchwork Sat May 27 11:28:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 686593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E31C77B7E for ; Sat, 27 May 2023 11:29:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbjE0L3T (ORCPT ); Sat, 27 May 2023 07:29:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjE0L3S (ORCPT ); Sat, 27 May 2023 07:29:18 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5236EB; Sat, 27 May 2023 04:29:16 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f6d7abe9a4so11264145e9.2; Sat, 27 May 2023 04:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685186955; x=1687778955; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=49u9uYR1lSYJCMJKXyUifMM9gUKq9GWhoR8pU9TMHaM=; b=lJzNHF0XuCNgdGnZ10Scc9Oqnrxt+o0kVNsZh53pcmMokaeneuCUs1U4HQzc2uCf8V oc6bEPZAXzsVqpHyUTvQCr49LvfEzqTFL8g+OlTZQNqjU4wHA8VyTUx+4lgDQl0qBEME ESdrwLuswEHwQcTmHF8U5UNG8IfAeIS2KwE3l1Dk7JiSpauvMSp1F4brS5/IWDaa8/4B K/JWuGP1z1fZXMjRvvt6Lr1VLTFK73mLDZJ8RT17GT44Lw5TY8UtdzcVyhm66MpzaZ5z rJVX8aYYEwUj/tiGn31EdnK5M+1seRsWYs1L0+m+VOra7rEG4k3fXp2+aqtY8nm1BTi/ i8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685186955; x=1687778955; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=49u9uYR1lSYJCMJKXyUifMM9gUKq9GWhoR8pU9TMHaM=; b=fQhalIeTjv+3zET1bwqHxsi6Ms6wxVed0w6W9tYcL2luHMncLo0BlCRcZnqfN1D6l5 i/nqZzy5/YzrVl21AQN27jeOfLrD1B9z+VVihWvU5cbsQ7Akoc2X4lP56u3Yhco27Lmm lfWsQcDmFTlnNqAtKXTO2wpnlBGJVCfTsgxS0V+CmM78q+zkEov4V9Cp+yoeTkjoy1r/ Tq3F2nUifpQNUJczwSsrceB27XotajmDT0I9BNY+iF7HMyN6V7Eu8WD67rqnZqg1+UZs QbqsmY429+VC8ZjZZwhrgSByYrCvwV1lAPdD65DktbUy+hQIgUM6JDYRwReMGps1cEUj AwOQ== X-Gm-Message-State: AC+VfDwJIw5MXFnFoIXF7+Kgo/FaqZu8F5J9CVNM4EhLFd9uEhcyDQQi w6+MKV1xo114LfqNAcDawiY= X-Google-Smtp-Source: ACHHUZ5QcZFHMIVPP9Z4u1UveGhYexle/qp8Q/3XdQy1e/gdYC+76gWnFD2augCukIEfWir/PwxE+A== X-Received: by 2002:a1c:e901:0:b0:3f6:148f:5867 with SMTP id q1-20020a1ce901000000b003f6148f5867mr3545473wmc.4.1685186954707; Sat, 27 May 2023 04:29:14 -0700 (PDT) Received: from localhost.localdomain (93-34-93-173.ip49.fastwebnet.it. [93.34.93.173]) by smtp.googlemail.com with ESMTPSA id q13-20020a7bce8d000000b003f43f82001asm11711000wmj.31.2023.05.27.04.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 May 2023 04:29:14 -0700 (PDT) From: Christian Marangi To: Pavel Machek , Lee Jones , Jonathan Corbet , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [net-next PATCH v3 00/13] leds: introduce new LED hw control APIs Date: Sat, 27 May 2023 13:28:41 +0200 Message-Id: <20230527112854.2366-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Since this series is cross subsystem between LED and netdev, a stable branch was created to facilitate merging process. This is based on top of branch ib-leds-netdev-v6.5 present here [1] and rebased on top of net-next since the LED stable branch got merged. This is a continue of [2]. It was decided to take a more gradual approach to implement LEDs support for switch and phy starting with basic support and then implementing the hw control part when we have all the prereq done. This is the main part of the series, the one that actually implement the hw control API. Some history about this feature and why ======================================= This proposal is highly requested by the entire net community but the API is not strictly designed for net usage but for a more generic usage. Initial version were very flexible and designed to try to support every aspect of the LED driver with many complex function that served multiple purpose. There was an idea to have sw only and hw only LEDs and sw only and hw only LEDs. With some heads up from Andrew from the net mailing list, it was suggested to implement a more basic yet easy to implement system. These API strictly work with a designated trigger to offload their function. This may be confused with hw blink offload but LED may have an even more advanced configuration where the entire aspect of the trigger is offloaded and completely handled by the hardware. An example of this usage are PHY or switch port LEDs. Almost every of these kind of device have multiple LED attached and provide info of the current port state. Currently we lack any support of them but these device always provide a way to configure them, from basic feature like turning the LED off or no (implemented in previous series related to this feature) or even entirely driven by the hw and power on/off/blink based on some events, like tx/rx traffic, ethernet cable attached, link speed of 10mbps, 100mbps, 1000mbps or more. They can also support multiple logic like blink with traffic only if a particular link speed is attached. (an example of this is when a LED is designated to be turned on only with 100mbps link speed and configured to blink on traffic and a secondary LED of a different color is present to serve the same function but only when the link speed is 1000mbps) These case are very common for a PHY or a switch but they were never standardized so OEM support all kind of variant and configuration. Again with Andrew we compared some feature and we reached a common set of modes that are for sure present in every kind of devices. And this concludes history and why. What is present in this series ============================== This patch contain the required API to support this feature, I decided on the name of hw control to quickly describe this feature. I documented each require API in the related Documentation for leds-class so I think it might me redundant to expose them here. Feel free to tell me how to improve it if anything is not clear. On an abstract idea, this feature require this: - The trigger needs to make use of it, this is currently implemented for the netdev trigger but other trigger can be expanded if the device expose these function. An idea might be a anything that handle a storage disk and have the LED configurable to blink when there is any activity to the disk. - The LED driver needs to expose and implement these new API. Currently a LED driver supports only a trigger. The trigger should use the related helper to check if the LED can be driven hy hardware. The different modes a trigger support are exposed in the kernel include leds.h header and are used by the LED driver to understand what to do. Reviewed-by: Andrew Lunn Reviewed-by: Andrew Lunn