From patchwork Mon Mar 8 15:30:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 395439 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1807163jai; Mon, 8 Mar 2021 07:31:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJykPKuMi/9uEXIb/t39wrqbb7BkGGDjnoK8pRs3J95EZrsFomtgJDMgjWcbIcOXI0HXeowx X-Received: by 2002:a17:907:2661:: with SMTP id ci1mr15465002ejc.403.1615217516991; Mon, 08 Mar 2021 07:31:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615217516; cv=none; d=google.com; s=arc-20160816; b=oF/i6S0/A5gddz+U5eAFk1cwbLNfuFeh9PnG+y1fxuWGxsUiAXtJy6Yu4NhsWOy8si JDEqYqbwstL5q8v0sJ3zJdbaD7BzoleamMg10gz9PE2TN5k3vILKMr1XaQx2GD+g1qPf Gs7cSuk4iP8dPpwAZ9TwpraNR8aaGdeCVELLFmzkM/ZtM9xc2P60+jttv5wu+PkuduEr a/5/bRBsk2H8hPXKknIjPXirLrUiM232GOBPVE7Bj8Nn8NqQJVIpikFtTgmQJ7JP9U7Y ZizMfQQoqG1oqcgsbPon+OxjXklir2Ftg5huucjLdIxM3XAPp3MomszUA+jeBi2XBhv7 IyxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yESO2K51iO1trjhIMZQux4UBaRra6kahaq2hq3f7JoE=; b=RjF48Iyvtcsqtmdju1zF5magbDGnRjlyEpsd+vEAgpD4l7dNClo/EqFKScOY8b+TtS K9tXdqr+wvte/KKCGH02A27BVMSOxUdPl/p6A4sOs+6oZJjqHaws6VqL/8EX2xfT05+R OHf6Hv3r652oHe+o9bP3y5Idq0O0cok3W/42sAy0lMxJXyBiuJN8nW8ouYXTBNsVORc7 8+W4YvBDRKa09dWARG2S5sClDdNB4XZ5OCnXdLF9trw1Hg2ViptVfx5ig5Y99oT+95j6 o8fcRYn6fWVkb8lghIkX7/hhrK+3ik2ilGAPuNQ4ERXGDg0sjMhvBazzWhcO4Ud+uZnQ bTDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WQPDsm91; spf=pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de4si6680610ejc.539.2021.03.08.07.31.56 for ; Mon, 08 Mar 2021 07:31:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WQPDsm91; spf=pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbhCHPbY (ORCPT ); Mon, 8 Mar 2021 10:31:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:60270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhCHPa5 (ORCPT ); Mon, 8 Mar 2021 10:30:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 83E1665268; Mon, 8 Mar 2021 15:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615217456; bh=XDn9VnP1zc9fiTUfyroWNAus/+DLV8iMrXEa3AaEajs=; h=From:To:Cc:Subject:Date:From; b=WQPDsm91L2N5ld9qXRa5w/00lS7brnd5KDvyc03E5J7uAil/ycy9OAoBlcPNGSQ+I yrdCXxMxP9lWnVz4A63VcPgDtUMPy/swfeS2ozOGxfqGgXE1bX7nCDq6rRIEQ7xLrF /6hAT4ZNZqqYT/PAbtLAKkDBBSYHY1EsAbOR+9HgHgN21f4mMZh3JsTRZPjIbBXr6d KQoAuHBSD/Y4nH75t4XeGdzVQCgH1VQEEFxoLs3XNMAryp0OCH7h8pnPiOYWz4dqBm fXqWU30S9yaGyIDX84nSGqeN6TC3/XJKw9P4/W73Gmdki9FJtb9Ds+BuBmRZ2flGvi EtOFm4tqJozYg== From: Arnd Bergmann To: Pavel Machek , Amireddy Mallikarjuna reddy Cc: Arnd Bergmann , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: lgm: fix gpiolib dependency Date: Mon, 8 Mar 2021 16:30:46 +0100 Message-Id: <20210308153052.2353885-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Arnd Bergmann Without gpiolib, the driver fails to build: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' struct gpio_chip chip; ^ include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip' struct gpio_chip; ^ drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] gpiod_set_value(led->gpiod, val); ^ drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'? include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here static inline void gpio_set_value(unsigned gpio, int value) ^ drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] gpiod_set_value(led->gpiod, 1); ^ Add the dependency in Kconfig. Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC") Signed-off-by: Arnd Bergmann --- drivers/leds/blink/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.29.2 Signed-off-by: Amireddy Mallikarjuna reddy diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index 265b53476a80..6dedc58c47b3 100644 --- a/drivers/leds/blink/Kconfig +++ b/drivers/leds/blink/Kconfig @@ -9,6 +9,7 @@ if LEDS_BLINK config LEDS_BLINK_LGM tristate "LED support for Intel LGM SoC series" + depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON depends on OF