| Message ID | 20230322160926.948687-4-dan.scally@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add WLED support to TPS68470 LED driver | expand |
Hi, On 3/22/23 17:09, Daniel Scally wrote: > Add the board data for the Surface Go platforms to configure the LEDs > provided by the TPS68470 PMIC. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> As mentioned in the review of 1/8 please squash the drivers/platorm/x86/intel/int3472/ of 1/8 into this, with that fixed this is: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > ...ctps68470_board_data.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > index 322237e056f3..0d46a238b630 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > @@ -146,9 +146,21 @@ static struct gpiod_lookup_table surface_go_int347e_gpios = { > } > }; > > +static const struct tps68470_led_platform_data surface_go_tps68470_led_pdata = { > + .iledctl_ctrlb = 0x30, > + .wledmaxf = 0x1f, > + .wledto = 0x07, > + .wledc1 = 0x1f, > + .wledc2 = 0x1f, > + .wledctl_mode = 0x00, > + .wledctl_disled1 = true, > + .wledctl_disled2 = false, > +}; > + > static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = { > .dev_name = "i2c-INT3472:05", > .tps68470_regulator_pdata = &surface_go_tps68470_pdata, > + .tps68470_led_pdata = &surface_go_tps68470_led_pdata, > .n_gpiod_lookups = 2, > .tps68470_gpio_lookup_tables = { > &surface_go_int347a_gpios, > @@ -159,6 +171,7 @@ static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = > static const struct int3472_tps68470_board_data surface_go3_tps68470_board_data = { > .dev_name = "i2c-INT3472:01", > .tps68470_regulator_pdata = &surface_go_tps68470_pdata, > + .tps68470_led_pdata = &surface_go_tps68470_led_pdata, > .n_gpiod_lookups = 2, > .tps68470_gpio_lookup_tables = { > &surface_go_int347a_gpios,
diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c index 322237e056f3..0d46a238b630 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -146,9 +146,21 @@ static struct gpiod_lookup_table surface_go_int347e_gpios = { } }; +static const struct tps68470_led_platform_data surface_go_tps68470_led_pdata = { + .iledctl_ctrlb = 0x30, + .wledmaxf = 0x1f, + .wledto = 0x07, + .wledc1 = 0x1f, + .wledc2 = 0x1f, + .wledctl_mode = 0x00, + .wledctl_disled1 = true, + .wledctl_disled2 = false, +}; + static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = { .dev_name = "i2c-INT3472:05", .tps68470_regulator_pdata = &surface_go_tps68470_pdata, + .tps68470_led_pdata = &surface_go_tps68470_led_pdata, .n_gpiod_lookups = 2, .tps68470_gpio_lookup_tables = { &surface_go_int347a_gpios, @@ -159,6 +171,7 @@ static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = static const struct int3472_tps68470_board_data surface_go3_tps68470_board_data = { .dev_name = "i2c-INT3472:01", .tps68470_regulator_pdata = &surface_go_tps68470_pdata, + .tps68470_led_pdata = &surface_go_tps68470_led_pdata, .n_gpiod_lookups = 2, .tps68470_gpio_lookup_tables = { &surface_go_int347a_gpios,
Add the board data for the Surface Go platforms to configure the LEDs provided by the TPS68470 PMIC. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- .../x86/intel/int3472/tps68470_board_data.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)