| Message ID | 20240224224951.1357644-1-morf3089@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] leds: qcom-lpg: Add support for PMI8950 PWM | expand |
On 24/02/2024 23:49, Gianluca Boiano wrote: > Update leds-qcom-lpg binding to support PMI8950 PWM. > > Signed-off-by: Gianluca Boiano <morf3089@gmail.com> > --- > Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > index 6649ca2ec805..ea617fad5a4e 100644 > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > @@ -27,6 +27,7 @@ properties: > - qcom,pm8994-lpg > - qcom,pmc8180c-lpg > - qcom,pmi632-lpg > + - qcom,pmi8950-pwm You will need to update the if: as well. Last commit Anjelique Melendez made there a bit of a mess... Please rebase on top of: https://lore.kernel.org/linux-devicetree/20240226073713.19045-1-krzysztof.kozlowski@linaro.org/T/#t Best regards, Krzysztof
On 26/02/2024 11:57, Gianluca Boiano wrote: > Update leds-qcom-lpg binding to support PMI8950 PWM. > > Signed-off-by: Gianluca Boiano <morf3089@gmail.com> > --- > Changes: Three different patchsets, two with random versioning, all attached to one thread. Sorry, that's just confusing. 1. Version your patchsets. 2. Send them as separate thread. Just use b4 and avoid half of review complains... Best regards, Krzysztof
diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c index 6bdc5b923f98..9467c796bd04 100644 --- a/drivers/leds/rgb/leds-qcom-lpg.c +++ b/drivers/leds/rgb/leds-qcom-lpg.c @@ -1693,6 +1693,13 @@ static const struct lpg_data pm8941_lpg_data = { }, }; +static const struct lpg_data pmi8950_pwm_data = { + .num_channels = 1, + .channels = (const struct lpg_channel_data[]) { + { .base = 0xb000 }, + }, +}; + static const struct lpg_data pm8994_lpg_data = { .lut_base = 0xb000, .lut_size = 64, @@ -1819,6 +1826,7 @@ static const struct of_device_id lpg_of_table[] = { { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data }, { .compatible = "qcom,pmi632-lpg", .data = &pmi632_lpg_data }, + { .compatible = "qcom,pmi8950-pwm", .data = &pmi8950_pwm_data }, { .compatible = "qcom,pmi8994-lpg", .data = &pmi8994_lpg_data }, { .compatible = "qcom,pmi8998-lpg", .data = &pmi8998_lpg_data }, { .compatible = "qcom,pmc8180c-lpg", .data = &pm8150l_lpg_data },
The PMI8950 PMIC contains 1 PWM channel Signed-off-by: Gianluca Boiano <morf3089@gmail.com> --- drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++++ 1 file changed, 8 insertions(+)