diff mbox series

[v2,4/4] ARM: dts: marvell: Indicate USB activity on x530

Message ID 20240227212244.262710-5-chris.packham@alliedtelesis.co.nz
State Superseded
Headers show
Series auxdisplay: 7 segment LED display | expand

Commit Message

Chris Packham Feb. 27, 2024, 9:22 p.m. UTC 
Use the dot on the 7 segment LED block to indicate USB access on the
x530.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---

Notes:
    Change in v2:
    - New

 arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Andy Shevchenko Feb. 28, 2024, 12:09 a.m. UTC | #1 
On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
>
> Use the dot on the 7 segment LED block to indicate USB access on the
> x530.

Not sure if it's a good idea. I have some plans for the compressed
format, i.e. use DP for dots (or compatible pieces) so we may print up
to double characters with that (e.g., '6.4.5.3.' as a single string on
a 4-digit display).

That said, I would like to defer this for a while.
Chris Packham Feb. 28, 2024, 1:11 a.m. UTC | #2 
On 28/02/24 13:09, Andy Shevchenko wrote:
> On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
>> Use the dot on the 7 segment LED block to indicate USB access on the
>> x530.
> Not sure if it's a good idea. I have some plans for the compressed
> format, i.e. use DP for dots (or compatible pieces) so we may print up
> to double characters with that (e.g., '6.4.5.3.' as a single string on
> a 4-digit display).
>
> That said, I would like to defer this for a while.
>
In our case this is how we've matched up other devices which have a 3 
LED tower for "power", "fault" and "usb" with devices which have a 
7-segment LED instead. I just wanted to reflect reality in the upstream dts.

It also answers the question "what about the DP LED"?
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
index f55a3dc6b6de..94ae9f4ebe1c 100644
--- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
+++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
@@ -54,6 +54,15 @@  &led_7seg_gpio 4 GPIO_ACTIVE_LOW
 				 &led_7seg_gpio 5 GPIO_ACTIVE_LOW
 				 &led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		led-0 {
+			label = "usb";
+			gpios =  <&led_7seg_gpio 7 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "usb-host";
+		};
+	};
 };
 
 &pciec {