| Message ID | 20241207130433.30351-2-towinchenmi@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Apple DWI backlight driver | expand |
On Sat, Dec 07, 2024 at 09:03:14PM +0800, Nick Chan wrote: > Add the device tree bindings for backlight controllers attached via Apple > DWI 2-wire interface. A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Signed-off-by: Nick Chan <towinchenmi@gmail.com> > --- > .../bindings/leds/backlight/apple,dwi-bl.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml > > diff --git a/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml > new file mode 100644 > index 000000000000..9d4aa243f679 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/apple,dwi-bl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple DWI 2-Wire Interface Backlight Controller > + > +maintainers: > + - Nick Chan <towinchenmi@gmail.com> > + > +description: | Do not need '|' unless you need to preserve formatting. > + Apple SoCs contain a 2-wire interface called DWI. On some Apple iPhones, > + iPads and iPod touches with a LCD display, 1-2 backlight controllers > + are connected via DWI. Interfacing with DWI controls all backlight > + controllers at the same time. As such, the backlight controllers are > + treated as a single controller regardless of the underlying > + configuration. > + missing allOf: with $ref to common.yaml > +properties: > + compatible: > + items: > + - enum: > + - apple,s5l8960x-dwi-bl > + - apple,t7000-dwi-bl > + - apple,s8000-dwi-bl > + - apple,t8010-dwi-bl > + - apple,t8015-dwi-bl > + - const: apple,dwi-bl > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false (and this then becomes unevaluatedProperties: false) > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dwi_bl: backlight@20e200010 { > + compatible = "apple,s5l8960x-dwi-bl", "apple,dwi-bl"; > + reg = <0x2 0x0e200010 0 8>; Usual preference is to keep hex everywhere. Best regards, Krzysztof
On 9/12/2024 17:16, Krzysztof Kozlowski wrote: > On Sat, Dec 07, 2024 at 09:03:14PM +0800, Nick Chan wrote: >> Add the device tree bindings for backlight controllers attached via Apple >> DWI 2-wire interface. [...] Ack all the changes, will be in v4. Nick Chan
diff --git a/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml new file mode 100644 index 000000000000..9d4aa243f679 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/apple,dwi-bl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple DWI 2-Wire Interface Backlight Controller + +maintainers: + - Nick Chan <towinchenmi@gmail.com> + +description: | + Apple SoCs contain a 2-wire interface called DWI. On some Apple iPhones, + iPads and iPod touches with a LCD display, 1-2 backlight controllers + are connected via DWI. Interfacing with DWI controls all backlight + controllers at the same time. As such, the backlight controllers are + treated as a single controller regardless of the underlying + configuration. + +properties: + compatible: + items: + - enum: + - apple,s5l8960x-dwi-bl + - apple,t7000-dwi-bl + - apple,s8000-dwi-bl + - apple,t8010-dwi-bl + - apple,t8015-dwi-bl + - const: apple,dwi-bl + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + dwi_bl: backlight@20e200010 { + compatible = "apple,s5l8960x-dwi-bl", "apple,dwi-bl"; + reg = <0x2 0x0e200010 0 8>; + power-domains = <&ps_dwi>; + }; + };
Add the device tree bindings for backlight controllers attached via Apple DWI 2-wire interface. Signed-off-by: Nick Chan <towinchenmi@gmail.com> --- .../bindings/leds/backlight/apple,dwi-bl.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml