From patchwork Sat Feb 1 13:04:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 862320 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazolkn19012054.outbound.protection.outlook.com [52.103.37.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA2CD2C9A; Sat, 1 Feb 2025 13:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.37.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415111; cv=fail; b=jYW0Pp+4SKXzsTiUVgeLenfxoZJzZ09g6JOIVsNZcRU2MkkwctttQ9dHJyuSm+HzQ7OjMQ17WgDsDC8Yu6woBdbFil0rnp8lwzI5XYro62BJ7ihI41rgmtCJFPeMypfDpJ8B28avXnuS3r1y2aG6DQ+lO6a4KHHqaFuDI/fsB04= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415111; c=relaxed/simple; bh=D4K9r6e8+Sk1BS+2VGhIrg5v2AEBsDv5XXQuSlnTfiY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=J7OtR43PsEJ33o53/idDU4HYnlLweQXdoqQ+Dy0Wu12UyNOE9jPwjrxAKopMw9SMt0UPTdXIVSpeWqFmIWMi2UFiei8a9VoNN3P6ewfgV0kH9VHmLf3iaMabPuzEIEfsvc43DJjocJNaEwe7QeScF0+66Oye+fJDi4V2tbqtrlQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=nLf8FkVP; arc=fail smtp.client-ip=52.103.37.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="nLf8FkVP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k0cEhe9mBJX2EaI7O9oppt01c3Sq3DZWbZ3zkVVBk5LGxZrfwYZeqmxKdWNxTmIS12pRWoDGy/t6GxO+Z6EQoNvD6gdHqBZn0JRhugPe+IrliKe78MfB4SfcogzmsT8h0OrCNcXOMkvSRZHBQOcJ/v3mtuj47t94GyP2S+OXXlVU0jP3pqqJh6TB8gC8kjBAY+HSe3anXWS6UJBdXtetbvsbHoerwfDKQaoKtb0mawtoGHaqA9PNjZ9A3wwHCaobDKnJ00JGVm3Gy7bZwCkXviNRQjGQD1c61n+CgqgCKEc2D5RfbiMTWwRf0KDcQYgw/U5XqA1WQSqEfVX7laFOXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=fGeTx+WJtXjL0MhhWs+IBKzp49kAWcMjwAW3XH2WKKUNNaN0E2+EA0/21lHnx+oqfWLGFL2VglScIguJiyg37r8wEAIRISeYoPBDzCe8RA7Ch8dlqYzBAFOnlNQSb7YlMOoc0mG1jjyvbLh0PWBlNF0rrm/FMNplvXnk4Yq6ioB4JU0kSvBQ88ojzUS9QScvWFgZYWBgub5aFFEyM3yS7CaPZlGWHbKXqHSPeslfRNjNXxJh7AjwSpm8uqXC97k/Niu7Bi3I65BCh6jMtEtxFT2LomqqG/myofIRZ74RV2ZVByWOJyKDv8W7Dl1h38n7rPhR5Hm03dhkJPC7dzpYcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=nLf8FkVP6Oe8ME6RkzlukfND4IluADBsQL9qVPY2q+wuCEvzKfB0Axpbk9jHmiKdIUXUpca58Q+g0kFpY3zyL//s+Q0lAAJWl0wlH0SvsbErXKbwjLEQ4MTVj5CRgY/UMRVD+G6uUahv8NK4j/hQbaWUZ1DQdjs1j60Y7styc1IEokJSE5LurhIzCYnooDTiMvs9xiOu6uJNm+T/EYbWJRTLxcLi2y5nT55yRFpvTGHaOp9aumqSiWFNecJoTbZFP6dKMITHqFbJkA9D3WnoM8yOSDJ0ytnACWE2vHw5NJS5RbpqdjXEiDg0Gkb4r/46CWAZ+ebvRr4rRgZcC4/2mQ== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by LO4P123MB6306.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:299::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.22; Sat, 1 Feb 2025 13:05:06 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%4]) with mapi id 15.20.8398.021; Sat, 1 Feb 2025 13:05:06 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 3/5] leds: leds-st1202: spacing and proofreading editing Date: Sat, 1 Feb 2025 13:04:59 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: LO4P265CA0132.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::13) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250201130505.1693063-1-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|LO4P123MB6306:EE_ X-MS-Office365-Filtering-Correlation-Id: 68c811b1-e068-4ad9-aa43-08dd42c10c4d X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|19110799003|6090799003|7092599003|15080799006|461199028|3412199025|440099028|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?clRYrF1mAKXvBisVw2VsOtFRJI1bjNP?= =?utf-8?q?69WcJwh48yWKCLXcSwbPl27pKme+pmVtAAGsi2To76XQTc4G6+zW7H71srYFMNeAQ?= =?utf-8?q?GBq5cCpyD/sRcemtB1gAkOaU22oVd/GMcGYDkEzZvySpQ7LuDt2HesBPMVPwaPBr2?= =?utf-8?q?UpGT3/FJech2jSWCYsAxrFTUTopARsoJ5Iu/1qNjDVhBAxb39wcS2MJIi6aOBWDdX?= =?utf-8?q?G4ZBQJJ2pQgdNT4pDzgcCGyh2mk8zpkX6JwWAcql7gcOem05JhA5vVmzBqYvlgSLJ?= =?utf-8?q?ulv735ZH9ApzCnEP/YJr98QF3aiQtv/L5SuRt7dkz7HMjuRdjlTthWRqafej2s5KO?= =?utf-8?q?C2ZpKq+r2kleSOybD5DIgve3u96LxVBkwTtV8vCsgUE6+nhoBFxmf++iw3N86PJpr?= =?utf-8?q?CH2sywQIlGJDCZkbGq3AbHKsLMK2Yx2sq2QNE7k3QBWWWxF4Z49wlAbyHe3CCZ+7o?= =?utf-8?q?Rx3V2Y+twrS9/t+U6lGnmV6hrGX2ny3Kn3EmSfHI4UmsmZilVumN6LguOltCm8XrP?= =?utf-8?q?L9ZYKKeuKoFZsweWBbZRaOdLc/d117zJKof1gf1UAS93dJBiye+M0ALfiT6m5/z5v?= =?utf-8?q?vaY1g222iyIyzPoSqoGNy8rpS31mowwNqYnXO14rgeP/aSLl+DeGt2REzEXQaYvyM?= =?utf-8?q?g/6Fa6Bcb/Q1dUCoC3lKTyeXvp6AlY2WBVS289uDs5uzyZ4Zezkpky/aG3kaIPHnD?= =?utf-8?q?CqnHhelhppMlFRzV3MYDzTPy/Uf/jq4t6BydoS56ztRwqLiCl8bdpsqzUjMqG3SHW?= =?utf-8?q?5xsCzY0uClH5B/Rlm+qwMOqXYB1dmT+7XHwEIS6M9cHbSoytHDEp+hlpgo19KzzOo?= =?utf-8?q?CEyZQCJYzazZGW79F9wHeFeyGdquXorsQ2Ftk3rk3WFfr1TQm5ySNSky8CoE8lu5V?= =?utf-8?q?+MaPnFTs9PfXEgnIr6RynTvbgc7lRjSHfTTAcaicVQ0lWWU23xFOGUxyDJ3/z7/tB?= =?utf-8?q?cQ9lmo3lpTjSecCVnQfbhC0Ob9hY/w/vUOuVSQ0MKHqTptugRvHRfwAvQxSyabVGD?= =?utf-8?q?UVYAafBR7tQUN/q3VMx6sqdNpcVFJUN43MAzEAw4+Q4jzLhgVE3SmUhWxidsTOqfA?= =?utf-8?q?Ic4z2c1x0jtpwwW0SqkAMfu4SyZoINvQI5Ulhg=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?8Fojtlmb3ko2bfOp3uSeOMBndHDh?= =?utf-8?q?10OktRsOeUc+InFQH8fMzx7GcVAy2X08DvQHTku+osFUXjm64RzLlelbwAaxGmdTZ?= =?utf-8?q?uxLXR5GsYrlfAI4TEtSiAHSxlEl4HGvjMRw7YoT4XzExsZ6gSerTHtfAinnoib8un?= =?utf-8?q?hFKiZ2z+25YrmYT31fGketoalan+GlzAY18YHCJ7Vf4e0laQpEstC+oWZ4JWOSCgL?= =?utf-8?q?GOoAsEwV1ZGmL3FW76T1Aku6yoyec+QAHUWxLxMfk/KL+2ZK+q8fy4U+uAUDF6wGr?= =?utf-8?q?n/F8bjh5NDxDmxFez56ej+5aKiWQwKtt3EkjhZaN6Li0DrxtjiaOa6fjKLHW4jDGY?= =?utf-8?q?2uE0rprSsx35zoPuq/Lk4WbG0QOeXcDRQ38vqQxHBktWyB0R5bcRk4aDOfDPdYy8r?= =?utf-8?q?C60bK0T2cCGlKFVvIm6F9IYgJHaVyMkIa9EOfBE9T959ZD3oIL7quIODdiXMtRZi7?= =?utf-8?q?D/g+7PIxudCiIoUMZUtXv8lTy/wz3CwenTSLzh+KvICYDz+LxNHSrW7gDgMNZ6WaT?= =?utf-8?q?6uy4AUUrKiEWCsEesHpyTxgutqShFBBOTieo5UTiduTgwwNW8RKTM2F5Y6OBzfPhx?= =?utf-8?q?s+z2kYcQLrxmMJiU7HmDRzdZ3hjWbslIn8FRSYRDlCsKfZBb4K3A0HyB+I9lG0k+/?= =?utf-8?q?FSXT/vp2AHcFdmsWOySYyKhxeZXMP30MTz10TH8d97HPFBoQkE04Dw4EefpHMhsXS?= =?utf-8?q?lLHo6XHDf2zMms8bspnwRMWXj7TzL23QGiYSU8EUE8KFWUzXHoaEvDn7RgIWCcnwp?= =?utf-8?q?XzddXaNIRWV6+UefSZHtOUjtiBBZaoBoDyBEBeAmXW8wqP+gQIaPHaJOd03FSWmLJ?= =?utf-8?q?bAHVMsqXzIS04QWEit0q6wqyn8odESOtYvUknmtzo7qwcwfmU75RNuxID7+S2vzG5?= =?utf-8?q?oeRR7jcnfp0CjDXdM9McWmrigwlTmtW4JYvz7BxZ3std34sxi2GPQTE0uY+2IZZhi?= =?utf-8?q?75Ip7lob1RNe6Jo86rpDzT2/AbWhQcZcYloUkgFFVZQlDj0RfDfIvEKbRCSCy/s2v?= =?utf-8?q?lkpqTvKUmvkQ56ydrb4GIZlOqinWqjSl91MFsSRJS1tnMoRotaf0FF1w8nFOdAdYv?= =?utf-8?q?fwkySxhh5NYHN+l4Lto1oV/xHhfZuFpuo5yd+LFHO8GQYRojFlHGjgziqdEGIWeet?= =?utf-8?q?kKk6lm3tmHrJbtMtSUN180Ilf3mo2yQDAWYUKYMXK+ExnmFYcee6b4Cf9ljMnndLS?= =?utf-8?q?rHyig86h0KIrlIogGBZtP6GG6xy+MmT9z/sQoTE5mD9zzmiMuWVq61NNJkcA=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68c811b1-e068-4ad9-aa43-08dd42c10c4d X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2025 13:05:06.2106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P123MB6306 Minor edits regarding use of spacing and proofreading. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 927874f20839..cb4797ea8f3a 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -16,27 +16,27 @@ #include #include -#define ST1202_CHAN_DISABLE_ALL 0x00 -#define ST1202_CHAN_ENABLE_HIGH 0x03 -#define ST1202_CHAN_ENABLE_LOW 0x02 -#define ST1202_CONFIG_REG 0x04 +#define ST1202_CHAN_DISABLE_ALL 0x00 +#define ST1202_CHAN_ENABLE_HIGH 0x03 +#define ST1202_CHAN_ENABLE_LOW 0x02 +#define ST1202_CONFIG_REG 0x04 /* PATS: Pattern sequence feature enable */ -#define ST1202_CONFIG_REG_PATS BIT(7) +#define ST1202_CONFIG_REG_PATS BIT(7) /* PATSR: Pattern sequence runs (self-clear when sequence is finished) */ -#define ST1202_CONFIG_REG_PATSR BIT(6) -#define ST1202_CONFIG_REG_SHFT BIT(3) -#define ST1202_DEV_ENABLE 0x01 -#define ST1202_DEV_ENABLE_ON BIT(0) -#define ST1202_DEV_ENABLE_RESET BIT(7) -#define ST1202_DEVICE_ID 0x00 -#define ST1202_ILED_REG0 0x09 -#define ST1202_MAX_LEDS 12 -#define ST1202_MAX_PATTERNS 8 -#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 -#define ST1202_MILLIS_PATTERN_DUR_MIN 22 -#define ST1202_PATTERN_DUR 0x16 -#define ST1202_PATTERN_PWM 0x1E -#define ST1202_PATTERN_REP 0x15 +#define ST1202_CONFIG_REG_PATSR BIT(6) +#define ST1202_CONFIG_REG_SHFT BIT(3) +#define ST1202_DEV_ENABLE 0x01 +#define ST1202_DEV_ENABLE_ON BIT(0) +#define ST1202_DEV_ENABLE_RESET BIT(7) +#define ST1202_DEVICE_ID 0x00 +#define ST1202_ILED_REG0 0x09 +#define ST1202_MAX_LEDS 12 +#define ST1202_MAX_PATTERNS 8 +#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 +#define ST1202_MILLIS_PATTERN_DUR_MIN 22 +#define ST1202_PATTERN_DUR 0x16 +#define ST1202_PATTERN_PWM 0x1E +#define ST1202_PATTERN_REP 0x15 struct st1202_led { struct fwnode_handle *fwnode; @@ -99,9 +99,9 @@ static int st1202_pwm_pattern_write(struct st1202_chip *chip, int led_num, value_h = (u8)(value >> 8); /* - * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), - * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) - * and y is the pattern number in hexadecimal (y = 00h .. 07h) + * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), + * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) */ ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern), value_l); @@ -288,8 +288,8 @@ static int st1202_setup(struct st1202_chip *chip) guard(mutex)(&chip->lock); /* - * Once the supply voltage is applied, the LED1202 executes some internal checks, - * afterwords it stops the oscillator and puts the internal LDO in quiescent mode. + * Once the supply voltage is applied, the LED1202 executes some internal checks. + * Afterwards, it stops the oscillator and puts the internal LDO in quiescent mode. * To start the device, EN bit must be set inside the “Device Enable” register at * address 01h. As soon as EN is set, the LED1202 loads the adjustment parameters * from the internal non-volatile memory and performs an auto-calibration procedure