| Message ID | 20250425085328.16929-1-kyrie.wu@mediatek.com |
|---|---|
| Headers | show |
| Series | Enable jpeg enc & dec multi-hardwares for MT8196 | expand |
On Fri, Apr 25, 2025 at 04:53:16PM GMT, Kyrie Wu wrote: > This series adds support for mt8196 multi-hardwares jpeg enc & dec, > by first adding mt8196 jpegdec and jpegenc compatible to install > kernel driver. Add smmu setting to support smmu and iommu at the > same time. > Secondly refactor buffer and clock setting to support multi-hw jpeg > working. > Lastly, fix some bugs, including resolution change handleing, stop > streaming sw flow and others. > > This series has been tested with MT8196 tast test. > Encoding and decoding worked for this chip. > > Patches 1-3 Adds jpeg encoder and decoder compatible. > Patches 4 add jpeg smmu sid setting. > Patches 5 fix jpeg hw count setting to support different chips. > Patches 6 refactor jpeg buffer payload setting to handle buffer > size bug while resolution changed. > Patches 7 reconstruct jpeg dst buffer layout. > Patches 8 fix multi-core stop streaming flow > Patches 9 refactor multi-core clk suspend/resume setting > Patches 10 fix decoding buffer number setting timing issue > Patches 11 refactor decoding resolution change operation > Patches 12 fix remove buffer operation > > --- > This series patches dependent on: > [1] > https://patchwork.kernel.org/project/linux-mediatek/patch/20250424090824.5309-1-jianhua.lin@mediatek.com/ > > Changes compared with v2: > --refactor smmu sid setting function interface > --Some modifications for patch v2's review comments. This is very vague. What exactly changed. > > Changes compared with v1: > --refine jpeg dt-bindings for MT8196 This tells me nothing. Best regards, Krzysztof
On Mon, 2025-04-28 at 09:01 +0200, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Fri, Apr 25, 2025 at 04:53:16PM GMT, Kyrie Wu wrote: > > This series adds support for mt8196 multi-hardwares jpeg enc & dec, > > by first adding mt8196 jpegdec and jpegenc compatible to install > > kernel driver. Add smmu setting to support smmu and iommu at the > > same time. > > Secondly refactor buffer and clock setting to support multi-hw jpeg > > working. > > Lastly, fix some bugs, including resolution change handleing, stop > > streaming sw flow and others. > > > > This series has been tested with MT8196 tast test. > > Encoding and decoding worked for this chip. > > > > Patches 1-3 Adds jpeg encoder and decoder compatible. > > Patches 4 add jpeg smmu sid setting. > > Patches 5 fix jpeg hw count setting to support different chips. > > Patches 6 refactor jpeg buffer payload setting to handle buffer > > size bug while resolution changed. > > Patches 7 reconstruct jpeg dst buffer layout. > > Patches 8 fix multi-core stop streaming flow > > Patches 9 refactor multi-core clk suspend/resume setting > > Patches 10 fix decoding buffer number setting timing issue > > Patches 11 refactor decoding resolution change operation > > Patches 12 fix remove buffer operation > > > > --- > > This series patches dependent on: > > [1] > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20250424090824.5309-1-jianhua.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!hDjzydf2blyIhdAkYs_NbqpEaaWTuolLbaHLDw8hLg4BJ87r7ePzKkET-uDw24U6YXAqmbSxItem1Q$ > > > > Changes compared with v2: > > --refactor smmu sid setting function interface > > --Some modifications for patch v2's review comments. > > This is very vague. What exactly changed. Dear Krzysztof, Sorry for the shortly descriptions. The main changing in V3 is fixed dt-bindings comments by you. > > > > > Changes compared with v1: > > --refine jpeg dt-bindings for MT8196 > > This tells me nothing. I have changed the patch's subject of dt-bindings, but it still made mistake. I must apologize to you again. I did not ignore your suggestions, but my revisions did not meet your requirements. I will fix these issues in the next version. > > Best regards, > Krzysztof > Regards, Kyrie.
This series adds support for mt8196 multi-hardwares jpeg enc & dec, by first adding mt8196 jpegdec and jpegenc compatible to install kernel driver. Add smmu setting to support smmu and iommu at the same time. Secondly refactor buffer and clock setting to support multi-hw jpeg working. Lastly, fix some bugs, including resolution change handleing, stop streaming sw flow and others. This series has been tested with MT8196 tast test. Encoding and decoding worked for this chip. Patches 1-3 Adds jpeg encoder and decoder compatible. Patches 4 add jpeg smmu sid setting. Patches 5 fix jpeg hw count setting to support different chips. Patches 6 refactor jpeg buffer payload setting to handle buffer size bug while resolution changed. Patches 7 reconstruct jpeg dst buffer layout. Patches 8 fix multi-core stop streaming flow Patches 9 refactor multi-core clk suspend/resume setting Patches 10 fix decoding buffer number setting timing issue Patches 11 refactor decoding resolution change operation Patches 12 fix remove buffer operation --- This series patches dependent on: [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20250424090824.5309-1-jianhua.lin@mediatek.com/ Changes compared with v2: --refactor smmu sid setting function interface --Some modifications for patch v2's review comments. Changes compared with v1: --refine jpeg dt-bindings for MT8196 --optimize software code to manage jpeg HW count --refactor smmu sid setting function interface --Some modifications for patch v1's review comments. Kyrie Wu (9): media: mediatek: jpeg: add jpeg smmu sid setting media: mediatek: jpeg: fix jpeg hw count setting media: mediatek: jpeg: refactor jpeg buffer payload setting media: mediatek: jpeg: refactor jpeg dst buffer layout media: mediatek: jpeg: fix stop streaming flow for multi-core media: mediatek: jpeg: refactor multi-core clk suspend and resume setting media: mediatek: jpeg: fix decoding buffer number setting timing issue media: mediatek: jpeg: refactor decoding resolution change operation media: mediatek: jpeg: fix remove buffer operation for multi-core kyrie.wu (3): dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible media: mediatek: jpeg: add jpeg compatible .../media/mediatek,mt8195-jpegdec.yaml | 8 +- .../media/mediatek,mt8195-jpegenc.yaml | 8 +- .../platform/mediatek/jpeg/mtk_jpeg_core.c | 169 +++++++++++++----- .../platform/mediatek/jpeg/mtk_jpeg_core.h | 21 ++- .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 112 +++++++++++- .../platform/mediatek/jpeg/mtk_jpeg_enc_hw.c | 112 +++++++++++- 6 files changed, 377 insertions(+), 53 deletions(-)