From patchwork Tue Jan 22 05:00:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 14204 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id EDF7D23E33 for ; Tue, 22 Jan 2013 05:08:53 +0000 (UTC) Received: from mail-ve0-f174.google.com (mail-ve0-f174.google.com [209.85.128.174]) by fiordland.canonical.com (Postfix) with ESMTP id A2CE5A18B46 for ; Tue, 22 Jan 2013 05:08:53 +0000 (UTC) Received: by mail-ve0-f174.google.com with SMTP id c13so428873vea.33 for ; Mon, 21 Jan 2013 21:08:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=us0FmYJ8XN35KTb+tlwQStQhpIMpg908+F1baa/vfeo=; b=beuI3aLeaWMvdC0XkcLg45RRUtoI6I5NKEVnvmU+GxmzUuCYtOm3CJyvjSgeXo26f1 MF2MVmUJIckZk/KIJ5ivEMkNKaWtYBdRGlM3s5fCasD5SchvcV7m7bsyzy9fM41qWRva l9vcq7Uhy95JB473i5QlAfQ4GAXV9NDgdaCBjlb/sxNu4MfqLwX4fUW7+iDJaNO537pM u4p5jPL3XdXJZorSZ0jPoTX+UVxEJieKVRqC2ilQoOaXrIqR0A/dmdftfindtXhF99uP UipvlTbYpRPXu5cbtSRMTFkDSEM9w0yo5QA76F+GOvykU0PGbrBBJY1GneE+phXKd+qq gIEw== X-Received: by 10.52.176.6 with SMTP id ce6mr19419451vdc.57.1358831333169; Mon, 21 Jan 2013 21:08:53 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp234118veb; Mon, 21 Jan 2013 21:08:52 -0800 (PST) X-Received: by 10.68.130.170 with SMTP id of10mr36063428pbb.131.1358831332009; Mon, 21 Jan 2013 21:08:52 -0800 (PST) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by mx.google.com with ESMTPS id wu8si15778745pbc.303.2013.01.21.21.08.51 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Jan 2013 21:08:52 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.48 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.48; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.48 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pa0-f48.google.com with SMTP id fa1so3812194pad.35 for ; Mon, 21 Jan 2013 21:08:51 -0800 (PST) X-Received: by 10.68.125.201 with SMTP id ms9mr36042580pbb.78.1358831331277; Mon, 21 Jan 2013 21:08:51 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ue7sm9996023pbc.53.2013.01.21.21.08.48 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 21:08:50 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: k.debski@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] [media] s5p-mfc: Use WARN_ON(condition) directly Date: Tue, 22 Jan 2013 10:30:06 +0530 Message-Id: <1358830806-5610-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnnoIF63cw5YEGSQVrUPJvSlLqVTE1CO4xbUpjpjv0vs+pSeezLyCqeHIJxN+o/2X3Cdfl3 Use WARN_ON(condition) directly instead of wrapping around an if condition. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index b1d7f9a..37a17b8 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -596,8 +596,7 @@ static void s5p_mfc_handle_stream_complete(struct s5p_mfc_ctx *ctx, clear_work_bit(ctx); - if (test_and_clear_bit(0, &dev->hw_lock) == 0) - WARN_ON(1); + WARN_ON(test_and_clear_bit(0, &dev->hw_lock) == 0); s5p_mfc_clock_off(); wake_up(&ctx->queue);