diff mbox series

[v2,2/8] venus: helpers: Add a new helper for buffer processing

Message ID 20201111143755.24541-3-stanimir.varbanov@linaro.org
State Superseded
Headers show
Series [v2,1/8] venus: hfi: Use correct state in unload resources | expand

Commit Message

Stanimir Varbanov Nov. 11, 2020, 2:37 p.m. UTC
The new helper will be used from encoder and decoder drivers
to enqueue buffers for processing by firmware.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

---
 drivers/media/platform/qcom/venus/helpers.c | 20 ++++++++++++++++++++
 drivers/media/platform/qcom/venus/helpers.h |  1 +
 2 files changed, 21 insertions(+)

-- 
2.17.1

Comments

Fritz Koenig Nov. 29, 2020, 6:03 a.m. UTC | #1
On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>

> The new helper will be used from encoder and decoder drivers

> to enqueue buffers for processing by firmware.

>

> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

> ---

>  drivers/media/platform/qcom/venus/helpers.c | 20 ++++++++++++++++++++

>  drivers/media/platform/qcom/venus/helpers.h |  1 +

>  2 files changed, 21 insertions(+)

>

> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c

> index efa2781d6f55..688e3e3e8362 100644

> --- a/drivers/media/platform/qcom/venus/helpers.c

> +++ b/drivers/media/platform/qcom/venus/helpers.c

> @@ -1369,6 +1369,26 @@ void venus_helper_vb2_buf_queue(struct vb2_buffer *vb)

>  }

>  EXPORT_SYMBOL_GPL(venus_helper_vb2_buf_queue);

>

> +void venus_helper_process_buf(struct vb2_buffer *vb)

> +{

> +       struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);

> +       struct venus_inst *inst = vb2_get_drv_priv(vb->vb2_queue);

> +       int ret;

> +

> +       cache_payload(inst, vb);

> +

> +       if (vb2_start_streaming_called(vb->vb2_queue)) {

> +               ret = is_buf_refed(inst, vbuf);

> +               if (ret)

> +                       return;

> +

> +               ret = session_process_buf(inst, vbuf);

> +               if (ret)

> +                       return_buf_error(inst, vbuf);

> +       }

> +}

> +EXPORT_SYMBOL_GPL(venus_helper_process_buf);

> +

>  void venus_helper_buffers_done(struct venus_inst *inst, unsigned int type,

>                                enum vb2_buffer_state state)

>  {

> diff --git a/drivers/media/platform/qcom/venus/helpers.h b/drivers/media/platform/qcom/venus/helpers.h

> index f36c9f717798..231af29667e7 100644

> --- a/drivers/media/platform/qcom/venus/helpers.h

> +++ b/drivers/media/platform/qcom/venus/helpers.h

> @@ -19,6 +19,7 @@ void venus_helper_buffers_done(struct venus_inst *inst, unsigned int type,

>  int venus_helper_vb2_buf_init(struct vb2_buffer *vb);

>  int venus_helper_vb2_buf_prepare(struct vb2_buffer *vb);

>  void venus_helper_vb2_buf_queue(struct vb2_buffer *vb);

> +void venus_helper_process_buf(struct vb2_buffer *vb);

>  void venus_helper_vb2_stop_streaming(struct vb2_queue *q);

>  int venus_helper_vb2_start_streaming(struct venus_inst *inst);

>  void venus_helper_m2m_device_run(void *priv);

> --

> 2.17.1

>


Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
index efa2781d6f55..688e3e3e8362 100644
--- a/drivers/media/platform/qcom/venus/helpers.c
+++ b/drivers/media/platform/qcom/venus/helpers.c
@@ -1369,6 +1369,26 @@  void venus_helper_vb2_buf_queue(struct vb2_buffer *vb)
 }
 EXPORT_SYMBOL_GPL(venus_helper_vb2_buf_queue);
 
+void venus_helper_process_buf(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
+	struct venus_inst *inst = vb2_get_drv_priv(vb->vb2_queue);
+	int ret;
+
+	cache_payload(inst, vb);
+
+	if (vb2_start_streaming_called(vb->vb2_queue)) {
+		ret = is_buf_refed(inst, vbuf);
+		if (ret)
+			return;
+
+		ret = session_process_buf(inst, vbuf);
+		if (ret)
+			return_buf_error(inst, vbuf);
+	}
+}
+EXPORT_SYMBOL_GPL(venus_helper_process_buf);
+
 void venus_helper_buffers_done(struct venus_inst *inst, unsigned int type,
 			       enum vb2_buffer_state state)
 {
diff --git a/drivers/media/platform/qcom/venus/helpers.h b/drivers/media/platform/qcom/venus/helpers.h
index f36c9f717798..231af29667e7 100644
--- a/drivers/media/platform/qcom/venus/helpers.h
+++ b/drivers/media/platform/qcom/venus/helpers.h
@@ -19,6 +19,7 @@  void venus_helper_buffers_done(struct venus_inst *inst, unsigned int type,
 int venus_helper_vb2_buf_init(struct vb2_buffer *vb);
 int venus_helper_vb2_buf_prepare(struct vb2_buffer *vb);
 void venus_helper_vb2_buf_queue(struct vb2_buffer *vb);
+void venus_helper_process_buf(struct vb2_buffer *vb);
 void venus_helper_vb2_stop_streaming(struct vb2_queue *q);
 int venus_helper_vb2_start_streaming(struct venus_inst *inst);
 void venus_helper_m2m_device_run(void *priv);