diff mbox series

[v5,04/15] device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary

Message ID 20210107132838.396641-5-djrscally@gmail.com
State Accepted
Commit acd418bfcfc415cf5e6414b6d1c6acfec850f290
Headers show
Series [v5,01/15] software_node: Fix refcounts in software_node_get_next_child() | expand

Commit Message

Daniel Scally Jan. 7, 2021, 1:28 p.m. UTC 
This function is used to find fwnode endpoints against a device. In
some instances those endpoints are software nodes which are children of
fwnode->secondary. Add support to fwnode_graph_get_endpoint_by_id() to
find those endpoints by recursively calling itself passing the ptr to
fwnode->secondary in the event no endpoint is found for the primary.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes in v5:

	- Changed the commit subject

 drivers/base/property.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Greg KH Jan. 10, 2021, 3:09 p.m. UTC | #1 
On Thu, Jan 07, 2021 at 01:28:27PM +0000, Daniel Scally wrote:
> This function is used to find fwnode endpoints against a device. In

> some instances those endpoints are software nodes which are children of

> fwnode->secondary. Add support to fwnode_graph_get_endpoint_by_id() to

> find those endpoints by recursively calling itself passing the ptr to

> fwnode->secondary in the event no endpoint is found for the primary.

> 

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

> Signed-off-by: Daniel Scally <djrscally@gmail.com>

> ---

> Changes in v5:

> 

> 	- Changed the commit subject

> 

>  drivers/base/property.c | 9 ++++++++-

>  1 file changed, 8 insertions(+), 1 deletion(-)


Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff mbox series

Patch

diff --git a/drivers/base/property.c b/drivers/base/property.c
index 0bf5260f14c6..1421e9548857 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -1215,7 +1215,14 @@  fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
 		best_ep_id = fwnode_ep.id;
 	}
 
-	return best_ep;
+	if (best_ep)
+		return best_ep;
+
+	if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary))
+		return fwnode_graph_get_endpoint_by_id(fwnode->secondary, port,
+						       endpoint, flags);
+
+	return NULL;
 }
 EXPORT_SYMBOL_GPL(fwnode_graph_get_endpoint_by_id);