From patchwork Fri Feb 26 14:07:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 387672 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp1228858jap; Fri, 26 Feb 2021 06:09:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhZF7CDbU1r9ehQFlW0DtlbrLXyzlrsg0aJpI0/+pvl0NOSj6GHkRAf65Ijx9rU3qcPKKD X-Received: by 2002:a17:906:d18e:: with SMTP id c14mr3454694ejz.62.1614348585800; Fri, 26 Feb 2021 06:09:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614348585; cv=none; d=google.com; s=arc-20160816; b=TBHbUIfnNkoZ15LLxI5iK/w3bRtF2Zn1i2E/3pUN+R389cmsNsvbfaAP1XcL8N9Q+y xLhVfr9SS0xAm1IXNV5HI4NBW2fKR4Hizmz0XyLAtiJQLBTgvv2mdiBvG/Z9O8+RXU4c hnNNo07HyNdfTOur0eTNdulgAgs4T08Es0thyhI5umK9pa3o5uWdJUg6kDvJulcUSV62 oX5MJL1cm45w1GhvAFJecp7lNkxV9I1slxvsZRCYqqbk1F0JSIwVlS4fctvFYvpxEFpU 23cyvGnFXbGt/ioHwx/Vaahv0m6dKuYCedAlt+ICh79nluHebHAzUDe+/TKq5FsvV6yl kM2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cimAsVp8esiQzNkZYPZL1E5oAEXkHIOZ+cMUM8NJYmQ=; b=w2gOf78u3V6Driqx8l1DdBXI0mky+T/f7DbMbGxUCkQrCZgemP/550Qn/5kNYuOGG3 2RGFSOymmDazneiElhd2aV4qaVUO/Vhdy0ndQWcILayvn5ExwyzwnTN0UtdntmIpzjdW i7Ndy4YsbVXOUcT9npoYngfuEawsW7XAM64uLgMc1x3iTuEe82Lpy5tvAR/BABpTXKGX RHf5hs3+6gVRE/fwT6ac9dMB5lf79DAGW0/gsdBtj3kqQMcJzsZFHFkwivoV3XIrMF5e W43X5ELw/gFKQMtUFAh6vekt9L/Ol9i1m+oRHOep4Z/Y0ilI0idKO8rXiJyXU35Xeu6u dEUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NnVERTGQ; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t3si5791736eds.511.2021.02.26.06.09.45; Fri, 26 Feb 2021 06:09:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NnVERTGQ; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbhBZOJI (ORCPT + 3 others); Fri, 26 Feb 2021 09:09:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:33798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbhBZOIt (ORCPT ); Fri, 26 Feb 2021 09:08:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BF0064E54; Fri, 26 Feb 2021 14:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614348488; bh=uX1wk3Re81K2lVoPsSrwtXUc+sakhXsAIMJ5zinq3DE=; h=From:To:Cc:Subject:Date:From; b=NnVERTGQUN+rGA6EO0PHEnol5K9bYRnc/JlBnFN2e2ZRG7+uKjEBijMfHILIkrmfX r7XSEOTs5IsdrQ8Ibz1ctJ17utIByWr/fOKS9H507BcVmGmLzuVpDdnbCmNHQnWcP9 Kck1muHldgCwdafyQa9i+rWP6P6NuTTuS00wpcHZq5U9BkW6SNULHzIAoUHJ1VPni0 Gv7E9w2hbFsboE/v1ndkoPJxmSyHe3wyC0Ngn25mqnW1ZB5vPLbDRgOP2fCZwyO54t IltNK0IZhwOHuDc0zqwgElHhaHMuRSGxsw11Pa7lbnnQsTG6VpWIRIbu5eQZfKboXc NCmCtW9PqMiJg== From: Arnd Bergmann To: Mauro Carvalho Chehab , Yong Wu , Krzysztof Kozlowski Cc: Arnd Bergmann , Hans Verkuil , Alexandre Courbot , Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: mtk: fix mtk-smi dependency Date: Fri, 26 Feb 2021 15:07:14 +0100 Message-Id: <20210226140733.3478898-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann The mtk-smi driver can now be built as a loadable module, but this leads to a build time regression when the drivers that depend on it are built-in: aarch64-linux-ld: drivers/media/platform/mtk-mdp/mtk_mdp_comp.o: in function `mtk_mdp_comp_clock_on': mtk_mdp_comp.c:(.text.mtk_mdp_comp_clock_on+0x54): undefined reference to `mtk_smi_larb_get' aarch64-linux-ld: drivers/media/platform/mtk-mdp/mtk_mdp_comp.o: in function `mtk_mdp_comp_clock_off': mtk_mdp_comp.c:(.text.mtk_mdp_comp_clock_off+0x12c): undefined reference to `mtk_smi_larb_put' Add a dependency on the interface, but keep allowing compile-testing without that driver, as it was originally intended. Fixes: 50fc8d9232cd ("memory: mtk-smi: Allow building as module") Signed-off-by: Arnd Bergmann --- drivers/media/platform/Kconfig | 3 +++ 1 file changed, 3 insertions(+) -- 2.29.2 diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 366df01c718b..f3ba26f4075e 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -244,6 +244,7 @@ config VIDEO_MEDIATEK_JPEG depends on MTK_IOMMU_V1 || MTK_IOMMU || COMPILE_TEST depends on VIDEO_DEV && VIDEO_V4L2 depends on ARCH_MEDIATEK || COMPILE_TEST + depends on MTK_SMI || (COMPILE_TEST && MTK_SMI=n) select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV help @@ -271,6 +272,7 @@ config VIDEO_MEDIATEK_MDP depends on MTK_IOMMU || COMPILE_TEST depends on VIDEO_DEV && VIDEO_V4L2 depends on ARCH_MEDIATEK || COMPILE_TEST + depends on MTK_SMI || (COMPILE_TEST && MTK_SMI=n) select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV select VIDEO_MEDIATEK_VPU @@ -291,6 +293,7 @@ config VIDEO_MEDIATEK_VCODEC # our dependencies, to avoid missing symbols during link. depends on VIDEO_MEDIATEK_VPU || !VIDEO_MEDIATEK_VPU depends on MTK_SCP || !MTK_SCP + depends on MTK_SMI || (COMPILE_TEST && MTK_SMI=n) depends on REMOTEPROC select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV