diff mbox series

[v2,06/12] media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN

Message ID 20210809225845.916430-7-djrscally@gmail.com
State Accepted
Commit d938b2f29be6ad5eb1b04c5bf0e3afa4348e9195
Headers show
Series Extensions to ov8865 driver | expand

Commit Message

Daniel Scally Aug. 9, 2021, 10:58 p.m. UTC 
The V4L2_CID_GAIN control for this driver configures registers that
the datasheet specifies as analogue gain. Switch the control's ID
to V4L2_CID_ANALOGUE_GAIN.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes in v2:

	- None

 drivers/media/i2c/ov8865.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Sakari Ailus Aug. 10, 2021, 1:48 p.m. UTC | #1 
On Mon, Aug 09, 2021 at 11:58:39PM +0100, Daniel Scally wrote:
> @@ -2143,7 +2143,7 @@ static int ov8865_exposure_configure(struct ov8865_sensor *sensor, u32 exposure)

>  

>  /* Gain */

>  

> -static int ov8865_gain_configure(struct ov8865_sensor *sensor, u32 gain)

> +static int ov8865_analog_gain_configure(struct ov8865_sensor *sensor, u32 gain)

>  {

>  	int ret;

>  

> @@ -2453,8 +2453,8 @@ static int ov8865_s_ctrl(struct v4l2_ctrl *ctrl)

>  		if (ret)

>  			return ret;

>  		break;

> -	case V4L2_CID_GAIN:

> -		ret = ov8865_gain_configure(sensor, ctrl->val);

> +	case V4L2_CID_ANALOGUE_GAIN:

> +		ret = ov8865_analog_gain_configure(sensor, ctrl->val);

>  		if (ret)

>  			return ret;

>  		break;

> @@ -2499,7 +2499,7 @@ static int ov8865_ctrls_init(struct ov8865_sensor *sensor)

>  

>  	/* Gain */

>  

> -	v4l2_ctrl_new_std(handler, ops, V4L2_CID_GAIN, 128, 8191, 128, 128);

> +	v4l2_ctrl_new_std(handler, ops, V4L2_CID_ANALOGUE_GAIN, 128, 8191, 128, 128);


Over 80, please wrap.

-- 
Sakari Ailus
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index 8c2b7d3cbc8c..a97e355c1e07 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -2143,7 +2143,7 @@  static int ov8865_exposure_configure(struct ov8865_sensor *sensor, u32 exposure)
 
 /* Gain */
 
-static int ov8865_gain_configure(struct ov8865_sensor *sensor, u32 gain)
+static int ov8865_analog_gain_configure(struct ov8865_sensor *sensor, u32 gain)
 {
 	int ret;
 
@@ -2453,8 +2453,8 @@  static int ov8865_s_ctrl(struct v4l2_ctrl *ctrl)
 		if (ret)
 			return ret;
 		break;
-	case V4L2_CID_GAIN:
-		ret = ov8865_gain_configure(sensor, ctrl->val);
+	case V4L2_CID_ANALOGUE_GAIN:
+		ret = ov8865_analog_gain_configure(sensor, ctrl->val);
 		if (ret)
 			return ret;
 		break;
@@ -2499,7 +2499,7 @@  static int ov8865_ctrls_init(struct ov8865_sensor *sensor)
 
 	/* Gain */
 
-	v4l2_ctrl_new_std(handler, ops, V4L2_CID_GAIN, 128, 8191, 128, 128);
+	v4l2_ctrl_new_std(handler, ops, V4L2_CID_ANALOGUE_GAIN, 128, 8191, 128, 128);
 
 	/* White Balance */