diff mbox series

[v2,4/6] platform/x86: int3472: discrete: Add alternative "AVDD" regulator supply name

Message ID 20230616172132.37859-5-hdegoede@redhat.com
State Accepted
Commit ebeb3fff9cd197a8890733e0af4eb06d8114cdff
Headers show
Series platform/x86: int3472: discrete: Various improvements | expand

Commit Message

Hans de Goede June 16, 2023, 5:21 p.m. UTC 
Add an "AVDD" regulator supply name alias to the supply-map which
gets registered for the INT3472 GPIO regulator.

This is necessary for the ov2680 driver which expects "AVDD" rather then
"avdd". Updating the ov2680 driver to use "avdd" is not possible because
that will break compatibility with existing DT / DTB files.

Tested-by: Hao Yao <hao.yao@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/intel/int3472/clk_and_regulator.c | 1 +
 drivers/platform/x86/intel/int3472/common.h            | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Daniel Scally June 16, 2023, 10:14 p.m. UTC | #1 
On 16/06/2023 18:21, Hans de Goede wrote:
> Add an "AVDD" regulator supply name alias to the supply-map which
> gets registered for the INT3472 GPIO regulator.
>
> This is necessary for the ov2680 driver which expects "AVDD" rather then
> "avdd". Updating the ov2680 driver to use "avdd" is not possible because
> that will break compatibility with existing DT / DTB files.
>
> Tested-by: Hao Yao <hao.yao@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   drivers/platform/x86/intel/int3472/clk_and_regulator.c | 1 +
>   drivers/platform/x86/intel/int3472/common.h            | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> index a5c60b86f5de..61aeca804ba2 100644
> --- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> +++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> @@ -248,6 +248,7 @@ void skl_int3472_unregister_clock(struct int3472_discrete_device *int3472)
>    */
>   static const char * const skl_int3472_regulator_map_supplies[] = {
>   	"avdd",
> +	"AVDD",
>   };
>   
>   static_assert(ARRAY_SIZE(skl_int3472_regulator_map_supplies) ==
> diff --git a/drivers/platform/x86/intel/int3472/common.h b/drivers/platform/x86/intel/int3472/common.h
> index fd2a3d3884fa..9f29baa13860 100644
> --- a/drivers/platform/x86/intel/int3472/common.h
> +++ b/drivers/platform/x86/intel/int3472/common.h
> @@ -28,7 +28,7 @@
>   
>   #define GPIO_REGULATOR_NAME_LENGTH				21
>   #define GPIO_REGULATOR_SUPPLY_NAME_LENGTH			9
> -#define GPIO_REGULATOR_SUPPLY_MAP_COUNT				1
> +#define GPIO_REGULATOR_SUPPLY_MAP_COUNT				2
>   
>   #define INT3472_LED_MAX_NAME_LEN				32
>
diff mbox series

Patch

diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
index a5c60b86f5de..61aeca804ba2 100644
--- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c
+++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
@@ -248,6 +248,7 @@  void skl_int3472_unregister_clock(struct int3472_discrete_device *int3472)
  */
 static const char * const skl_int3472_regulator_map_supplies[] = {
 	"avdd",
+	"AVDD",
 };
 
 static_assert(ARRAY_SIZE(skl_int3472_regulator_map_supplies) ==
diff --git a/drivers/platform/x86/intel/int3472/common.h b/drivers/platform/x86/intel/int3472/common.h
index fd2a3d3884fa..9f29baa13860 100644
--- a/drivers/platform/x86/intel/int3472/common.h
+++ b/drivers/platform/x86/intel/int3472/common.h
@@ -28,7 +28,7 @@ 
 
 #define GPIO_REGULATOR_NAME_LENGTH				21
 #define GPIO_REGULATOR_SUPPLY_NAME_LENGTH			9
-#define GPIO_REGULATOR_SUPPLY_MAP_COUNT				1
+#define GPIO_REGULATOR_SUPPLY_MAP_COUNT				2
 
 #define INT3472_LED_MAX_NAME_LEN				32