From patchwork Mon Dec 4 13:23:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 750607 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="IKAhwex1" Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F68D60; Mon, 4 Dec 2023 05:24:01 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id D9B866607285; Mon, 4 Dec 2023 13:23:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696240; bh=Zf8T0QawxN16ZAg63GdDflHcfaq5H6YtXv9s0/s7xXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IKAhwex1gFYRAx3hDHfxpFowqZMci/itc9EIWax2F28K5av71bY6AVFdDwDMabDkO F8pei7hGvnqijiEDT8b65C8XvUu4EI4ZZaDIHGzUqC4dquLlXEtD3yBW+Th49QhiJ+ 3oTpIFx23HMiPvuZ+zq0TnCF4aa8+6gsItQxoVcIQGVez444eYTocYRSL53yzBNCyk LdVOdnecbd5E1ZaknmOjUHASrCY7aw9X+yfCB/uWMGFMTBnmuutl2o4wPe7siRIfIS KkWz5t2H7+wjmFmUirL8yrcOdcungJwNuleDKCRkbG7mKeDHgUop1vsAFZKjENCoyb U3nnMlT5mKcNA== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Jai Luthra Subject: [PATCH v2 13/36] media: ti: j721e-csi2rx: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:23:00 +0100 Message-Id: <20231204132323.22811-14-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Jai Luthra --- drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c index ada61391c8d2..1e5f68f50afb 100644 --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c @@ -873,7 +873,6 @@ static int ti_csi2rx_init_vb2q(struct ti_csi2rx_dev *csi) q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->dev = dmaengine_get_dma_device(csi->dma.chan); q->lock = &csi->mutex; - q->min_buffers_needed = 1; ret = vb2_queue_init(q); if (ret)