From patchwork Sun Feb 23 18:58:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 867818 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4EA20E310 for ; Sun, 23 Feb 2025 18:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740337182; cv=none; b=phERSzAn2LP4zMJ/Dtk62yALd+VMVdRYU5ujJ3OsnMmqYDPEbg22NBPZ5a3xzPk6ROW3P8D6EG04PPHkQ4O/bBbnI4IYWqINSfUtagHPeMiFlhIooptzZ3IUdXpX1dirGUcV9f0OX1PVKTXNobrS5YDyNgfVem8bDPkrgE86ou8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740337182; c=relaxed/simple; bh=WmADWSvj6uAUkvJFbyL8wOMewg1Hx0JsVjiP96waOB8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T5AUmYqapv61y4CPBhBXTrs75ZSZCr+hyWBgk63sF5mNiqo8M3sPLrwddyDGGuvF2Xd6IjLxLn0iIC7cpBEYHeXIURaRM7jK2o4edozyDKUZQD5qHnz1l9ieHKuqpJfBYdiEjt+MyztlRlr7pUxqZN0Np45r2A59qcEUi5IMViU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dgLzfCTp; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dgLzfCTp" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6e86b92d3b0so2678726d6.2 for ; Sun, 23 Feb 2025 10:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740337179; x=1740941979; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LmMOjl+qwMNw0jD9DMRg4cojYEKleYPWUi1Y0A1e5HY=; b=dgLzfCTp/tGPFgPBuj1CO3pFLDfvWufi/QuUvGB6WXD2w+85I3hrs7zpVnmec87Fys TChxW1X1zO6qF0494NhlKMRG1DxsyHEKfeZAcahIr81p41i9BR+jbwh2kzEUD3A5a97j iGySdlCCdgpjTWTmSWSCiH6XVvz5i4f+5QMr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740337179; x=1740941979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LmMOjl+qwMNw0jD9DMRg4cojYEKleYPWUi1Y0A1e5HY=; b=kUMZ9zZr87+ETet7nZxINaRv6J5x+Req0X7eya9GYNOhdFmU8dFhDhTV8F8kWiCE7E C5S5+z6vLGoMvHynNkElrie4oFHxvNNYsy/EdcYc8+Htw9JAdQV02GMjxOhGZQ9YgO1k xs6gxNOasefcz7LAJfHUye7mOwMzFh1gYN3JZr51cA2BHsj98CFJ/sVkDuqvgzt2FU9d vULdUMWM2n+IVRKinFIr0jJ620Qxw29JCZIWWRY7OYv2DAm1YUSy8ZY9W5KMVVABhLME 5KaETqsxzX7Ownxj1/xz2f3o1ScvP4Yb9ftp3TAbvzdIlmwU0pqYf0t38ZsZwNT8hyQR HV1g== X-Gm-Message-State: AOJu0YxBD6Mhy5bLKduNmwZFBzv7raVMGBuczZ7kuqNbgkgUW+PNajVi CpPuqo0Sj8Iqs9DYnl4TfI513dZ6uO23Vn751CJqMu3a2nQuvfon0kYumk6FGA== X-Gm-Gg: ASbGnctCVjp8WI1lgXbwJlS3YrNVo6HkCkoCR5WmAi9bQP7QgzJdKXiW49sRIQOv0qF ekV6m+c6tmNSohnZMfie8YmpcfTCws2PB+6GDX5SP2RN9w/suj04XSSSizTMEj7ONgx+Kjeygl1 k5XqbWFxHwtAlS6v8coMWk9Y8C1dVQFg6Q0cbP0NX7kUSpefLV0tx5iGgldPwzC1plltWImIqID hIQenkPg77RTkqQBZBF+xJZW6uroxlFDXl/G+yyqhxREWvitFBfUqN+N9z+Mp9CoFw4VHDQrpRL 1oOzc2lRftr6r7/hM0kSEIzYuNA81mQrz8d9/7ZDx9NrZ2Wfn2XjJcZebjOzfFShCtBG08qCL3x +AqE= X-Google-Smtp-Source: AGHT+IG0N8p+jyjmOv+jFoMONGfZHngVMJ2/L46r6qBftBaVoQxFvMRvuW+hkaPMPsXXZun2oIuYDA== X-Received: by 2002:a05:6214:d4e:b0:6e4:2e00:ddc1 with SMTP id 6a1803df08f44-6e6ae9ffd75mr145374826d6.40.1740337179698; Sun, 23 Feb 2025 10:59:39 -0800 (PST) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c09bf81253sm894052885a.47.2025.02.23.10.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 10:59:38 -0800 (PST) From: Ricardo Ribalda Date: Sun, 23 Feb 2025 18:58:12 +0000 Subject: [PATCH v3 09/12] media: cx231xx: Remove vidioc_s_ctrl callback Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250223-queryctrl-v3-9-4292911cab6b@chromium.org> References: <20250223-queryctrl-v3-0-4292911cab6b@chromium.org> In-Reply-To: <20250223-queryctrl-v3-0-4292911cab6b@chromium.org> To: Mauro Carvalho Chehab , Mike Isely , Laurent Pinchart , Hans de Goede , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.13.0 The driver has been converted to the control framework in the past: commit 88b6ffedd901 ("[media] cx231xx-417: convert to the control framework"). This function is never called, the core will only use the control framework instead. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/cx231xx/cx231xx-417.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index a4a9781328c5..5a4b0f96cca2 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1538,20 +1538,6 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id id) return 0; } -static int vidioc_s_ctrl(struct file *file, void *priv, - struct v4l2_control *ctl) -{ - struct cx231xx *dev = video_drvdata(file); - struct v4l2_subdev *sd; - - dprintk(3, "enter vidioc_s_ctrl()\n"); - /* Update the A/V core */ - v4l2_device_for_each_subdev(sd, &dev->v4l2_dev) - v4l2_s_ctrl(NULL, sd->ctrl_handler, ctl); - dprintk(3, "exit vidioc_s_ctrl()\n"); - return 0; -} - static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv, struct v4l2_fmtdesc *f) { @@ -1627,7 +1613,6 @@ static const struct v4l2_ioctl_ops mpeg_ioctl_ops = { .vidioc_enum_input = cx231xx_enum_input, .vidioc_g_input = cx231xx_g_input, .vidioc_s_input = cx231xx_s_input, - .vidioc_s_ctrl = vidioc_s_ctrl, .vidioc_g_pixelaspect = vidioc_g_pixelaspect, .vidioc_g_selection = vidioc_g_selection, .vidioc_querycap = cx231xx_querycap,