From patchwork Tue Apr 8 21:53:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 879238 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2087.outbound.protection.outlook.com [40.107.241.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E9132566D2; Tue, 8 Apr 2025 21:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.87 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149251; cv=fail; b=peKieS33kMuBXNo3bZWGN87PO+/DkPoyxPYb/pinlt81xDad41RgxQgkvTEke5sAs1D4dVZASsNLJi17GPS2p/1aR6U7mVzgJ+KPiquq2+JyD/yTzJc2SeziGBFgJEa2FIwXwzmDAJhm57abFFjppYEoAmH2XyCnsGLrtkI4R+Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149251; c=relaxed/simple; bh=noXMKVQBMelK/ehK/17x/ZiLJCzT079DHPxDBWD1mPk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pRHurzhF557F/ptdVEtJUuptVR4zCIhAUKXjQsqA3JnlP6Gtgbr7K5ZHbM+dkZppcQzDJpXSBexSVItW6R+5y+O4St7A/uoi7ArA1va2R0c7Xb3hfOwzaf0AwKWwrFUnfO+QHLZYskk57f/ovaNm/bcqYEcPFszv+cjWslXmLcU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FjaG4ngC; arc=fail smtp.client-ip=40.107.241.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FjaG4ngC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oB24SjYArDcFrfPdfwXI9etj4gBp6+EDTz67zSV3CIQ509l7PIIdCmYOIiYIzCTyH68a6xPkCaZqrRHnZyH4QeHXZYA7wG98Af7fMEwquu6jmUHBGp7tPYOyrixRu11B4YGSZnhoKuFkNFf5kN2nsVj5F6zfOXPjorDka6z2ORHezldZurWiP7fg3VgVACnPej2T8UjEJ7dhm3VRd5k2oD+QEqDrS+ytCzx41Z/zKepnJ8Q0be/S8MM32XnfBaBf0fUYumBLYBrbyocz/i6iHZxdrG6nMus9l1TiG3jTwDbzHZqZm3Y2igXcjg5Qtf/uF7uYbIaHD+xBySAoQE7JJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Ydh2r1iRTTmID8c6vddANSkJyJZKA1k2Bb8KWqAxXs=; b=WNuIg8JVStUxVLEY6E8Ry1Qp/Fu32u7HouiUjpboqMM/6O63nL8zQ/Nh978RIiQ1Bv/+nToLKJr+DQAaF2O2oGeyqptFwn0iQmjdYDIZuJ0aQ+FR4Hhq8CVbizls1TXpgyCSKJZXzZLQZN6V7D/JPdx5vu4myWWvuwn14tjHFemzV76PlWILLrd3C9uTQKyzhxGC67IEM/+wipaPafPswnypGK+fQmuzJRpJkDBJgFuRi0IF1GFmcyjMB4GSUiiFDdfuXod2Yif/M7Ygc5WkOWFxAD/O68tZ9kSZyJWuGIcMg4dBXWjS/m8vvjndWbuiY0iDrjwDgNMH8zStY4FFXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Ydh2r1iRTTmID8c6vddANSkJyJZKA1k2Bb8KWqAxXs=; b=FjaG4ngCl/u45ifSGZqTD+bDUHFfvmbQi7QGyBtuR3gmtGAoIT9IVgp3Senl5sGHshNNk94qR64GsF7E80bCR87GWSyyaCueqTvxZ5DPY5ntp4cXFeUhfgGzCzlnaTyxfQbJbpWzHSo2JKmkNihjpcRlN5zbfCCp1EXEzX9KpFaetTfNNg0EUgXl56qbBjFlKbTgaHQGqvzBE5PP3eWqzkXIhRfAF2W38O+QoWkDHr0mkwO2B5UgOU27fIKvvzq/tlVLbQuwaAL2irNJcFriwj9pBKH3O7r+4MDuF3KVGdozBXkpjUTkaIRtPR55FmV9WqMAPoyKsA6SPRA2eK+NnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:06 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:06 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:01 -0400 Subject: [PATCH v4 03/13] media: nxp: imx8-isi: Remove unused offset in mxc_isi_reg and use BIT() macro for mask Message-Id: <20250408-8qxp_camera-v4-3-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=2902; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=noXMKVQBMelK/ehK/17x/ZiLJCzT079DHPxDBWD1mPk=; b=hxb2IYvh6f6/SswqYyMi62Zbf1dc5KaQJizcMsuXz/FD8R/DRB1bxW1ahI0sm9p+njbSavfI2 FVrbcra73DcCC73WVQBX9PXPDpiFeRHxoxEH7zu0YtF5jyMZOrLa4mY X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: f5f3a77f-f459-4879-231c-08dd76e7e229 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?eLIN8UnDx/uk2hEDIp8Pnzu/L6VJgxt?= =?utf-8?q?+lytWi0j4nXpomBzik4/Ih3g9Wkq/AZQun+r5NX2N/SzOP69xY1rVBKD2rXE2A94X?= =?utf-8?q?DOONiUDfnQK3jf0AdpuX7ZShE02JdykcFKSGLbhoDBzK1Bt6EE4k5jJKxa+/FOEMp?= =?utf-8?q?VJ67bW29W9NBt8Ya4SIM67d7t2RphjC94dBEWbw1ThkZyKcFNPapeQOge6XsSIPHk?= =?utf-8?q?iN6BxhP+7efiXtj1rG5R1GZICAID0mhZKM4Sg9sJpVLb71rNtfuy4j1KDLxTk0QHs?= =?utf-8?q?yMrPXtuxpoYOV0xKG3USwchnUO11wnSOhgwRPgLadDY2rdJ3LdOr+7Tb4Jfdvop41?= =?utf-8?q?YeGYyhSjs7HTvgwWRA479uYXYco846Pmgs1bfd6ZOMRQ/LfmVYyTL6hG8fdNWKWBq?= =?utf-8?q?KvcmvDlhJ6YRZzTh2zWuAd4BtrixCOy4kQfx0DIMDRePb4KcSicgXOIey/PIKFHdB?= =?utf-8?q?Xkq/Kv3OSc6f1Ce5EZbt5YHifJ8Xy5Gj79O+aedcaEPozdLpJio93La9dIuoHRxGi?= =?utf-8?q?IH8rSPlE6LqHosE6odzrRTSoolUczw/ukuR2aisPiYLHKhZvYG3y4C3RBYXa6n8uM?= =?utf-8?q?4C6zSsjtB2dAQPXF1nprWVdHlqKzyXdfBjlPDcRdAy5xF7WydYGnQC+YoOAvB/2Kg?= =?utf-8?q?wOxKizBtaGbD1GgZHin4/Deq3dZny/ISTfCMumrF09lDNTqVjMGOH3k55hLCL1tk6?= =?utf-8?q?hEGDd1cFDcMUvuWMwzwDwNkHq+0gsLCSJJNZY6qEMQvVrpsUQkKxQST72gy9qwPap?= =?utf-8?q?80gzyGSlXPdsSaR643ZTshN8SJmOEQHUtfjEd1NzIGZ1YgDP8X39UdGTMjLQ1NBNc?= =?utf-8?q?AgUnxJb1lYBSA+HjS2LTZKp/umy62tsK7/kfRsF9VxxoMDdCnN5tY3cnSwi/+wfwx?= =?utf-8?q?MrOaK+WW3ar9KowxS5AOZ0GIbfKvML+zTY/C58KXVFl0BhgstBLHDMnnxkbcdo5DY?= =?utf-8?q?HtPbXUh1GsAlc0r+OJwHDv0moTRvcwVC5rzYI7BefFe5KMtfN0gp7MeaegWLoRF9p?= =?utf-8?q?CjySAlI9ZTYnW15xMiSX2zEK5XQvXyCbJ5oAgWZw4mJpcimmuOshE/TZH9HvW45Y2?= =?utf-8?q?Cc5u+ug2iBwVzj82CW8jmNNfrkowP3PE4i+9Nl1W8mApHyKqCK13jCvnOCBMpUPQC?= =?utf-8?q?x4VZaHfQL5x9vrGzQX6XS2iZDbpP8s+GOzlWAILqcccC1utbqBFXZ2BFS8HSZJblz?= =?utf-8?q?rOrpZG6aGWA7b+Xtm0xFKGwZSOVgy+FngZ+0BHl6zotuihfSWRxEUqF003UP25fVz?= =?utf-8?q?rrRP7DcKd6g2tpUUb0+Wbu4GdqucYjQHCgw9AnT2+hbS9vDKoa2cpj7okZapBiEXS?= =?utf-8?q?vOFQTbAyoQKn87lzwkgLhgiV6IhaMf8Q2BLJ0OQ0SSprnRnSOKRNf0SbC7Rzehqj6?= =?utf-8?q?794/hOfjN6j8LBc96AdXBPT5MbqeQ8dHw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9642.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?UM1LcBp73fDVgc6TLUV2hNa359zl?= =?utf-8?q?Pk0SGOt6T+03u/rVngWBZwlAzPdfHr0RU8CVPRT8GrNKms/rKsPTBWcEiluB/+Pp3?= =?utf-8?q?O+6VTAVwZNLtZHqpRWur2CDZq/XGp8Z8+1SDIAozdQ/zVpFUayhgF9cZERabgXroC?= =?utf-8?q?bjc6OEec5FT6UIclUX/Mj82dqgbx1pESLBPNHxylDqzzpgOD5JuxbQ1y6dJChia7d?= =?utf-8?q?xyYSmgg9/ptVTVcykgbY3XSxl4o4ax9EnLTDdMMmauABxBlG7y4AAnlJbTjBphQk/?= =?utf-8?q?dbDzFfGlU+RHTnlMWydNPAgDB+7hfTgkeR9XoCoN8mH/VshNmTdgNA2ZEUYcmy9AF?= =?utf-8?q?zkKnlwR/vU0zhXJXYFTvWhePFjvU9GgDTifBvccf0nEwkQ9c39K3Pt+g4gRmtpl83?= =?utf-8?q?PQ5lCSr4J8I15E4paeTGXelfidFtINl4OVN0ufmVTF6O1RMdta4u+IrWSL3wCNWxL?= =?utf-8?q?VEQs1js0DHBcCRmFzduAuc6uEQRf4HvK7WPs6Ld1IBoRe7rkkI9fQHa/PaNJEn4Q0?= =?utf-8?q?9tf5mdH9+fW9cutThzz/HpVWgvX2HTjn8PmH8oYCNepnJ/H7vU4Ht6VzFlJo6SsGR?= =?utf-8?q?hBwRKXv2SYUKcosY52IbQ+fO3MyW6ltXOaorL4hEc+VIOKv566w76M9lzmk0IhvL3?= =?utf-8?q?WlEHWQtRZCp4J8VpVO7xApAvxc+AzFFFzQGnPXxpxxA/BF4mpXTRYVqiiJ1SkBL4x?= =?utf-8?q?sHM0DeS2wpMrc1+FhUM/fuRSAYL+rzqGMtn5pn1bu+j5YQ/b5ccI6Jdn32ZvSJuxe?= =?utf-8?q?lOcSK9PYWbRQkdUAZalgTdCGismjifjfZM1ClVDzf4F7X8u8zDY3apEGEHAvwmWcs?= =?utf-8?q?fHw54LHAzsFXFK03O7krwCXvHiMKHL87wO8/jIueDwVjpuV6KsxsgBP/VlsCcmLjS?= =?utf-8?q?4yay3Cui1tZ2140DbCMQ07xfRPcMk9j2icX6L55UMiya1/TcgoDM7Yo36BEbeGK80?= =?utf-8?q?YjcAWcrxxUFdALNLNcOS+z6PTMhvCCGgaE4zTdtR+UwZyihKn11QrSxJALAWmJDKk?= =?utf-8?q?j34n0wijRl5v5Mn+8xwCYY+pBTb3TnQH6vLqFzhD6jCMmCWUXuq6QVJe53yEKTEvF?= =?utf-8?q?q3glQbmSXLLRAjmm832DIhHInWeQ5KO+56d7WYCCIMFZRG0KDfyJIA+8jF7260TXI?= =?utf-8?q?7kJKGIBmur49vHeuWYbAT4bU8o8XRJSXk4qG22yw93YlYBBmQFts0a0XFgQLab1af?= =?utf-8?q?exsT00W1zP+O/U9Cf5C1ipvWgBP0N8PdiRfgiuwzVcwj1BnXo0t7+q6/3mO+gqvK/?= =?utf-8?q?68BawZzneeZnw3wtq3FCsXQELac6uSoFoIzi2+dLGV4w1bofI+wsZi9GQZYFbeejA?= =?utf-8?q?3xSp5TZDiaCwIetYPepBJfaaDirahZjCFqcoDF82Gm9+dHU8YyVYFjKBtk8lN+8lv?= =?utf-8?q?hcZo6OB9yOSk8WhTxCsRqfSucjLtW4bLOew5A339vzKVRur8hlhkcudox7d3w6Z0y?= =?utf-8?q?e2ilhVV+HLbyBO0SymB5AthLHeXoZORq6k+UUf7/Xcrf2jAhKJqT+2GU=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5f3a77f-f459-4879-231c-08dd76e7e229 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:06.2193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r1GisRr/EmJb/s+XpbEy0vMm7WHdp8TseKdDKOTNxMPJ0uP+6uEhgWIi+iwOWIQHpw/vbSzQksiKku6MNDyjGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Preserve clarity by removing the unused 'offset' field in struct mxc_isi_reg, as it duplicates information already indicated by the mask and remains unused. Improve readability by replacing hex value masks with the BIT() macro. No functional change. Signed-off-by: Frank Li --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 25 +++++++++++----------- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 1 - 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 1e79b1211b603..ecfc95882f903 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -3,6 +3,7 @@ * Copyright 2019-2020 NXP */ +#include #include #include #include @@ -247,24 +248,24 @@ static void mxc_isi_v4l2_cleanup(struct mxc_isi_dev *isi) /* For i.MX8QXP C0 and i.MX8MN ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1 = { - .oflw_y_buf_en = { .offset = 19, .mask = 0x80000 }, - .oflw_u_buf_en = { .offset = 21, .mask = 0x200000 }, - .oflw_v_buf_en = { .offset = 23, .mask = 0x800000 }, + .oflw_y_buf_en = { .mask = BIT(19) }, + .oflw_u_buf_en = { .mask = BIT(21) }, + .oflw_v_buf_en = { .mask = BIT(23) }, - .panic_y_buf_en = {.offset = 20, .mask = 0x100000 }, - .panic_u_buf_en = {.offset = 22, .mask = 0x400000 }, - .panic_v_buf_en = {.offset = 24, .mask = 0x1000000 }, + .panic_y_buf_en = { .mask = BIT(20) }, + .panic_u_buf_en = { .mask = BIT(22) }, + .panic_v_buf_en = { .mask = BIT(24) }, }; /* For i.MX8MP ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v2 = { - .oflw_y_buf_en = { .offset = 18, .mask = 0x40000 }, - .oflw_u_buf_en = { .offset = 20, .mask = 0x100000 }, - .oflw_v_buf_en = { .offset = 22, .mask = 0x400000 }, + .oflw_y_buf_en = { .mask = BIT(18) }, + .oflw_u_buf_en = { .mask = BIT(20) }, + .oflw_v_buf_en = { .mask = BIT(22) }, - .panic_y_buf_en = {.offset = 19, .mask = 0x80000 }, - .panic_u_buf_en = {.offset = 21, .mask = 0x200000 }, - .panic_v_buf_en = {.offset = 23, .mask = 0x800000 }, + .panic_y_buf_en = { .mask = BIT(19) }, + .panic_u_buf_en = { .mask = BIT(21) }, + .panic_v_buf_en = { .mask = BIT(23) }, }; /* Panic will assert when the buffers are 50% full */ diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h index 9c7fe9e5f941f..e7534a80af7b4 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -114,7 +114,6 @@ struct mxc_isi_buffer { }; struct mxc_isi_reg { - u32 offset; u32 mask; };